From patchwork Tue Mar 11 12:36:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14011763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D285DC282EC for ; Tue, 11 Mar 2025 12:36:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0583280008; Tue, 11 Mar 2025 08:36:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB437280002; Tue, 11 Mar 2025 08:36:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7D02280008; Tue, 11 Mar 2025 08:36:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AA90F280002 for ; Tue, 11 Mar 2025 08:36:55 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D07081CD205 for ; Tue, 11 Mar 2025 12:36:56 +0000 (UTC) X-FDA: 83209219632.05.E83BC03 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf02.hostedemail.com (Postfix) with ESMTP id B19078001D for ; Tue, 11 Mar 2025 12:36:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NddWzfVx; spf=pass (imf02.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741696615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=7qYs9YHqi3o8BYflhXgM2/h7DX07No2svICRJmWY6FQ=; b=GlUWAcopUnC9pwe4NWKH/ZVqdMdF+cFjIPfe4pFsmfgGcxOE6gKQCFL1FsH9kUzads798X d+JVk307qgKSFSa400DFd3soRpYrVPSwXOG86HT+m5FD/BIfo26I8LQTJYk8h3trsWV5Hq B9D2ENTaTncJT//5pA9vRQQ3TNxIfbo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NddWzfVx; spf=pass (imf02.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.67 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741696615; a=rsa-sha256; cv=none; b=2Zr0M7JqZ6tLzpHJd5rTxkIg8TAeiyxphG6lpBZmFt0HsoyZZEPmaCCPBODUWg24q0e0gW j6dTBJbhkFo5bkWVHhNplknOpprE498ejWZr68X/r4fUAo6TxIhf0AaC5ryRIBwVU07qMz AFkaK2G7LQ7ik2WibJ3W9wDlzZyqAi4= Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-3912e96c8e8so3019891f8f.2 for ; Tue, 11 Mar 2025 05:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741696613; x=1742301413; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7qYs9YHqi3o8BYflhXgM2/h7DX07No2svICRJmWY6FQ=; b=NddWzfVxBNadq+WlZIBwKGqum1o9ddKSSriiMxTmEaGzkdi6Q/J60RMyY1TKqpN+Vn ZZSpdUpXekP6C9I36Sh6+5y96/ZX1ub7haTa3mJHMZLu/60swB0jpTgahIPofp4OU0DN /9VdGvE91mTT2EJRllGSj1JM/S40ZIof/CP32gKdUUt5qGqDtZ2ewTIqJ5Xxc211cDGH GzgJpdKuuNPcMv91GI8IDpPMKZxpsIqxj7qzYJKAfmT4tWny11e0DowCTbXQ6ak33KBD reyYV2ttJ0CkeOSJQQ/4fLRDxJ4azZanmrl/+NnCUdRXtHzYDZpGnVdBRl+2a/vr2XQe 4Uog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741696613; x=1742301413; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7qYs9YHqi3o8BYflhXgM2/h7DX07No2svICRJmWY6FQ=; b=bzvDYRdWc5ajhXiSVsX6ToVdBuNJPnbtLtrazoSB9kYFHUV7ZR32TJl1d1fn90R2tE Gs8fisGVpK3pcxPg6SbnbYDp8JolwxvGjC8hdv9M+YLljIO8vcbW3+S83NwzGK8X+f98 QgPH0KhqpI6XODlAm0sSHzE1F5Z8aMx4Ebz1Dkc3lIvjay1QM4RKZCDThIWSfQsrqfdR Yx4tlHOfiXCDDBlB7TaDVPj5CRSEPYXI1FbXY0zs3seYfJjA4I3/MsYnd1X0ZxonLTAa MueOQieCjZlpS2zKyhDKCMsiot9pEBwTISZDr7XRyAry0XHL3uWaYGaQdaLXjOcWdxCS PXeA== X-Forwarded-Encrypted: i=1; AJvYcCVDupwZ1mqOyWXnxqDW8wT1ajT/QGXIm1o9bxDb+rChDzAktgK72j5ya9cCbmYMijQSSOWh7x7Gew==@kvack.org X-Gm-Message-State: AOJu0YxlKWdaiFNZD1S7Au4BMEVEzQEx1sqMNehBtVqndQ7adCYaEtjw JUi/KxRk7K0MqF+k3pCafv4kxLWz8FRHlrlgQv/tcWw73aPsFm+53T6mhzNrw8g= X-Gm-Gg: ASbGncvPTtTbgOLR8NJdxfQ314qsBd/rSt6eoOZU4EawPnd/pNyC9lO7i0dQvcaGsWS xqkj4Ajela5m/SNx6yqSTRAtRg0htEWIs3OnvGSWgUka56S5gHOurN0RvsnJkzESl2ctFMK42eA EqLSe8Uw3oOImN98PCPix0Sn+7wnzMkIBJfVMO2EzhXufLLbph6CQxGSjeIaXNVXQ1Q4nDqTs86 ZNHqK7BVdlJxnm0Ssj90WNsI3FuP6WGnEK9hz/L/5EEPRPXme0rEMH57bqau2t2UqZ7isCplHug GNzcAv0BqYB8kjqBPPGDYK2SrjiPOiuovwLMkT7wSZBG+HxsXNK1Ee0V4w== X-Google-Smtp-Source: AGHT+IEBZYqz4EXYjBrQl7MEBAEBtNENBPTwZcu8eE/AXSvpLAC27EkQUSrI1TFPSdtbH6FbRzmNrg== X-Received: by 2002:adf:b312:0:b0:390:f6cd:c89f with SMTP id ffacd0b85a97d-39132db6f86mr10434242f8f.53.1741696613012; Tue, 11 Mar 2025 05:36:53 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d04004240sm9742265e9.3.2025.03.11.05.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 05:36:52 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Cc: =?utf-8?q?Michal_Koutn=C3=BD?= , Josef Bacik , Waiman Long , Jonathan Corbet , Andrew Morton , Shakeel Butt , Roman Gushchin , Johannes Weiner , Tejun Heo , Muchun Song , Michal Hocko , Jens Axboe Subject: [PATCH v2 00/11] cgroup v1 deprecation messages Date: Tue, 11 Mar 2025 13:36:17 +0100 Message-ID: <20250311123640.530377-1-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B19078001D X-Stat-Signature: y13ga5twud86nzzi3gx1suhqsxxa9um9 X-Rspam-User: X-HE-Tag: 1741696614-304098 X-HE-Meta: U2FsdGVkX1+Tig7YlsVc65ALWlqFykpfHxaPqz7Ol+80S/lCyl+x5V5tyOaxs1H7eJrQKZdqTk9cRDGT2Nt5/X8acUai3uffFTDq4aW7v81pj+5nVlfRqUlPLyKhWO14yAmYNv2YsJ0KFp3hbEPRwhIdfnzoHSydWkEwI6NqQF/fTxa7gGPXu59UcQvX9lcyTad5ZGtgmfjvJ+6EyFm5FSnxcLWm+XShErjhFAKxcBb98M54clR7jfixhAzx1MqRU04j7AbFYJPinpqSj5xuwborhEIc7zF87Vw4ma2/Ot8rdFW7nOm++wDauMfwuuWQ8K7pB7mnFqxafG5AOlKzDrwb4ljaOa8iSJITtABF9LoZsFnrX7T1gr6UF3v7vto5Wia87SBy/gfDNtbAQDrpauZ+sRwre0AFIDqLMvEPmCZ5HwP/QniOP4WQ2fZoPBGStGdAgPW61KMkl+yjIw6G7XgSjn6ipXcjGQMmcFq237tkoXA40iavIjxxrTSCQM2G9du5nYvnKt2xgHJBXf9oRQikjXFUSpc245SWHrc23NTI9JSvtceFinzVt3OGSbz5t2ahdI73ZvIl+hJL/BYjTEgxSYuIGLmQiBIh7vSnOey2xDT7SifT+JZ/daHGN/B8r7U7oWS6k+MzYmEBzBaMi9nGX/DpfnGAhw+PSL1WP+KrLWBTdu0oLwMiJFHrAsirPyMqDlYXSzXW0YMxWX5yK2awBtb93HcvtSlYUkrCprg+gCBy04SBugsX63/5o/Y+vSpfarijiZQeoHVYbxPoPFYAupVcOBE+7dcq9yP827EaEGOJroVFpKn7vgdqv33a5Da0IESJqD7/lXaNNp0niJXypQxryAnizVy1EwiqnToMn0sojnm0G16NI/sujkHqFa/FtPUXo6Li4VtE0VYRKHQ35/Q8uSsNfSl/IHKH3iiR28oTU30UH3OEA1odhOTnSQDULiwYzCkVq8BYw8x i8b0zWun RbKHAJart5bYrQx55T7+uzw1mGyaiIqnUbWJLugfzRTAli9om3M0O67MNP5oLMsL1qfqHUCDY5L2T3Q3nbri+mWiBfbOfSyX+XAayzHMHABPTkkofIFirqJWFkHmvQOhSJEpXm3eMmlZ4nJhH72ix5Tb7VoVj6WtrPxVBY18V4KZjxYS6LIKoDjZREsMViyVA5rBI4nCWuRYETJ5uR851QiEHwWyI8KyROECgvU4bWLzcycWHd7l42bkTLaqHvhT4baciAOUMj8+lsvoTtYw6aJi7RaczkJZteqsEd/0bBCI7VQIhtU30JNzLbG0z39/xTw9w4UCVxLX6R3rVrfwtFvyS04iOh6tI3kFf2WtONUxqr3G2ff4bncsmAp1eqs+pPE2J3oH2SjhimCLhz0l8bvSV5Z94/CJGPrpYx2eGuKAPepGv4Ss83TmQRcpjuCFc13kFFKMutmB8RBOpIUXl4j7EtWOjLWFyrKZ/D4Ed/iP4/DCGUi9qmVZKCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Memory controller had begun to print warning messages when using some attributes that do no have a counterpart in its cgroup v2 implementation. This is informative to users who run (unwittingly) on v1 or to distros that run v1 (they can learn about such users or prepare for disabling v1 configs). I consider the deprecated files in three categories: - RE) replacement exists, - DN) dropped as non-ideal concept (e.g. non-hierarchical resources), - NE) not evaluated (yet). For RE, I added the replacement into the warning message, DN have only a plain deprecation message and I marked the commits with NE as RFC. Also I'd be happy if you would point out some forgotten knobs that'd deserve similar warnings. The level of messages is info to avoid too much noise (may be increased in future when there are fewer users). Some knobs from DN have warn level. The net_cls and net_prio controllers that only exist on v1 hierarchies have no straightforward action for users (replacement would rely on net NS or eBPF), so messages for their usage are omitted, although it'd be good to eventually retire that code in favor of aforementioned. At the end are some cleanup patches I encountered en route. Changes from v1 (https://lore.kernel.org/r/20250304153801.597907-1-mkoutny@suse.com/) - cpuset load_balance/pressure warn wording (Waiman) - comment typo (Waiman) - collect Acks - drop bouncing Cc: and respective RFC (self) - change level warn -> info, except for spread slab (Tejun) - add memory.swappiness (self) - add legacy freezer message (self) - update cover wrt net* controllers (self) Michal Koutný (11): cgroup/cpuset-v1: Add deprecation messages to sched_load_balance and memory_pressure_enabled cgroup/cpuset-v1: Add deprecation messages to memory_spread_page and memory_spread_slab cgroup/blkio: Add deprecation messages to reset_stats cgroup: Print message when /proc/cgroups is read on v2-only system cgroup/cpuset-v1: Add deprecation messages to mem_exclusive and mem_hardwall cgroup/cpuset-v1: Add deprecation messages to memory_migrate RFC cgroup/cpuset-v1: Add deprecation messages to sched_relax_domain_level mm: Add transformation message for per-memcg swappiness cgroup: Add deprecation message to legacy freezer controller cgroup: Update file naming comment blk-cgroup: Simplify policy files registration .../cgroup-v1/freezer-subsystem.rst | 4 ++++ .../admin-guide/cgroup-v1/memory.rst | 1 + block/blk-cgroup.c | 8 +++++-- block/blk-ioprio.c | 23 ++++++------------- include/linux/cgroup-defs.h | 5 ++-- include/linux/cgroup.h | 1 + kernel/cgroup/cgroup-internal.h | 1 + kernel/cgroup/cgroup-v1.c | 7 ++++++ kernel/cgroup/cgroup.c | 4 ++-- kernel/cgroup/cpuset-v1.c | 8 +++++++ kernel/cgroup/legacy_freezer.c | 6 +++-- mm/memcontrol-v1.c | 6 +++-- 12 files changed, 47 insertions(+), 27 deletions(-) base-commit: 80e54e84911a923c40d7bee33a34c1b4be148d7a Acked-by: Jens Axboe