mbox series

[v2,0/9] Remove aops->writepage

Message ID 20250402150005.2309458-1-willy@infradead.org (mailing list archive)
Headers show
Series Remove aops->writepage | expand

Message

Matthew Wilcox April 2, 2025, 2:59 p.m. UTC 
We have just one filesystm (vboxsf) left which implements ->writepage.
This patchset converts it to writepages then removes all the callers
of ->writepage.

v1: https://lore.kernel.org/linux-mm/20250307135414.2987755-1-willy@infradead.org/
v2:
 - Added ttm patch
 - Remove f2fs patches as they were merged
 - Add 9p patch
 - Add warning in migration code about aops which set writepages but not
   migrate_folio

Matthew Wilcox (Oracle) (9):
  9p: Add a migrate_folio method
  vboxsf: Convert to writepages
  migrate: Remove call to ->writepage
  writeback: Remove writeback_use_writepage()
  shmem: Add shmem_writeout()
  i915: Use writeback_iter()
  ttm: Call shmem_writeout() from ttm_backup_backup_page()
  mm: Remove swap_writepage() and shmem_writepage()
  fs: Remove aops->writepage

 Documentation/admin-guide/cgroup-v2.rst   |  2 +-
 Documentation/filesystems/fscrypt.rst     |  2 +-
 Documentation/filesystems/locking.rst     | 54 +-------------------
 Documentation/filesystems/vfs.rst         | 39 ++++-----------
 block/blk-wbt.c                           |  2 +-
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 32 +++---------
 drivers/gpu/drm/ttm/ttm_backup.c          |  8 +--
 fs/9p/vfs_addr.c                          |  1 +
 fs/buffer.c                               |  4 +-
 fs/vboxsf/file.c                          | 47 +++++++++---------
 include/linux/fs.h                        |  1 -
 include/linux/shmem_fs.h                  |  7 +--
 mm/migrate.c                              | 60 +++--------------------
 mm/page-writeback.c                       | 28 +----------
 mm/page_io.c                              |  3 +-
 mm/shmem.c                                | 33 ++++++-------
 mm/swap.h                                 |  4 +-
 mm/swap_state.c                           |  1 -
 mm/swapfile.c                             |  2 +-
 mm/vmscan.c                               | 29 ++++++-----
 20 files changed, 101 insertions(+), 258 deletions(-)

Comments

Christoph Hellwig April 4, 2025, 8:31 a.m. UTC | #1 
The whole series looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Matthew Wilcox April 4, 2025, 1:42 p.m. UTC | #2 
On Fri, Apr 04, 2025 at 01:31:11AM -0700, Christoph Hellwig wrote:
> The whole series looks good to me:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!  And thanks for removing writepage from some filesystems.