From patchwork Sun Apr 6 02:40:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 14039285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3A1C36010 for ; Sun, 6 Apr 2025 02:40:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A86CC6B000A; Sat, 5 Apr 2025 22:40:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A37A06B000C; Sat, 5 Apr 2025 22:40:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FE5E6B000D; Sat, 5 Apr 2025 22:40:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 727F16B000A for ; Sat, 5 Apr 2025 22:40:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6BACA81525 for ; Sun, 6 Apr 2025 02:40:39 +0000 (UTC) X-FDA: 83302065798.03.453FD78 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id AA416140005 for ; Sun, 6 Apr 2025 02:40:37 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CG+DMnsm; spf=pass (imf26.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743907237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Bk43KL+s2l5fV3lGaddeDBguiZ6SUsPQ8knSF6ClKoc=; b=IKTt8WMq4azpd5avPcQgVTrgyMd1SHeeF4Vpy80IxjeDsTagUhjmvOB6Vd+dPhpEueXz+V 7E15uPGlxIa21WBx+ierzk9FVphQ8/9pYmI7KMRMdQGdhIPW/pmwKlaMQU38TrX26rtOEF edLJXFmAsfQYcEaS5BQkKvFshxxbBKc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CG+DMnsm; spf=pass (imf26.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743907237; a=rsa-sha256; cv=none; b=zWKh6vIzbonyXzsPZFBYjB9Ld83G7w0xtI1+Ij1UKXtkyjVXDEaxXw31ouXIxM+0XvEVrp locE3PW33EpaUMnmT3KMIF7oNDLiH4Pl345tmmSMwotwOVBMPE6eqjTAoBB0sF7N7fKKeq Ttm1SCKcuP0gb/oeUOOwhlmSmzM4fCc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743907237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Bk43KL+s2l5fV3lGaddeDBguiZ6SUsPQ8knSF6ClKoc=; b=CG+DMnsmnYpfYgw7S+PMJT4taHE2DjsdF9YHUVYJECSiZb7qNuL0/EV0bJmMgq1YcfT+uZ VqMNfODmMP7wC52qBYm9uB23buRj+Z8RMa2kOE1CwAaWAxt5ONsGx8W1lN1URyAJ3LIsuC yWw9siZgC0bmKstOFLNqNp7wscUc6Ec= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-qdtT_OYuNF-o8UWDoInYEQ-1; Sat, 05 Apr 2025 22:40:32 -0400 X-MC-Unique: qdtT_OYuNF-o8UWDoInYEQ-1 X-Mimecast-MFC-AGG-ID: qdtT_OYuNF-o8UWDoInYEQ_1743907225 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E17219560BC; Sun, 6 Apr 2025 02:40:24 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.64.19]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0B85F180176A; Sun, 6 Apr 2025 02:40:20 +0000 (UTC) From: Waiman Long To: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , =?utf-8?q?Michal_Koutn=C3=BD?= , Shuah Khan Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Waiman Long Subject: [PATCH v3 0/2] memcg: Fix test_memcg_min/low test failures Date: Sat, 5 Apr 2025 22:40:08 -0400 Message-ID: <20250406024010.1177927-1-longman@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Queue-Id: AA416140005 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: kzcind61gir7um5yz5trqk1ez98pd6zs X-HE-Tag: 1743907237-933021 X-HE-Meta: U2FsdGVkX19QZ2fnuigGRXHQlKz2yxPZWzFjh0GgsE4YYSCFosonfxzRtBMk5js3fV+J3+zahj0R9jw36MMdJOQEt2oMLCH6ibJKNf/g2TyJOzBtXe0vDegPbMVdseeRncblDpSaET56JXhpNuVBceK0Rn2lq2yvUQBguRANP2dqL2reNrDcjx30wzL+4/ubIgOKiw0TsP4Iw4qvWDGdxmNAW2ZjwGG7oquZebGTohaUMYAfKwAUK1SHKCTSWzxHZhlji1efB+VFin+OwPhQZwbH4ml410A2GqtYkwpBdCQfBuzS8LxH2E9Lj+dhjeJQVsf9GF+v9G5oSVlOrb0eUwnKUAr8ALOYSox65tdulqOBCtgsAStL6Z8OUPjbt8G9FAk+hHx9U970Bxmy3hFZR9JkqQhm0pmPltnRVIl8JFRLEJuFxyC/EZe3HOD33CVQzw/22BCRdPDE9/QaesSDLuRXnRiY5b9qGaRHGxLxaMhqOu2v910l16NPAmG3i3Ax0h8furAn+nH8ol8d+KFb7xE91Lv14DqW0anM0qd1FGInOj4SK6y0IPYY84avL5KWWUajrp7gFaSIT1ftlvjGJhker+2HUhd5Ex7iFnzyaktcczMUm38mykSmYj04ZZlCEuxhZQae3UK9KW5vqnlccG+Kly5k+Ez4a86N0yjApt99K/eOw9yY00oXCunonDUstd+SxV1tc/+8A0NprVrAXo25ls9AM4SiVbn9ptIKkykBl1wEBzENPjT7e7jzmf4B+acIl5E3qJ5LCQcs2tq1MBzL52tBtyazADbqsWbRohH12kx+kjlpPtdfHW5gUZWCIzMlfSvKdWL75Bd/DVBSqYuRQrneMCRlWKubN+Kwf3PBTzI5Xg0K0nAUyBxIqGOgwdqAeF5PZTNJ4NhVShTfV7UPOsEGtGbd/MjOrb3Qj8PvCyZzShzftre6y7Gre70xoxU9VbFKpwggCLj+Hbq 7uDzhyCs Yyf4uLtfwEunKf3bEi1KVIdOyTU3R4lpuzDkhoEJmnVN4gH+TyGmxlAsZLnlU6pi8JjSmCy78EtBKSCfrdMFClLnY6sCQpYgfnBhCrC/ettlxXctyYoQd7Px1VuwK0rg+FjEiXLTzLIwgD3Rp3qVmMY/L5oI2z+mJDFDC8CmstoMQ96Z2SYIljXv9lMrwodP8zq/z7U1vcO6kgjL5gUfrABIcp0ecNxxjf91vS3UCJi2UrlKOJTr9MiOE8DZjcvPkW/ZxO5Ln5nzRfp0J79dk+YTTknwWHhqjybW0yKHT7VIVPsPW+Yky7KyybIjnJ5ipP0bM4sSbJnWre8gCYhzFXAjkTqQ32baRD1eW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: v3: - Take up Johannes' suggestion of just skip the !usage case and fix test_memcontrol selftest to fix the rests of the min/low failures. The test_memcontrol selftest consistently fails its test_memcg_low sub-test and sporadically fails its test_memcg_min sub-test. This patchset fixes the test_memcg_min and test_memcg_low failures by skipping the !usage case in shrink_node_memcgs() and adjust the test_memcontrol selftest to fix other causes of the test failures. Note that I decide not to use the suggested mem_cgroup_usage() call as it is a real function call defined in mm/memcontrol.c which is not available if CONFIG_MEMCG isn't defined. Waiman Long (2): mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() selftests: memcg: Increase error tolerance of child memory.current check in test_memcg_protection() mm/vmscan.c | 4 ++++ tools/testing/selftests/cgroup/test_memcontrol.c | 11 ++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-)