mbox series

[0/3] ucounts: misc fixes

Message ID 871r4itfjw.fsf_-_@disp2133 (mailing list archive)
Headers show
Series ucounts: misc fixes | expand

Message

Eric W. Biederman Oct. 18, 2021, 5:21 p.m. UTC
While digging into the previous ucount kernel crashes I found some minor
bugs in the ucount code.  When hit these bugs all result in a ucount
either being counted in the wrong location or leak of a struct ucounts.

Nothing particularly serious but certainly things that should be fixed.

Eric W. Biederman (3):
      ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds
      ucounts: Proper error handling in set_cred_ucounts
      ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring

 kernel/cred.c                | 9 ++++-----
 security/keys/process_keys.c | 8 ++++++++
 2 files changed, 12 insertions(+), 5 deletions(-)

Eric

Comments

Yu Zhao Oct. 18, 2021, 10:28 p.m. UTC | #1
On Mon, Oct 18, 2021 at 11:21 AM Eric W. Biederman
<ebiederm@xmission.com> wrote:
>
>
> While digging into the previous ucount kernel crashes I found some minor
> bugs in the ucount code.  When hit these bugs all result in a ucount
> either being counted in the wrong location or leak of a struct ucounts.
>
> Nothing particularly serious but certainly things that should be fixed.
>
> Eric W. Biederman (3):
>       ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds
>       ucounts: Proper error handling in set_cred_ucounts
>       ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring
>
>  kernel/cred.c                | 9 ++++-----
>  security/keys/process_keys.c | 8 ++++++++
>  2 files changed, 12 insertions(+), 5 deletions(-)

Thanks for the fixes. Tested the whole series on the latest 5.15-rc6.

Tested-by: Yu Zhao <yuzhao@google.com>