From patchwork Fri Oct 2 01:23:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn X-Patchwork-Id: 11812809 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB838139A for ; Fri, 2 Oct 2020 01:24:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BB7E208C7 for ; Fri, 2 Oct 2020 01:24:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="phnG+o1k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BB7E208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A298A6B007D; Thu, 1 Oct 2020 21:24:01 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9D9266B007E; Thu, 1 Oct 2020 21:24:01 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A20A8E0001; Thu, 1 Oct 2020 21:24:01 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 5E48B6B007D for ; Thu, 1 Oct 2020 21:24:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E626C180AD801 for ; Fri, 2 Oct 2020 01:24:00 +0000 (UTC) X-FDA: 77325239040.02.wrist10_2615370271a0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id C77C8100C0CD8 for ; Fri, 2 Oct 2020 01:24:00 +0000 (UTC) X-Spam-Summary: 10,1,0,e1201a277e592d81,d41d8cd98f00b204,jannh@google.com,,RULES_HIT:41:69:152:355:379:541:967:973:988:989:1260:1277:1313:1314:1345:1437:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2198:2199:2393:2525:2559:2563:2682:2685:2731:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3152:3352:3865:3866:3867:3868:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:6261:6653:6742:7901:7903:8957:9025:10004:10400:11026:11658:11914:12043:12266:12297:12438:12519:12555:12679:12683:12698:12737:12895:12986:13069:13161:13229:13311:13357:13870:14093:14096:14097:14181:14394:14581:14659:14721:14777:21080:21365:21433:21444:21451:21627:21740:21889:30003:30054:30070,0,RBL:209.85.218.65:@google.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04ygfrhwosx6uy4agomc8yee7hmzqyc3adh4kw8ecot1d747xuo1dmpqfu59j58.y6xdrw5hdpyge165jqqmxa17sjsnm5mzp8n1ifcwzo5kzz3t9g68pc5a4hhd7rn.w-lbl8.mailshell.net-223.238.255.100,Cache IP:none, X-HE-Tag: wrist10_2615370271a0 X-Filterd-Recvd-Size: 4743 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 01:24:00 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id u21so575565eja.2 for ; Thu, 01 Oct 2020 18:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:date:message-id:subject:to:cc; bh=ZuhbLiKiM/JcAkw5V2qrfXh3m4GeTtm0DV+AllcZcTo=; b=phnG+o1kyRsRwF9i0GexiGaNbZOP24P5O4ULQ5ExpA//VqilVb567sh0HefGxeA8xg nMG3wUlLYwDwz4ju0m6VjavsnNxCh5MJxDO+LJyeqWjOILRr8M1KBstrnZUQ1H7jEgaG V7tVvRw8Fx6gNANGF4V4dkqKva+5oIleHhh3HEfSVIeDZjy9uS09Ntv7j0ce+RhBTF1Q uNwPxns7ceb7L4mDxU8VbGuG7YWdhfiiSKigxqQF5GocQsOaAujd0SYo9X38CLWdA9V6 2OGNFwDeurCJMAYhq9WaWDC678AEwJyWPQELa8jAOn4Wl6+AxVScu4594E9io4FCn4g1 4itA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to:cc; bh=ZuhbLiKiM/JcAkw5V2qrfXh3m4GeTtm0DV+AllcZcTo=; b=L4rqJGObuhtg/zjDQbfgvxt/RSqKSroYj5T2K37Ula+pKo941oJPAPuro7yRSVSBFL W4qZIgr2A9PNLW3wdRTzfgD9F1t0btUciVOk97nzs1QOoLCYWRGEHdYCrpjq3PSKsXQe 8uKx3s+YP5lQ7kDgqpSyW9wnyQooziLtrtDvND8kHw6kKVBjgTK7vIXoImchta4RLyMN OCYKM8iDXgyWlAevAQH+gAtihpdkZNlJtRx6a6vow106AHewxXk3++4I8fGsNjKaPT4a QbZ30v8Tne5ek62lpptAlV7qpaIJ9nqXtruvpe3jHZyCwdIrwsXkaZUropdZRlRa+QBE C8Pw== X-Gm-Message-State: AOAM530/g7vsFzMiEYeaSKkDYEAGNShmYHZZqI36xS6ny7Luahzw/C27 Z58DAg1f2aB05VhRM1T9ZVGRBz3Uzji8somqK6VVuw== X-Google-Smtp-Source: ABdhPJw5ERWukkY+5ZDguQiFbaiYeqNOoiZ2ZEg/InHvYl6Vbjj5rB8NrevRCvjERC75sEP74nGnWjbbHtYkIX1mGeo= X-Received: by 2002:a17:906:33c8:: with SMTP id w8mr6469076eja.233.1601601838935; Thu, 01 Oct 2020 18:23:58 -0700 (PDT) Received: from 913411032810 named unknown by gmailapi.google.com with HTTPREST; Thu, 1 Oct 2020 21:23:58 -0400 From: Jann Horn X-Mailer: git-send-email 2.28.0.806.g8561365e88-goog MIME-Version: 1.0 Date: Thu, 1 Oct 2020 21:23:58 -0400 Message-ID: Subject: [PATCH 0/2] Broad write-locking of nascent mm in execve To: Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Eric W . Biederman" , Michel Lespinasse , Mauro Carvalho Chehab , Sakari Ailus , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Jason Gunthorpe , John Hubbard X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: These two patches replace "mmap locking API: don't check locking if the mm isn't live yet"[1], which is currently in the mmotm tree, and should be placed in the same spot where the old patch was. While I originally said that this would be an alternative patch (meaning that the existing patch would have worked just as well), the new patches actually address an additional issue that the old patch missed (bprm->vma is used after the switch to the new mm). I have boot-tested these patches on x64-64 (with lockdep) and !MMU arm (the latter with both FLAT and ELF). [1] https://lkml.kernel.org/r/CAG48ez03YJG9JU_6tGiMcaVjuTyRE_o4LEQ7901b5ZoCnNAjcg@mail.gmail.com Jann Horn (2): mmap locking API: Order lock of nascent mm outside lock of live mm exec: Broadly lock nascent mm until setup_arg_pages() arch/um/include/asm/mmu_context.h | 3 +- fs/exec.c | 64 ++++++++++++++++--------------- include/linux/binfmts.h | 2 +- include/linux/mmap_lock.h | 23 ++++++++++- kernel/fork.c | 7 +--- 5 files changed, 59 insertions(+), 40 deletions(-) base-commit: fb0155a09b0224a7147cb07a4ce6034c8d29667f prerequisite-patch-id: 08f97130a51898a5f6efddeeb5b42638577398c7 prerequisite-patch-id: 577664d761cd23fe9031ffdb1d3c9ac313572c67 prerequisite-patch-id: dc29a39716aa8689f80ba2767803d9df3709beaa prerequisite-patch-id: 42b1b546d33391ead2753621f541bcc408af1769 prerequisite-patch-id: 2cbb839f57006f32e21f4229e099ae1bd782be24 prerequisite-patch-id: 1b4daf01cf61654a5ec54b5c3f7c7508be7244ee prerequisite-patch-id: f46cc8c99f1909fe2a65fbc3cf1f6bc57489a086 prerequisite-patch-id: 2b0caed97223241d5008898dde995d02fda544e4 prerequisite-patch-id: 6b7adcb54989e1ec3370f256ff2c35d19cf785aa