[0/5] mm: fixes to past from future testing

Message

Hugh Dickins Aug. 30, 2020, 8:57 p.m. UTC

Here's a set of independent fixes against 5.9-rc2: prompted by
testing Alex Shi's "warning on !memcg" and lru_lock series, but
I think fit for 5.9 - though maybe only the first for stable.

[PATCH 1/5] ksm: reinstate memcg charge on copied pages
[PATCH 2/5] mm: migration of hugetlbfs page skip memcg
[PATCH 3/5] shmem: shmem_writepage() split unlikely i915 THP
[PATCH 4/5] mm: fix check_move_unevictable_pages() on THP
[PATCH 5/5] mlock: fix unevictable_pgs event counts on THP

 mm/ksm.c     |    4 ++++
 mm/migrate.c |    3 ++-
 mm/mlock.c   |   24 +++++++++++++++---------
 mm/shmem.c   |   10 +++++++++-
 mm/swap.c    |    6 +++---
 mm/vmscan.c  |   10 ++++++++--
 6 files changed, 41 insertions(+), 16 deletions(-)

Comments

Alex Shi Sept. 1, 2020, 2:28 a.m. UTC | #1

在 2020/8/31 上午4:57, Hugh Dickins 写道:
> Here's a set of independent fixes against 5.9-rc2: prompted by
> testing Alex Shi's "warning on !memcg" and lru_lock series, but
> I think fit for 5.9 - though maybe only the first for stable.
> 
> [PATCH 1/5] ksm: reinstate memcg charge on copied pages
> [PATCH 2/5] mm: migration of hugetlbfs page skip memcg
> [PATCH 3/5] shmem: shmem_writepage() split unlikely i915 THP
> [PATCH 4/5] mm: fix check_move_unevictable_pages() on THP
> [PATCH 5/5] mlock: fix unevictable_pgs event counts on THP

Hi Hugh,

Thanks a lot for reporting and fix! All fixed looks fine for me.

BTW,
I assume you already rebased lru_lock patchset on this. So I don't 
need to redo rebase again, do I? :)

Thanks
Alex

> 
>  mm/ksm.c     |    4 ++++
>  mm/migrate.c |    3 ++-
>  mm/mlock.c   |   24 +++++++++++++++---------
>  mm/shmem.c   |   10 +++++++++-
>  mm/swap.c    |    6 +++---
>  mm/vmscan.c  |   10 ++++++++--
>  6 files changed, 41 insertions(+), 16 deletions(-)
>

Hugh Dickins Sept. 1, 2020, 4:08 a.m. UTC | #2

On Tue, 1 Sep 2020, Alex Shi wrote:
> 在 2020/8/31 上午4:57, Hugh Dickins 写道:
> > Here's a set of independent fixes against 5.9-rc2: prompted by
> > testing Alex Shi's "warning on !memcg" and lru_lock series, but
> > I think fit for 5.9 - though maybe only the first for stable.
> > 
> > [PATCH 1/5] ksm: reinstate memcg charge on copied pages
> > [PATCH 2/5] mm: migration of hugetlbfs page skip memcg
> > [PATCH 3/5] shmem: shmem_writepage() split unlikely i915 THP
> > [PATCH 4/5] mm: fix check_move_unevictable_pages() on THP
> > [PATCH 5/5] mlock: fix unevictable_pgs event counts on THP
> 
> Hi Hugh,
> 
> Thanks a lot for reporting and fix! All fixed looks fine for me.

Thanks for checking.

> 
> BTW,
> I assume you already rebased lru_lock patchset on this. So I don't 
> need to redo rebase again, do I? :)

That's right, no need for another posting: the only ones of yours
which don't apply cleanly on top of mine are 20/32 and 21/32,
touching check_move_unevictable_pages(); and they're easy enough
to resolve.

With my 5 fixes in, I'll advance to commenting on yours (but not today).

Hugh