From patchwork Mon May 1 23:11:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Stoakes X-Patchwork-Id: 13229118 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3A3C77B7E for ; Tue, 2 May 2023 15:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 152096B0071; Tue, 2 May 2023 11:57:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12A176B0074; Tue, 2 May 2023 11:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F34956B0075; Tue, 2 May 2023 11:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by kanga.kvack.org (Postfix) with ESMTP id A20D86B0071 for ; Tue, 2 May 2023 11:57:14 -0400 (EDT) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-50bd875398dso638121a12.1 for ; Tue, 02 May 2023 08:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683043034; x=1685635034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dH0PVRqeh1hbjfzzn3FtIhyE9VI9lTkG4LXY49ABXmY=; b=jAkg2fvIocoObXAzH6b9GaHAjSOpFrmh7tdNXyfzPG3kqd5YTDlWXjUoOxzOFllOKT mGusTVxR/GEEm/Hrw9U6nIN5NhAfS0QvHHaQC5H1+H1mL3dCBT6gInjC9SO/e1G+juU3 bFTxFBKhboRwtIqkUAl2RK1/FiaHtqJTjbWu8vCJmC3sk1aKZhiqA7uywJ3HOP41lu1f c9rN3bYMnurwNnHZAtP2yzdycMfkYuIKwVFFwZ8FFF1avPPBV+xs0z3nxCPIqxUomkbM yBAUXp3ArSth0h85hfaXX5pB+oueG9WpFTfqriYb/JPXck+CLAIxq8EHO1qwtUTxkDjr 5O6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043034; x=1685635034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dH0PVRqeh1hbjfzzn3FtIhyE9VI9lTkG4LXY49ABXmY=; b=Ncs1fqbEqHa5NRLxwq8ut9uKNvCSk0Twe+TP59YzuviiknC2lFuzLNfozQZW5bZ7se ca8WyeODXqLTgu3Vz6K161JMX9GOESeBQoibtBW6Oo1SCmL/BvuYSZzx/pGFSsLFn2JO 21OQh+V9nJrWui/LkronCVCEBd8pHax2oS9GAVT2ARtySTkpH96Dk1qd7f9skPTtCl8T xU1evCGpoPZBA5+Z4npAJneicD5iGG2/ekMcTZOD+V8CmEWMfG/e6RnQbvxqVI4pPhxz HOzoi8qQkveaIOWdgQ9Iu9HeVH+aIT4Xr3ocPDhBOJbHX1QzccZs7HPLPorBucdyhCc5 BulA== X-Gm-Message-State: AC+VfDxcaadNw5jdUaeieSaJtFni+8BaNh1Y6bymn5aTnjXXFsSyenri fUCp2fbjgyUoR2NTMljVpJmVaa7lPlcdkQ== X-Google-Smtp-Source: ACHHUZ4B+CYvDYGtDHGkYMOJFrOq8n7poWlJLL09a9R99dns+0+E4k2Wr5n2KBxrwUijlxnB+zLwbw== X-Received: by 2002:a05:600c:2046:b0:3f1:9503:4db0 with SMTP id p6-20020a05600c204600b003f195034db0mr10552021wmg.13.1682982838155; Mon, 01 May 2023 16:13:58 -0700 (PDT) Received: from lucifer.home (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.googlemail.com with ESMTPSA id v9-20020a05600c444900b003f173be2ccfsm48948904wmn.2.2023.05.01.16.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 16:13:57 -0700 (PDT) From: Lorenzo Stoakes To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Jason Gunthorpe , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , Jason Gunthorpe , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , David Hildenbrand , Dave Chinner , Theodore Ts'o , Peter Xu , Lorenzo Stoakes Subject: [PATCH v6 0/3] mm/gup: disallow GUP writing to file-backed mappings by default Date: Tue, 2 May 2023 00:11:46 +0100 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Writing to file-backed mappings which require folio dirty tracking using GUP is a fundamentally broken operation, as kernel write access to GUP mappings do not adhere to the semantics expected by a file system. A GUP caller uses the direct mapping to access the folio, which does not cause write notify to trigger, nor does it enforce that the caller marks the folio dirty. The problem arises when, after an initial write to the folio, writeback results in the folio being cleaned and then the caller, via the GUP interface, writes to the folio again. As a result of the use of this secondary, direct, mapping to the folio no write notify will occur, and if the caller does mark the folio dirty, this will be done so unexpectedly. For example, consider the following scenario:- 1. A folio is written to via GUP which write-faults the memory, notifying the file system and dirtying the folio. 2. Later, writeback is triggered, resulting in the folio being cleaned and the PTE being marked read-only. 3. The GUP caller writes to the folio, as it is mapped read/write via the direct mapping. 4. The GUP caller, now done with the page, unpins it and sets it dirty (though it does not have to). This change updates both the PUP FOLL_LONGTERM slow and fast APIs. As pin_user_pages_fast_only() does not exist, we can rely on a slightly imperfect whitelisting in the PUP-fast case and fall back to the slow case should this fail. v6: - Rebased on latest mm-unstable as of 28th April 2023. - Add PUP-fast check with handling for rcu-locked TLB shootdown to synchronise correctly. - Split patch series into 3 to make it more digestible. v5: - Rebased on latest mm-unstable as of 25th April 2023. - Some small refactorings suggested by John. - Added an extended description of the problem in the comment around writeable_file_mapping_allowed() for clarity. - Updated commit message as suggested by Mika and John. https://lore.kernel.org/all/6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com/ v4: - Split out vma_needs_dirty_tracking() from vma_wants_writenotify() to reduce duplication and update to use this in the GUP check. Note that both separately check vm_ops_needs_writenotify() as the latter needs to test this before the vm_pgprot_modify() test, resulting in vma_wants_writenotify() checking this twice, however it is such a small check this should not be egregious. https://lore.kernel.org/all/3b92d56f55671a0389252379237703df6e86ea48.1682464032.git.lstoakes@gmail.com/ v3: - Rebased on latest mm-unstable as of 24th April 2023. - Explicitly check whether file system requires folio dirtying. Note that vma_wants_writenotify() could not be used directly as it is very much focused on determining if the PTE r/w should be set (e.g. assuming private mapping does not require it as already set, soft dirty considerations). - Tested code against shmem and hugetlb mappings - confirmed that these are not disallowed by the check. - Eliminate FOLL_ALLOW_BROKEN_FILE_MAPPING flag and instead perform check only for FOLL_LONGTERM pins. - As a result, limit check to internal GUP code. https://lore.kernel.org/all/23c19e27ef0745f6d3125976e047ee0da62569d4.1682406295.git.lstoakes@gmail.com/ v2: - Add accidentally excluded ptrace_access_vm() use of FOLL_ALLOW_BROKEN_FILE_MAPPING. - Tweak commit message. https://lore.kernel.org/all/c8ee7e02d3d4f50bb3e40855c53bda39eec85b7d.1682321768.git.lstoakes@gmail.com/ v1: https://lore.kernel.org/all/f86dc089b460c80805e321747b0898fd1efe93d7.1682168199.git.lstoakes@gmail.com/ Lorenzo Stoakes (3): mm/mmap: separate writenotify and dirty tracking logic mm/gup: disallow FOLL_LONGTERM GUP-nonfast writing to file-backed mappings mm/gup: disallow FOLL_LONGTERM GUP-fast writing to file-backed mappings include/linux/mm.h | 1 + mm/gup.c | 128 +++++++++++++++++++++++++++++++++++++++++++-- mm/mmap.c | 36 +++++++++---- 3 files changed, 153 insertions(+), 12 deletions(-) --- 2.40.1