From patchwork Tue Apr 8 16:07:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Gordeev X-Patchwork-Id: 14043320 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 033F4C369A2 for ; Tue, 8 Apr 2025 16:07:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8F34280009; Tue, 8 Apr 2025 12:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A61DD280008; Tue, 8 Apr 2025 12:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CCF5280009; Tue, 8 Apr 2025 12:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 54D0D280005 for ; Tue, 8 Apr 2025 12:07:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5888EBB11F for ; Tue, 8 Apr 2025 16:07:42 +0000 (UTC) X-FDA: 83311357164.04.CE395B8 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf11.hostedemail.com (Postfix) with ESMTP id 3297D40004 for ; Tue, 8 Apr 2025 16:07:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=KuN6IiHD; spf=pass (imf11.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744128459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Hyqi0uOKVD2qmF0HO2gDnCnMoE/ESURqT+ROeR8reIU=; b=pK/40w9h6p9heEJ6yXchaGSFaPibYCn4lWn1Pr9xsJuqfq/zghGrhjMu/EeiGi5ck2FPzx DEAxS9EJwsJCXZ/y2HJTeOflNG9E92NU3gauhEx1WlVl7WbKHaFu6YGF0uJiDijTbOeJb4 k6K6UDUnHe9aerzmq5sEmHr5gocEozQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744128459; a=rsa-sha256; cv=none; b=iXSffG4Jh+X8upgv8uq1DrVtjMlqv4Ewga6StPZIc8JT1anDpklCIAY+VfI+tREyDTOGnT GzQxI83BdhtY1vu/a4elfd5skKluKHe24rOGqtETK/ff0VLg6w67FPiabPV/xM+xh/GkfJ GSqFGUf0Z3HTW1CKMYTA9qsQ+Grpre8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=KuN6IiHD; spf=pass (imf11.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 538CSaU4018465; Tue, 8 Apr 2025 16:07:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=Hyqi0uOKVD2qmF0HO2gDnCnMoE/ESURqT+ROeR8re IU=; b=KuN6IiHDb6O+3M2qjviXeFee8lBozmtNdEx1CjI6uW0ohXIYYZAPumrD7 wu4/+aq3OfN3pZkcbDZAbc1cRH+ZXwHqhsU50OV00UClUPe+SpUCVLvMa7fb+Ldh HHRCTuguhLRjuy8I2VLdRhEc5TS8LFBQb9aqoRjdCFsdiTTMumDO06NrLoqVTEYG 7DN+T/7x07zw2Lsb0x3AJqCUqXr8E3Sew+9sZRO0HjsWC1pOaQOh8ivdAtjKcney icxlVcBlkT4s+DK1PZYOsUH7Bc1Mp2n+z7qFGgMNWLBQ0thbHI8Znnckvyndwcvn DMHXvhSkSXCBhKQF5c74h+lBwBfaw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45w3u313v9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 16:07:36 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 538G39G0000730; Tue, 8 Apr 2025 16:07:36 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45w3u313v7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 16:07:36 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 538C4qov014404; Tue, 8 Apr 2025 16:07:34 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 45ufunkd22-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 16:07:34 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 538G7Wah49873200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Apr 2025 16:07:32 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AD6F220043; Tue, 8 Apr 2025 16:07:32 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 987D020040; Tue, 8 Apr 2025 16:07:32 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 8 Apr 2025 16:07:32 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id 49B74E0628; Tue, 08 Apr 2025 18:07:32 +0200 (CEST) From: Alexander Gordeev To: Andrew Morton , Andrey Ryabinin Cc: Hugh Dickins , Nicholas Piggin , Guenter Roeck , Juergen Gross , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 0/3] mm: Fix apply_to_pte_range() vs lazy MMU mode Date: Tue, 8 Apr 2025 18:07:29 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: zTdW0kqTRTiT22s8uhfmBPaUntY3pzCH X-Proofpoint-ORIG-GUID: rmIK76a9Z49Qa5aFKSDqoZ2VuPaoExus X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-08_06,2025-04-08_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=635 bulkscore=0 clxscore=1015 malwarescore=0 mlxscore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504080110 X-Stat-Signature: 4a3dgs5jgr16sg9owwpzu6c1qkai7f43 X-Rspam-User: X-Rspamd-Queue-Id: 3297D40004 X-Rspamd-Server: rspam08 X-HE-Tag: 1744128458-858247 X-HE-Meta: U2FsdGVkX1+et6RW8+D/IHax0wPhXUTPXlTHTdmCQvOer5Vj8KiNSJ/5YUQ+dj1clEhy2c2hbyPK1QG53IvqZDNcJZp9d5QpdA5eiZ3h3vNxjr7mBpUruhHLqO/hyLp2kTlbWPVkbs05XXIKpOt3Z7mREEMfO298VE5PHN16fS4BuKuB5xhqVHG5khvQGm1I3drE/3/aoGxroV6eyeszc6vE81ovFAaM30B3ksLm1s0edTMt+UGp/Wqeo+UJXA97D7p8SkuE8MSYvxTDHP5yzYbfhLSQ6J5ItO87XTAkdbN9/2EN/SFBBz+xqlrju2m2QXoaR2aPn8nW90wzCCQyGQ4v/7FL2XH359BCJo0lJEcdspMhXwwAEJURJ3Ckm7zw/xMLE+VylcQhakBdRpQVvgKkLvz6oK0A6+ngjkUQ01ttzHjnKvwkm1IJVe1TwKgBjZECHtI0w9B5Z6PCnjNdK9df/9FVILaPUypVyMpG3lxBAER7NLhQrosghRcrNM3T8P8b8Zc5G9i2vmN4wr0MhNiC1qSYnnLi0JxitJkATVamQm8dSBZ13otHsDxaDGdyca2kZPczFv+1KpFsgDOMK0RMTjWMPDpEzBvCL/3iyOGKDHCV+8pDOOkUhjCveHtTn0I2G58VdceK+VtXd8ZVwXykhxuUj+POVII8/kPYAzwbd+uGnZndINMoWL4+FxnYTNf0t+vCWMj2iWUzyvyGldqx78RcER+7qnYFtsy1nOtVhiPy3IBzy+dEjP01jwd7IkfKSwmPvHsxAOGWgVaGaxVGyZve3D2K+I6AV1YgDv+Yr63IzXirojPS9GKP3dx1Fw7LIpB3laBPoplqMnF3Nu5n2uVaS7/g/u3+hm0F0Oy4JLkKXhBXXv1jzYU8zUU+7FAQvsG6BfQ7UF66XAud5rvy0JAikacOPuiO7+gQiYNj5bAigSW2QGjjMqrYnaZckP81kqdBUOcrXI9x39I DqPk4oJQ Sa5GzbXHtxohmfHCgCBo9SptcAJYBLVU6hGV4an+2przynTIAYwOOTbu6kYf/wzsfFosuf+JGHGvv9xBi7sRdZXU0ONjgLYvJ6Kt9fbyDgzC4v+TjVFEVJH1THHa0XRlwFrL03Xvrdu9d4yK2BBt/u+Rip/zXLBlFk++b4he2GmkKMq5bN5CPnC0O6wofHWLr/Lb5uRporac5FISVbtlzK2UdexSxC/Uba1db6qN1OuiBdcNbQzPqE7wuk9PvaqivlJOdj+MNrWt8+pY70OcIcFLOFk1CGu3Aa+fJJbkjtmYfxCk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi All, Chages since v1: - left fixes only, improvements will be posted separately; - Fixes: and -stable tags added to patch descriptions; This series is an attempt to fix the violation of lazy MMU mode context requirement as described for arch_enter_lazy_mmu_mode(): This mode can only be entered and left under the protection of the page table locks for all page tables which may be modified. On s390 if I make arch_enter_lazy_mmu_mode() -> preempt_enable() and arch_leave_lazy_mmu_mode() -> preempt_disable() I am getting this: [ 553.332108] preempt_count: 1, expected: 0 [ 553.332117] no locks held by multipathd/2116. [ 553.332128] CPU: 24 PID: 2116 Comm: multipathd Kdump: loaded Tainted: [ 553.332139] Hardware name: IBM 3931 A01 701 (LPAR) [ 553.332146] Call Trace: [ 553.332152] [<00000000158de23a>] dump_stack_lvl+0xfa/0x150 [ 553.332167] [<0000000013e10d12>] __might_resched+0x57a/0x5e8 [ 553.332178] [<00000000144eb6c2>] __alloc_pages+0x2ba/0x7c0 [ 553.332189] [<00000000144d5cdc>] __get_free_pages+0x2c/0x88 [ 553.332198] [<00000000145663f6>] kasan_populate_vmalloc_pte+0x4e/0x110 [ 553.332207] [<000000001447625c>] apply_to_pte_range+0x164/0x3c8 [ 553.332218] [<000000001448125a>] apply_to_pmd_range+0xda/0x318 [ 553.332226] [<000000001448181c>] __apply_to_page_range+0x384/0x768 [ 553.332233] [<0000000014481c28>] apply_to_page_range+0x28/0x38 [ 553.332241] [<00000000145665da>] kasan_populate_vmalloc+0x82/0x98 [ 553.332249] [<00000000144c88d0>] alloc_vmap_area+0x590/0x1c90 [ 553.332257] [<00000000144ca108>] __get_vm_area_node.constprop.0+0x138/0x260 [ 553.332265] [<00000000144d17fc>] __vmalloc_node_range+0x134/0x360 [ 553.332274] [<0000000013d5dbf2>] alloc_thread_stack_node+0x112/0x378 [ 553.332284] [<0000000013d62726>] dup_task_struct+0x66/0x430 [ 553.332293] [<0000000013d63962>] copy_process+0x432/0x4b80 [ 553.332302] [<0000000013d68300>] kernel_clone+0xf0/0x7d0 [ 553.332311] [<0000000013d68bd6>] __do_sys_clone+0xae/0xc8 [ 553.332400] [<0000000013d68dee>] __s390x_sys_clone+0xd6/0x118 [ 553.332410] [<0000000013c9d34c>] do_syscall+0x22c/0x328 [ 553.332419] [<00000000158e7366>] __do_syscall+0xce/0xf0 [ 553.332428] [<0000000015913260>] system_call+0x70/0x98 This exposes a KASAN issue fixed with patch 1 and apply_to_pte_range() issue fixed with patch 3, while patch 2 is a prerequisite. Commit b9ef323ea168 ("powerpc/64s: Disable preemption in hash lazy mmu mode") looks like powerpc-only fix, yet not entirely conforming to the above provided requirement (page tables itself are still not protected). If I am not mistaken, xen and sparc are alike. Thanks! Alexander Gordeev (3): kasan: Avoid sleepable page allocation from atomic context mm: Cleanup apply_to_pte_range() routine mm: Protect kernel pgtables in apply_to_pte_range() mm/kasan/shadow.c | 9 +++------ mm/memory.c | 33 +++++++++++++++++++++------------ 2 files changed, 24 insertions(+), 18 deletions(-)