From patchwork Tue Aug 4 12:41:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 11700347 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5DC4A722 for ; Tue, 4 Aug 2020 12:41:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32D01208C7 for ; Tue, 4 Aug 2020 12:41:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="e/emAKRK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32D01208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63B2E8D0157; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5EB388D0081; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528698D0157; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 40CFF8D0081 for ; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EC3BA1EE6 for ; Tue, 4 Aug 2020 12:41:38 +0000 (UTC) X-FDA: 77112847476.21.bikes68_550578726fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 2FECB180442C2 for ; Tue, 4 Aug 2020 12:41:38 +0000 (UTC) X-Spam-Summary: 1,0,0,64002509632aeb10,d41d8cd98f00b204,3f1cpxwokcniyb1f2m8bj94cc492.0ca96bil-aa8jy08.cf4@flex--andreyknvl.bounces.google.com,,RULES_HIT:41:152:355:379:541:800:960:973:988:989:1042:1260:1277:1313:1314:1345:1359:1431:1437:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2689:3138:3139:3140:3141:3142:3152:3352:3865:3866:3867:3868:3871:4250:4321:5007:6261:6653:6742:7903:9969:10004:10400:11026:11473:11658:11914:12043:12296:12297:12438:12555:12895:13069:13311:13357:13972:14096:14097:14181:14394:14659:14721:14877:21080:21444:21451:21627:21772:21990:30054:30055,0,RBL:209.85.221.73:@flex--andreyknvl.bounces.google.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04y8zffjynbcsadashdnj13cse4khoptn8z6wxrpyje7kuxau3kqgh5xzzqhjrt.ugyatqhx8hnuzg8n33n5zo9qsqpzn8b69dhy1e6h9t4eewzygmdmihr7y4u6ex4.4-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rul es:0:0:0 X-HE-Tag: bikes68_550578726fa6 X-Filterd-Recvd-Size: 4390 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:41:37 +0000 (UTC) Received: by mail-wr1-f73.google.com with SMTP id f14so12523852wrm.22 for ; Tue, 04 Aug 2020 05:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=FcKp4QRyFHBBCVHpXykl5mFo5C8EtuBz90+P1+03xoY=; b=e/emAKRKbJkdBeq2q9WKmzagPJvb8gdtqflMVkfA9U+GObzCW9ZK8iDv+fm06/lNOH ajIRbU5BrRbTrBBREu3uaJou2xzNyaOCp+XZbidInFpetFzQFW1x8pTzoRCyj341z+Lk wq4m5lWgeLtpP7STH34Cb53cG+ae0e77L4MzJmeQ/HMqzyEcxWEcW0LZlOw/BlZk7uoa dO5RcM67ErBDoGmZ9vvLhQ54jnpx36h7CmzrXwZGP0KVeFdh2JE5X6xOlJdqsCGf3JGH qx57794JnfkOQH/j1i6yWfIbZmc2qfK2k0FRmQtkn8Nc1oWCF+4s0O93QqCimgEugC/p C7cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=FcKp4QRyFHBBCVHpXykl5mFo5C8EtuBz90+P1+03xoY=; b=LI4pCD5h9fyvR+NPfknob4dHrMSJBDldG1vf0MOhtYIoVBbi+CYT70I+YP8ESb5GxG lAYXdn6qbtuS2qZuwmHFtULnTbQeBc/aeTQVzroCUyrJuEthu5UfLkDSVyopNWpdDH+p 3GxVnmpNYkELpIg+wp+B0bTyvQsKPFjQ/32+2vW+HisbdzUu+w+e+yoYM0G2syS3ykwT ml6IPAEFHveLXsOvJ0g2hfCpn+wUNtyiiQiykj1UsnW5GNZcJo1kVzOh9vyC7O2FEP3m p8w/prayITlvja60ZAGAehjPBXxONVEIZi5S7hi8ZaNERJGDntwnxDlEQxKI5bVmNgmu VljQ== X-Gm-Message-State: AOAM533f1TnLZKw88hJ9Uuh6PJntPacIEb88lV+QDOG4zLiZ3pauVqXQ tMVCxbWngP98cTW+rQOGB+eP4kkvWI4/UlGT X-Google-Smtp-Source: ABdhPJysUQ4oDqsJhy6xq9sHQOykVWtKsRJrE3eJ3umL4PptPqQvdYk0j95C1HF2RsOBJ7cfXSW95HsjwlUjMNSy X-Received: by 2002:a1c:b443:: with SMTP id d64mr4329306wmf.68.1596544895842; Tue, 04 Aug 2020 05:41:35 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:24 +0200 In-Reply-To: Message-Id: <12d8c678869268dd0884b01271ab592f30792abf.1596544734.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH v2 1/5] kasan: don't tag stacks allocated with pagealloc From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov X-Rspamd-Queue-Id: 2FECB180442C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch prepares Software Tag-Based KASAN for stack tagging support. With Tag-Based KASAN when kernel stacks are allocated via pagealloc (which happens when CONFIG_VMAP_STACK is not enabled), they get tagged. KASAN instrumentation doesn't expect the sp register to be tagged, and this leads to false-positive reports. Fix by resetting the tag of kernel stack pointers after allocation. Signed-off-by: Andrey Konovalov --- kernel/fork.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/fork.c b/kernel/fork.c index efc5493203ae..75415f5e647c 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -261,7 +261,7 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, int node) THREAD_SIZE_ORDER); if (likely(page)) { - tsk->stack = page_address(page); + tsk->stack = kasan_reset_tag(page_address(page)); return tsk->stack; } return NULL; @@ -307,6 +307,7 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, { unsigned long *stack; stack = kmem_cache_alloc_node(thread_stack_cache, THREADINFO_GFP, node); + stack = kasan_reset_tag(stack); tsk->stack = stack; return stack; }