From patchwork Thu May 17 06:11:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia He X-Patchwork-Id: 10405453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD23060230 for ; Thu, 17 May 2018 06:12:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAF992893D for ; Thu, 17 May 2018 06:12:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF5EC2894D; Thu, 17 May 2018 06:12:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F3CD2893D for ; Thu, 17 May 2018 06:12:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61E5D6B038F; Thu, 17 May 2018 02:12:08 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5A7376B0391; Thu, 17 May 2018 02:12:08 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 447BE6B0392; Thu, 17 May 2018 02:12:08 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id 008136B038F for ; Thu, 17 May 2018 02:12:08 -0400 (EDT) Received: by mail-pg0-f70.google.com with SMTP id b3-v6so1357042pga.6 for ; Wed, 16 May 2018 23:12:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=2ttoIVXM8TkHqBEpLAARFltoK0zBFnJ8nbbGbwQwzlE=; b=fJpVq6GCJIKWHbI0d2rLN89w7XSCQlG+3MscYzaC5QYkuqGcOvX4B8riP5G2ytD7Mk Q/0FB4CkD5dsq+PR4HJGqjNrJFQtCn9NCrg+ry8eKK6wRFUblvbitfKVtTmtVkZgDG1H vxLv4ssUD7vBa10jpdKpa8Azfg+/URVsp7zrZWtp5txYy/8H0U1Un6GMt4YnEuSTxP12 K+hf9xtbNw3+5vM/C0mCjU3RWnwhAxXkRg3r7JFbYciIeLCld02oC8oPQb4teNYXcNLb cm5GZUsquDx/YNVuJ8DZPxsvnAXIiCPgf7yVFbnYnLqd5iWAXQ8lwpYcBZ2xCCUoL8QY Icgg== X-Gm-Message-State: ALKqPwc0ftF/rTER/Vznd66vwzlk+T0x19A+BuP2Kj0iIDdoGuuiuXDc 9wUm0VjxSYkxLf4l9UM4Zwt4muTkAdkoKXGz80nR1kCPb8AJdE+gfGapFlVVDJ/WPKITgENzv1P qnCMNFlHVgI8VHo5/vvulpuZK31ylyHEYQzNiaxZZ2jZ3HLaxz6SvIQTk4uYppgzQGl3A8zB16w DVtkCpa/oe9mh5AsmPoEZWkImwF5tkQTJP4OmysIe1hZf2JK/3R6904wuCd6TRMLZMCwtjbSKxx +ld3VkF3xPb6H+Cx7C9F4P6pjyWnBGp/iKIXKHocQ4aQYK5I5+KO2t/iGsqIAxdl69AxtciLg5f 3hOSc2B2ylIOATlIT+trO7NURPStytJtlDF0oLwn8E/zOzqUPqHvVNzRRGllij/LWleD+6vcBpm a X-Received: by 2002:a17:902:8ec4:: with SMTP id x4-v6mr3910892plo.370.1526537527681; Wed, 16 May 2018 23:12:07 -0700 (PDT) X-Received: by 2002:a17:902:8ec4:: with SMTP id x4-v6mr3910855plo.370.1526537526975; Wed, 16 May 2018 23:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526537526; cv=none; d=google.com; s=arc-20160816; b=q4fK/eQG6mc/lnV2/xKGTD93+AOwCmDR42ATsqJ19Datow6g6+V3cr0BgOMXWE6x2j RqjN9QGACQSuwORLSiMF0Fgma1VHMkP/GGIT3Mpw4U3ppBhBlNXe+kNprVObJhFgtGoT aj1owyauZj8T05uNGHw+TlrVpR/72o+SeZrwRYqTAFKwjqmRwRvVFhCp6WEsvPaaBOiF muv/9GItny0Fh175WOBXWOgJhLs6eSvWcE02rJcuYT+Vw9NNq0XDjnI2kaw2/t0beu6/ gZ51vAVBPl0J/YLuzngGJeaIYB06h55Sdnfe/m2gJLVDvY/rAT+KJQWd4oUiAUxt3ivj CRxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=2ttoIVXM8TkHqBEpLAARFltoK0zBFnJ8nbbGbwQwzlE=; b=tNLzwk5S1k6ahcc4GLc7bksHKjuMCGjjG9bb70rrYAsaw3p6hc5KSCYU32PpZL9Ge1 bE7m0pBqfqpovA3kWIEcFUEeO5O9wt1agzprHkoXLwcBX60BSMhGu37p1pUSIoRjN1P4 3lRX8Rb6gHWpFcsxLV3GHs+ZCF7DvcukrgDydyA2QyZGdOx4QLN+o5dXdQU8U/O4JT3u 3sT01ICg0MVMtoaKHEmLIuB3m8yf3igWkuRr/QyBPZ2B+l3xvhvAT48W05+6ohxIIiQZ Y0nWQBjKmWDWuRdFeQr6jjiQo9ix2iLW4dxmedswtUpihKMibdnWZa+XPbSXYcrNPfzy lmAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DpDexOmO; spf=pass (google.com: domain of hejianet@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=hejianet@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u17-v6sor3067010plj.121.2018.05.16.23.12.06 for (Google Transport Security); Wed, 16 May 2018 23:12:06 -0700 (PDT) Received-SPF: pass (google.com: domain of hejianet@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DpDexOmO; spf=pass (google.com: domain of hejianet@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=hejianet@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2ttoIVXM8TkHqBEpLAARFltoK0zBFnJ8nbbGbwQwzlE=; b=DpDexOmORNQUEl4mpnjemsXP6tGX4m4POgti+HmUsZsuKkdQ7/taLQe57oCvdWokf7 Y1IrBeLryM4ndCEcKDbNBuRUd5cKEAqu3RHpGWmK/01oIoaWlJhEuEIfuXeePc3FpBYb gVyIsb+lbwfM09ANpgNXQCB4NQEul52bSuD/95SWM+H7acoLIB0gqVxeOeB7dw6Mn2ay 4zJji09pXslYyutMeF6b/IssTcQHo9DPDAaN8fga38uiKZB5AiK73r7OTPlCEZrWlhhD 1qEVgF2Pj4ek7U2gRvVTZJLMHAO+P6Lu8XZFM181mD/neiyk0PPeZhH+zp2PH31xGmKL q4dQ== X-Google-Smtp-Source: AB8JxZp/OdD4l5Zmj7HSx857AaDz6kz9JT2KO9OjBU0XGnPqcWiT8pnlF3gESyn6DNwFkqvrY9/BSw== X-Received: by 2002:a17:902:2826:: with SMTP id e35-v6mr3968498plb.348.1526537526658; Wed, 16 May 2018 23:12:06 -0700 (PDT) Received: from ct7host.localdomain ([38.106.11.25]) by smtp.gmail.com with ESMTPSA id d72-v6sm8309351pfe.150.2018.05.16.23.11.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 May 2018 23:12:05 -0700 (PDT) From: Jia He To: Christoffer Dall , Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: Suzuki K Poulose , Andrew Morton , Andrea Arcangeli , Claudio Imbrenda , Arvind Yadav , "David S. Miller" , Minchan Kim , Mike Rapoport , Hugh Dickins , "Paul E. McKenney" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jia He , jia.he@hxt-semitech.com Subject: [PATCH] KVM: arm/arm64: add WARN_ON if size is not PAGE_SIZE aligned in unmap_stage2_range Date: Thu, 17 May 2018 14:11:27 +0800 Message-Id: <1526537487-14804-1-git-send-email-hejianet@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP I ever met a panic under memory pressure tests(start 20 guests and run memhog in the host). ---------------------------------begin-------------------------------- [35380.800950] BUG: Bad page state in process qemu-kvm pfn:dd0b6 [35380.805825] page:ffff7fe003742d80 count:-4871 mapcount:-2126053375 mapping: (null) index:0x0 [35380.815024] flags: 0x1fffc00000000000() [35380.818845] raw: 1fffc00000000000 0000000000000000 0000000000000000 ffffecf981470000 [35380.826569] raw: dead000000000100 dead000000000200 ffff8017c001c000 0000000000000000 [35380.805825] page:ffff7fe003742d80 count:-4871 mapcount:-2126053375 mapping: (null) index:0x0 [35380.815024] flags: 0x1fffc00000000000() [35380.818845] raw: 1fffc00000000000 0000000000000000 0000000000000000 ffffecf981470000 [35380.826569] raw: dead000000000100 dead000000000200 ffff8017c001c000 0000000000000000 [35380.834294] page dumped because: nonzero _refcount [35380.839069] Modules linked in: vhost_net vhost tap ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter fcoe libfcoe libfc 8021q garp mrp stp llc scsi_transport_fc openvswitch nf_conntrack_ipv6 nf_nat_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_defrag_ipv6 nf_nat nf_conntrack vfat fat rpcrdma ib_isert iscsi_target_mod ib_iser libiscsi scsi_transport_iscsi ib_srpt target_core_mod ib_srp scsi_transport_srp ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm mlx5_ib ib_core crc32_ce ipmi_ssif tpm_tis tpm_tis_core sg nfsd auth_rpcgss nfs_acl lockd grace sunrpc dm_multipath ip_tables xfs libcrc32c mlx5_core mlxfw devlink ahci_platform libahci_platform libahci qcom_emac sdhci_acpi sdhci hdma mmc_core hdma_mgmt i2c_qup dm_mirror dm_region_hash dm_log dm_mod [35380.908341] CPU: 29 PID: 18323 Comm: qemu-kvm Tainted: G W 4.14.15-5.hxt.aarch64 #1 [35380.917107] Hardware name: [35380.930909] Call trace: [35380.933345] [] dump_backtrace+0x0/0x22c [35380.938723] [] show_stack+0x24/0x2c [35380.943759] [] dump_stack+0x8c/0xb0 [35380.948794] [] bad_page+0xf4/0x154 [35380.953740] [] free_pages_check_bad+0x90/0x9c [35380.959642] [] free_pcppages_bulk+0x464/0x518 [35380.965545] [] free_hot_cold_page+0x22c/0x300 [35380.971448] [] __put_page+0x54/0x60 [35380.976484] [] unmap_stage2_range+0x170/0x2b4 [35380.982385] [] kvm_unmap_hva_handler+0x30/0x40 [35380.988375] [] handle_hva_to_gpa+0xb0/0xec [35380.994016] [] kvm_unmap_hva_range+0x5c/0xd0 [35380.999833] [] kvm_mmu_notifier_invalidate_range_start+0x60/0xb0 [35381.007387] [] __mmu_notifier_invalidate_range_start+0x64/0x8c [35381.014765] [] try_to_unmap_one+0x78c/0x7a4 [35381.020493] [] rmap_walk_ksm+0x124/0x1a0 [35381.025961] [] rmap_walk+0x94/0x98 [35381.030909] [] try_to_unmap+0x100/0x124 [35381.036293] [] unmap_and_move+0x480/0x6fc [35381.041847] [] migrate_pages+0x10c/0x288 [35381.047318] [] compact_zone+0x238/0x954 [35381.052697] [] compact_zone_order+0xc4/0xe8 [35381.058427] [] try_to_compact_pages+0x160/0x294 [35381.064503] [] __alloc_pages_direct_compact+0x68/0x194 [35381.071187] [] __alloc_pages_nodemask+0xc20/0xf7c [35381.077437] [] alloc_pages_vma+0x1a4/0x1c0 [35381.083080] [] do_huge_pmd_anonymous_page+0x128/0x324 [35381.089677] [] __handle_mm_fault+0x71c/0x7e8 [35381.095492] [] handle_mm_fault+0xf8/0x194 [35381.101049] [] __get_user_pages+0x124/0x34c [35381.106777] [] populate_vma_page_range+0x90/0x9c [35381.112941] [] __mm_populate+0xc4/0x15c [35381.118322] [] SyS_mlockall+0x100/0x164 [35381.123705] Exception stack(0xffff800dce5f3ec0 to 0xffff800dce5f4000) [35381.130128] 3ec0: 0000000000000003 d6e6024cc9b87e00 0000aaaabe94f000 0000000000000000 [35381.137940] 3ee0: 0000000000000002 0000000000000000 0000000000000000 0000aaaacf6fc3c0 [35381.145753] 3f00: 00000000000000e6 0000aaaacf6fc490 0000ffffeeeab0f0 d6e6024cc9b87e00 [35381.153565] 3f20: 0000000000000000 0000aaaabe81b3c0 0000000000000020 00009e53eff806b5 [35381.161379] 3f40: 0000aaaabe94de48 0000ffffa7c269b0 0000000000000011 0000ffffeeeabf68 [35381.169190] 3f60: 0000aaaaceacfe60 0000aaaabe94f000 0000aaaabe9ba358 0000aaaabe7ffb80 [35381.177003] 3f80: 0000aaaabe9ba000 0000aaaabe959f64 0000000000000000 0000aaaabe94f000 [35381.184815] 3fa0: 0000000000000000 0000ffffeeeabdb0 0000aaaabe5f3bf8 0000ffffeeeabdb0 [35381.192628] 3fc0: 0000ffffa7c269b8 0000000060000000 0000000000000003 00000000000000e6 [35381.200440] 3fe0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 [35381.208254] [] __sys_trace_return+0x0/0x4 [35381.213809] Disabling lock debugging due to kernel taint --------------------------------end-------------------------------------- The root cause might be what I fixed at [1]. But from arm kvm points of view, it would be better we caught the exception earlier and clearer. If the size is not PAGE_SIZE aligned, unmap_stage2_range might unmap the wrong(more or less) page range. Hence it caused the "BUG: Bad page state" [1] https://lkml.org/lkml/2018/5/3/1042 Signed-off-by: jia.he@hxt-semitech.com Reviewed-by: Suzuki K Poulose --- virt/kvm/arm/mmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index 7f6a944..8dac311 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -297,6 +297,8 @@ static void unmap_stage2_range(struct kvm *kvm, phys_addr_t start, u64 size) phys_addr_t next; assert_spin_locked(&kvm->mmu_lock); + WARN_ON(size & ~PAGE_MASK); + pgd = kvm->arch.pgd + stage2_pgd_index(addr); do { /*