From patchwork Sun May 27 14:33:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10429419 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8FC79602CC for ; Sun, 27 May 2018 14:43:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D45A28B16 for ; Sun, 27 May 2018 14:43:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E52828B80; Sun, 27 May 2018 14:43:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 871D028B16 for ; Sun, 27 May 2018 14:43:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80DF46B0007; Sun, 27 May 2018 10:43:21 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7BD806B0008; Sun, 27 May 2018 10:43:21 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D4DD6B000A; Sun, 27 May 2018 10:43:21 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f69.google.com (mail-pl0-f69.google.com [209.85.160.69]) by kanga.kvack.org (Postfix) with ESMTP id 2D0A56B0007 for ; Sun, 27 May 2018 10:43:21 -0400 (EDT) Received: by mail-pl0-f69.google.com with SMTP id q16-v6so6092092pls.15 for ; Sun, 27 May 2018 07:43:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:to:cc:from:date :message-id:mime-version:content-transfer-encoding; bh=crnFaIf8iPDoBgdt2hVI0Nx2HYlcPuGrOj/Hr6QesVk=; b=qhkofxA+9ymy72nO7npQGkZnLW5A/33IQ8z9ssqacxj6EDNosz5fE19mKNdyc5KD9a H+sU73RIjV4DqKQ9gDdyeInPn2h8sZuH2+8bx9q5xDmdL0+X3TO0R6hK+WWpYsxnCAyx tHgDpwTkv051Nop7tAsHz1XqrgYUGPee+FqnGXSWdHI2HmuUZSu8FUE0Ida18z1nu/OY n99+46mNjLSRVzcYT+pHn3VqnNRtnnAY3xIkfwYVF4oMsRzTO5Ey4FxIXGzjgPmdJQ5I 5UZf8p1EeNhK4Tb1mBDdmO1cyREYoe7K3+aZvmegskB6W4oYpDdaI6Bt0/Ld7ClOpyFs ex2g== X-Gm-Message-State: ALKqPwdybz3EwX56mJvft1JGT+JUe9CY6KvIJQzM2GBIpc97McMIlwrY Yw+05qDYnZdOMQJskZDVlpSGgtJG/t4eCMYgWblnbz7o/3vU+xYT+O6KZpS5RnIaNLyVRdX2stX jgVVoOTXDJTeW2OZMxYVSmgytK8wj19iu0XeXAK2QUnnzfisDgwvpEKFzYsIeEJ0= X-Received: by 2002:a17:902:1a8:: with SMTP id b37-v6mr10360509plb.326.1527432200781; Sun, 27 May 2018 07:43:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpBXJ0ONlTk/wy1h6dTwuvS6Nvwaha1AbJ5nwCcXTp4vjhUQ5LQazfMBUldTMQnq8P7RKIK X-Received: by 2002:a17:902:1a8:: with SMTP id b37-v6mr10360483plb.326.1527432200029; Sun, 27 May 2018 07:43:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527432199; cv=none; d=google.com; s=arc-20160816; b=IDmb9b6DV8azvFWsLM8kVXFbCd7o9CYc4DKpvBCQtxIxj3u96YWbuC0w8c/60xTY6g J6CbGnTjuv1O+TTEgcnyTmkKFjW+bkpCNDn2I6KR8sXmwBsQsXGd00q80h9VdEndSh+T oksT3wVsUh9tb+XPpafmDA9gp5yJh2DPt3rbZgX5ZrKtp/0DrOsHKFPN4Zz5sNh+y/s1 PCYkgUKRilVg7pbkS/f7RihF3k+03uuzN1wm3ENFdsK4cfsFQ4qy4yKSWGuFwmS8OukW DdbakK/GUWHiLVcEEEUoalPpsyETPTo9nRsVyzlLmtZVCK5qtCxEAaRRSpI4RGtdRRcp 3haQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:from:cc:to :subject:dkim-signature:arc-authentication-results; bh=crnFaIf8iPDoBgdt2hVI0Nx2HYlcPuGrOj/Hr6QesVk=; b=fd8NhN169rFFnTXkMbTYPA95Dqd/AwdzONh6gAeHEmPz7KwWLK32WubxjJv0a+5YZF NGvtSX6KPsA9gafXn/uCJRS2FQW1ORqQQAay69M6ENqfq3xn3HjPBEExzCNw2kiLJn8k fhM+EdJzMPOTuDdo3fOTBvZ2WXNqx/jAs8gYLOZFwqa3jBwz4ohlrIx9Xi4RA7aVV2Aw oZ9QMsPDRi+eFvbTzLpINjy5wOodffr+0ZpRvD0FwmsoKLEeF4WwFpKrOsJY71qgrevW Itd7VRpV09SNAJJJuFFzhjaW20BwhWsdxR3Plt9ckmyjwwxlaElx+WAoxfPkZ/qmsjMM Hvxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HtJ7S5kG; spf=pass (google.com: domain of srs0=ri55=io=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=rI55=IO=linuxfoundation.org=gregkh@kernel.org Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id m26-v6si27940638pfa.45.2018.05.27.07.43.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 May 2018 07:43:19 -0700 (PDT) Received-SPF: pass (google.com: domain of srs0=ri55=io=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HtJ7S5kG; spf=pass (google.com: domain of srs0=ri55=io=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=rI55=IO=linuxfoundation.org=gregkh@kernel.org Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D03620875; Sun, 27 May 2018 14:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527432199; bh=Lo8Cq2GyU/h6Quidff5IxL+itRPVDYoy3t4KBu7BzT0=; h=Subject:To:Cc:From:Date:From; b=HtJ7S5kGGUidOcnqawcM61ncejCR3H46147bsyQS2Cii2nNfSv2snJQVfRUNyOnbe 5WN5tF5PN+Zh3oX6AOm8Bdo4P4KdvOgtUix2xaW5Cjk7sv5zVQd7GsXWjULPO4LJ+O cEr9Lt9gPyuJezFmJZWjIhm6qehm4Dda9IqBT9wE= Subject: Patch "x86/mm: Do not forbid _PAGE_RW before init for __ro_after_init" has been added to the 4.16-stable tree To: 20180406205514.8D898241@viggo.jf.intel.com, aarcange@redhat.com, alexander.levin@microsoft.com, arjan@linux.intel.com, bp@alien8.de, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, gregkh@linuxfoundation.org, hughd@google.com, jgross@suse.com, jpoimboe@redhat.com, keescook@chromium.org, linux-mm@kvack.org, luto@kernel.org, mingo@kernel.org, namit@vmware.com, peterz@infradead.org, tglx@linutronix.de, torvalds@linux-foundation.org Cc: From: Date: Sun, 27 May 2018 16:33:02 +0200 Message-ID: <1527431582235146@kroah.com> MIME-Version: 1.0 X-stable: commit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This is a note to let you know that I've just added the patch titled x86/mm: Do not forbid _PAGE_RW before init for __ro_after_init to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-mm-do-not-forbid-_page_rw-before-init-for-__ro_after_init.patch and it can be found in the queue-4.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. From foo@baz Sun May 27 16:10:02 CEST 2018 From: Dave Hansen Date: Fri, 6 Apr 2018 13:55:14 -0700 Subject: x86/mm: Do not forbid _PAGE_RW before init for __ro_after_init From: Dave Hansen [ Upstream commit 639d6aafe437a7464399d2a77d006049053df06f ] __ro_after_init data gets stuck in the .rodata section. That's normally fine because the kernel itself manages the R/W properties. But, if we run __change_page_attr() on an area which is __ro_after_init, the .rodata checks will trigger and force the area to be immediately read-only, even if it is early-ish in boot. This caused problems when trying to clear the _PAGE_GLOBAL bit for these area in the PTI code: it cleared _PAGE_GLOBAL like I asked, but also took it up on itself to clear _PAGE_RW. The kernel then oopses the next time it wrote to a __ro_after_init data structure. To fix this, add the kernel_set_to_readonly check, just like we have for kernel text, just a few lines below in this function. Signed-off-by: Dave Hansen Acked-by: Kees Cook Cc: Andrea Arcangeli Cc: Andy Lutomirski Cc: Arjan van de Ven Cc: Borislav Petkov Cc: Dan Williams Cc: David Woodhouse Cc: Greg Kroah-Hartman Cc: Hugh Dickins Cc: Josh Poimboeuf Cc: Juergen Gross Cc: Linus Torvalds Cc: Nadav Amit Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-mm@kvack.org Link: http://lkml.kernel.org/r/20180406205514.8D898241@viggo.jf.intel.com Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- arch/x86/mm/pageattr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Patches currently in stable-queue which might be from dave.hansen@linux.intel.com are queue-4.16/x86-mm-do-not-forbid-_page_rw-before-init-for-__ro_after_init.patch --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -298,9 +298,11 @@ static inline pgprot_t static_protection /* * The .rodata section needs to be read-only. Using the pfn - * catches all aliases. + * catches all aliases. This also includes __ro_after_init, + * so do not enforce until kernel_set_to_readonly is true. */ - if (within(pfn, __pa_symbol(__start_rodata) >> PAGE_SHIFT, + if (kernel_set_to_readonly && + within(pfn, __pa_symbol(__start_rodata) >> PAGE_SHIFT, __pa_symbol(__end_rodata) >> PAGE_SHIFT)) pgprot_val(forbidden) |= _PAGE_RW;