From patchwork Thu Jun 14 00:45:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10463081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 548B6603EE for ; Thu, 14 Jun 2018 00:47:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 46EE728988 for ; Thu, 14 Jun 2018 00:47:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3966628B9D; Thu, 14 Jun 2018 00:47:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0B1E28BAC for ; Thu, 14 Jun 2018 00:47:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2815B6B026E; Wed, 13 Jun 2018 20:47:06 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 232C16B0274; Wed, 13 Jun 2018 20:47:06 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 084E16B0275; Wed, 13 Jun 2018 20:47:05 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt0-f197.google.com (mail-qt0-f197.google.com [209.85.216.197]) by kanga.kvack.org (Postfix) with ESMTP id C5E2E6B026E for ; Wed, 13 Jun 2018 20:47:05 -0400 (EDT) Received: by mail-qt0-f197.google.com with SMTP id c1-v6so3325185qtj.6 for ; Wed, 13 Jun 2018 17:47:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:sender:from:to:cc:subject:date :message-id:in-reply-to:references; bh=RePhmNpB7vH0qzi7VF1eS4JNjN1obSSpKL3qQNnVils=; b=nx2dF6ecO/MRAHqf5HVqbFn/1jFFgO3bUs8mxsOGrsTQeM86Sh2U3sW75fZ5EDn4ze W2F2hC0zoecVTLuLQMf9w81z4Y8nNhVvAoVdfPR8wGjKPHscFP2i6k076GNdtpeUFCpq vD6KalxgS6I4MVjXEueSgfZoyNrGdNuAIxQDP4n54RkDy4DIwyahRmqKF3zd5zyYZ1UJ buhBIWunKfu/c+fEySTH2YfOjyAmZ12Wo1T9F1UJCdUBrZI5fe0maZO/6P47hAfrOsEJ TQfiVOvy63qfsh/AfAeggqQANfTbnW3ZqrEPbNW6yHqnCw2gSPxpuC6sw77kPvk/azFX 8maA== X-Gm-Message-State: APt69E3/+0p/3rTMTXGS/nOjSmtX3k/+3ncP/Fd7LBOY8YlQ78po4BZO A6qwcWmZFBBjHxRQqTPfq0pKn9RiEslWoe59gcNwHbG1ZBHT9GFpwefWsrfS0qXXhiocuGHYplv R7VQy5A1dpumMJRot0kzDfv15PxKhhKq1uD1kvf5STQ0E+6stvWeM/I3Di61MVHIYTin20O4GQD ntV79Pzkrqu9gkUaDzqgS5ZrbsVbqqEuRd4eb7b2wHd2KzulXgWeXgrWeFxbmy+sclIugynoVWi IfC6joQKYJywTkEnVVjFDZgul2USsc6IFgoYZeIFeECUtsZ/fANyFNgS8i3aLL0981W5+2GFe/n yJvI5CTESaRX6Kyp9NuaBFgvmJIsDjX6g4dDY7f5yVHnSkc/Ouxv3dL99DQegCulcQlj8wRfnA= = X-Received: by 2002:a37:c9d3:: with SMTP id m80-v6mr338157qkl.173.1528937225554; Wed, 13 Jun 2018 17:47:05 -0700 (PDT) X-Received: by 2002:a37:c9d3:: with SMTP id m80-v6mr338136qkl.173.1528937224883; Wed, 13 Jun 2018 17:47:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528937224; cv=none; d=google.com; s=arc-20160816; b=XQ8ZI6okvqvsSyyaSbgXR0RDLNMiAnM4pVwe7+4EbP6XdlkTU3c/kraJI0TWkFWnkC 35LSB3vbJvptfzZIE28ei8vwKRTbuyeP55jHtNu293Qztr2L5MUQfm419Ny7+LHR/i/h JeTmEpd1HNBbMH9Fs6xMeHw0DhWSpcqWKlkiIrX4m7DFha/5i9SbzxqyEGrVwi52c7QA gN4GsMWZnYDxoM0U9tJZBQSLSbmu3gRUPRxMPC3Cl73nulOiTbMc0rvv/tPr19Hpk4Xq IFN/QDmaTxsxEd2B8jcReSl2NUneANL+E9Pkjz8Ft0iAcNRwFXVg2PaRzrUxcZIeZ1Tp OH2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature:arc-authentication-results; bh=RePhmNpB7vH0qzi7VF1eS4JNjN1obSSpKL3qQNnVils=; b=SVoqm3wpALEKAZsA+8pH7/OfxIofG9U27rTB4BuwMeE8Lge1LAxTM8YDW8Kq28n64v gyXkTAk6EFfXHQca29e54GQtJ+TclqG8zfFZhADzq3i/2Li9nXpwR29rni+A/QaZgQBw y+tmHhT6xFjUdTU672Bwv1ld5sk80xub0B6lqdt25yUyEtUjwDNL3b4/Juh3l0z0r5BN ewYOrvCuL/0Vy91/XaXJJ9nsFlEpDdd4B5Hs1N1hX1tK+jyCx+BrJN3kjUKDYXiFmgXp ROfIijFfP6/FTxh2CusKPNYysiQEmxwN7VDVfzmHvC6IBp9ufCk+fZDxfoMRyBMvEz+m AonQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qg0ukhS4; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id w42-v6sor2275647qtw.101.2018.06.13.17.47.04 for (Google Transport Security); Wed, 13 Jun 2018 17:47:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qg0ukhS4; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=RePhmNpB7vH0qzi7VF1eS4JNjN1obSSpKL3qQNnVils=; b=Qg0ukhS4B1rJIhTEf6D6vvd94XR1fFT1xIDkFNpSlUnUu6agCkh4MwYwtbtMXUsCS7 sWTOHc4xhJxUQoVU5ITxMf45zwt086z1v8+zxfCI4TB8XyAitj41qyGaxt7Ve3I9U+us u0ZdJBxa12MMEMNJV6zSIFP4d7yacr1i4/FKaaXwMcvwnwdxrL1IcCcOin2MGvR9rO7B jdUJVO9sz7oIcbrSLUmeigZ92TOlBi35pzkiNEIWvrFTEcljTxX+5E9p3WW5JW1GeWzO /Lw443RpAJXW+Q3WINkSnZP24QR762pWT5uPgkQIfdLuD38WAV1Usy4qppj6o866Fjzs 3Psw== X-Google-Smtp-Source: ADUXVKIjsoIqPXvu8X0BXSF5hnxvQsfMmcc6Hwok24BXyDYP+Y/TMmPqUBqt9U2oUlMCvYts0tRdvg== X-Received: by 2002:ac8:2631:: with SMTP id u46-v6mr375960qtu.306.1528937224700; Wed, 13 Jun 2018 17:47:04 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id u31-v6sm3225898qtc.28.2018.06.13.17.47.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jun 2018 17:47:04 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v13 10/24] selftests/vm: clear the bits in shadow reg when a pkey is freed. Date: Wed, 13 Jun 2018 17:45:01 -0700 Message-Id: <1528937115-10132-11-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP When a key is freed, the key is no more effective. Clear the bits corresponding to the pkey in the shadow register. Otherwise it will carry some spurious bits which can trigger false-positive asserts. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index da4f5d5..42a91c7 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -556,6 +556,9 @@ int alloc_pkey(void) int sys_pkey_free(unsigned long pkey) { int ret = syscall(SYS_pkey_free, pkey); + + if (!ret) + shadow_pkey_reg &= clear_pkey_flags(pkey, PKEY_DISABLE_ACCESS); dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); return ret; }