From patchwork Thu Jun 14 00:45:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10463095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5E3BC600D0 for ; Thu, 14 Jun 2018 00:47:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F75928988 for ; Thu, 14 Jun 2018 00:47:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4425028BA8; Thu, 14 Jun 2018 00:47:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD82F28B9D for ; Thu, 14 Jun 2018 00:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABAED6B0278; Wed, 13 Jun 2018 20:47:11 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id A6B656B027A; Wed, 13 Jun 2018 20:47:11 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 911D06B027B; Wed, 13 Jun 2018 20:47:11 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f199.google.com (mail-qk0-f199.google.com [209.85.220.199]) by kanga.kvack.org (Postfix) with ESMTP id 639986B0278 for ; Wed, 13 Jun 2018 20:47:11 -0400 (EDT) Received: by mail-qk0-f199.google.com with SMTP id p85-v6so3511830qke.23 for ; Wed, 13 Jun 2018 17:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:sender:from:to:cc:subject:date :message-id:in-reply-to:references; bh=DFomrVs4YU+TZzRnIOv68GvYhpyt/0GAbgDOQSBvV/c=; b=VJTZEn6hsclOCLf9jgivcNQim2MGfDFeDJOuPHgZ28tlBJj/tn4DigCFmJAGSuvsyO Zb4HapZHWeY+MOzdYqGdP3TSI5B2Wfu2hhzzK8cnKgV5JACcvaES//xW1Mm4V72rOzgN F4Z6Tsh950qF4KM6c8hwQFaDCxhYj6eElk15ImJFqvLDJHj66em+OdDSiM0NZkrVu7v4 yytz4ulP9TUGtdAqHeFOPVkownTrtFG6MvUq3uZk8cuHiYflX4ciJMia/TF3eThkQzaZ OXpm5yL+vnGDBeCdDgY3ayG37o7nhU1c6bSVCREUpp786njRLY5oXnTFhjxBWQTjvUiP kfXQ== X-Gm-Message-State: APt69E1eyMsMXcUIRG9gzGb8f13sG5aD1j8dgl1sUnq94Vpb5WvoIrfM y8xpfYFVV3PYDX6D7NGFrI4to7y+uHn8Lj5OIvxlcik2QbNLl5/5IWl7vbUcAnqglEN42eml79c U+ee5UDgD0erGKEMPxhLZj8V5T/iKDu7GXTFAqh1J67AJUKqYWeT8vnJd/kkqJgPDSAu/h3SuzD 8MbWbqnMrHm7wN0kAvp0gS2aST4+nEu+LV3gtmFYxuaVzmfQr2s1tKPlfHCaimljrl+fzZiUsf9 JsZ+os3mRHKZAAxevuQ+SJzwSR7ty/Nfc7PXhNu6FN31QUyReLZBFiFaefxoH9T09ewwZe0l8sI RKmFN0p4PxLXdgDNNH0NzKZKmcO4ikrpB53j4f0m5zN+fy50RyFy/Fy7tY/6+fSo/7fTtrLpVA= = X-Received: by 2002:ac8:34aa:: with SMTP id w39-v6mr352585qtb.237.1528937231217; Wed, 13 Jun 2018 17:47:11 -0700 (PDT) X-Received: by 2002:ac8:34aa:: with SMTP id w39-v6mr352563qtb.237.1528937230647; Wed, 13 Jun 2018 17:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528937230; cv=none; d=google.com; s=arc-20160816; b=EAam0ucdOnJRpOX6MRQH6+9bTZvcZlqaDRq3wM8oPM5B8Z0V29M0iF1I79qPL0/MbW beMnKY0YpDMC//iuSR8NG/MD6nREDUtg6y+wU7LyXxQnouCHM9lqzWDKkWzV6VR9qtsr mYjKkNSlawV2ltG77jn1Ufd6hny0HI+jwhJxYAH+vcwDR6xpCFtsmUDc19Sp8Y5/5Zww rAAvdLqdIc80F4C+B0l2PuYUupufCthiOrL/+Qkx0KyUh2Ki2rz9Qt50H6Fscp2DTJHE EqtSF8zb0+bg1MgZ/l3kbSoCDoDnDPNx81MCLIqk1bNF+35VSbbBTl0Jk/q/eNCcCGBL Ftiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature:arc-authentication-results; bh=DFomrVs4YU+TZzRnIOv68GvYhpyt/0GAbgDOQSBvV/c=; b=GXCO6TiWTu2g/muEjB3v7QazRWtQCWVCe1p3dptxURpo2dQZnlBdO+AktPNql4+xbx gkdBesfRP5gTZUSxzKX0/7Tkn5xcp5nyuvY10ETWDX1Pv6CBLn2tj+AqILdng4eCuQIl YGmCSA7doKRu0VLjV5Npz2EOsW42OzoRMjWXusWNfQMby8eX7HzKrHmXkrcPF46yJ/Wc HBKqesdaqSATyWYOZsQu5RmCQZNxTh51aZ4kO74QlYEn3Gp56gYZyeid1oXbFxHGfCgW RuEDfvxPN5WFCZA0BdWhfeIISktRmb2qGhvj2zQvymheRmE13+bF5MqIjgPYyvXNtSpA K4dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UfgBGIZV; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id l27-v6sor2070526qta.64.2018.06.13.17.47.10 for (Google Transport Security); Wed, 13 Jun 2018 17:47:10 -0700 (PDT) Received-SPF: pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UfgBGIZV; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=DFomrVs4YU+TZzRnIOv68GvYhpyt/0GAbgDOQSBvV/c=; b=UfgBGIZVQaoYBCw/sN532WtHqWI2GsIebWXhgPVKXTumuqpyiBkg5+3MT+dQxFhPFu vhiaSy9OjPltY8OKiESUsVIRK27GoS5ODhALFZ46z4dcmBDZ5BSNNq/sCKiSPjv0XiRP ViQ9XUJANrlEyOg7RqQ6mmG9OvulSgBkqn8avkTkrNIRVkfLoQQaAVPX9naNdMG0vEJS cBd2ood8vFvSDF1IqKPq5AGcklWnaXBQyhgiVs0gntCQshUwCSXaeuD15YKJs8OfOp/U KYT7QK59ppe+ZZuvgN0nI2ZRbh+EoRSw1U5qpq1xkTdyRGUHEbOhTHi3MdlTod12tqc8 cVxQ== X-Google-Smtp-Source: ADUXVKJMvcsVS1ibL3NcHRtU0I9zXs9hfwJdzYyq8kXvrEvoqfLkMRlN54mhPJblU/67PASWykDcBA== X-Received: by 2002:aed:252c:: with SMTP id v41-v6mr343212qtc.403.1528937230477; Wed, 13 Jun 2018 17:47:10 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id u31-v6sm3225898qtc.28.2018.06.13.17.47.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jun 2018 17:47:10 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v13 13/24] selftests/vm: pkey register should match shadow pkey Date: Wed, 13 Jun 2018 17:45:04 -0700 Message-Id: <1528937115-10132-14-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP expected_pkey_fault() is comparing the contents of pkey register with 0. This may not be true all the time. There could be bits set by default by the architecture which can never be changed. Hence compare the value against shadow pkey register, which is supposed to track the bits accurately all throughout cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 9afe894..adcae4a 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -916,10 +916,10 @@ void expected_pkey_fault(int pkey) pkey_assert(last_si_pkey == pkey); /* - * The signal handler shold have cleared out PKEY register to let the + * The signal handler should have cleared out pkey-register to let the * test program continue. We now have to restore it. */ - if (__read_pkey_reg() != 0) + if (__read_pkey_reg() != shadow_pkey_reg) pkey_assert(0); __write_pkey_reg(shadow_pkey_reg);