From patchwork Wed Jul 11 05:15:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 10518783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4A976028E for ; Wed, 11 Jul 2018 05:25:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96DC928DAA for ; Wed, 11 Jul 2018 05:25:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8BA0928DBF; Wed, 11 Jul 2018 05:25:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F1B528DAA for ; Wed, 11 Jul 2018 05:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42BF26B0269; Wed, 11 Jul 2018 01:25:14 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 401FE6B026A; Wed, 11 Jul 2018 01:25:14 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F0F76B026B; Wed, 11 Jul 2018 01:25:14 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id E3A9E6B0269 for ; Wed, 11 Jul 2018 01:25:13 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id cf17-v6so6610014plb.2 for ; Tue, 10 Jul 2018 22:25:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:from :to:cc:date:message-id:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=3raGnA9z7okIJIPBZ0TcvPEGZO0uh3vVIUuJ/QEo1yM=; b=DKQDYKV7iFREroksu1kBogBrCW58wEghY0tM/DsJKrx80SlefPSvO9c8a5HdFa/6a7 ggL8IaeWG/1Brj8cveNtsyb90C39XTgfUVAfVe4bDr+s5IzORQENqQ9dhSJzo6ElfP78 aiOy5JVNHn4gnNEi0nw8I0R/0iWBUxp7mTQj+zwVf55qSYWJxexwgnZ2sn4YB3YvysOj idVZ0Kvu0F4ZQcdxRvmPzp8Nk7tkrZo8SF6cyN7Bv9+SwVrwfj2qFwKlRrFhu9+1Zrw3 zcDP60uoZpMrcML7i/JFOFMAlxcUQ3+sklRnBag+Unpd5mdzYP3gs2SXee28bZUzHDsj yv0Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: APt69E3JH6SEiLEr9mJUDuPPlbjrHUl3sH+MC6Fkkwwedy3/1w3ejr3g rUlGpc8sw3DJIluKcqGXrc3FGXA28ONAj2wsaqPygyBhYV9nlhnizdcp/A9VysY0HzPkQdM/l2E tlQQtxOBKfB8u7sH/RoK/zcDJNSCHwTqBDUFIRV2zCaOrV9Ik4bAxcEg5q2CwFZQraQ== X-Received: by 2002:a62:d693:: with SMTP id a19-v6mr28349265pfl.248.1531286713621; Tue, 10 Jul 2018 22:25:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf5xKb3uHWAf3UcLDfY2lY2mqfUG3hbEu1+Hh0Yyb5wzV7XI9tUIXErb6AOKQ8H5hRorrb+ X-Received: by 2002:a62:d693:: with SMTP id a19-v6mr28349226pfl.248.1531286712743; Tue, 10 Jul 2018 22:25:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531286712; cv=none; d=google.com; s=arc-20160816; b=QlO9AityydrLEH+UKsS2GVWGbI/YIEonUlQ3f1rT6t8rLgUNEpEZX31HJgb8YBkDpM hwtxZF870lR/xzJS6qLZuVtCH9vLUBApOBP0Kna4dO52LEX8gFrZfDmdoSNiqmFs/V8l 473SpmmLLzzCBIfs9DnFkKtNPCvlvK/boV6xpBrp94P/Fmt0UHr6RlPWutISC1ukJLcs FaPV/i9XE/vAL/hDeNItOj/UF7SNCQ3oseXRK1hbQNggwSAYsV8HTXGsIAOtvboiNcZ/ xNWlmA4hZM/5FskqjhKd0x8n33z/mCVEOoVhi+MaLy4+1W7aGL5SBkca9iuGbRgbCxl3 ggWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject :arc-authentication-results; bh=3raGnA9z7okIJIPBZ0TcvPEGZO0uh3vVIUuJ/QEo1yM=; b=kQ1/098sjkMpz3AwK4iyGaLJv26KEoQryZevZl0YbxqkxnbWZX2AxKl2DR9ymQnmfC iMUCosToGcn2Kr1L/5hMysAC/P+oTbDz0pb/CPk0xDbJgQWLNSp7iWJpblQODn/aX2U1 E9ts6lw/OCDbJ4dk4h+tHz4UJFGifN/K8mlJ+WFTKKqgp4IG+PgjxmVYFM/zzXvgEZbG v+8s79d04mlI/OKWMCFMT+vSyLsxbEYF/jrtQd3KuOZDSr0qiloTm8vope679jAaakS6 2ps5607yAJTVMrvBFZd5Bp5GV7y4PgKvdKMEgH66YFjcmVWaeGXL8TPwcqrT8m7kZNX8 mRJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga06.intel.com (mga06.intel.com. [134.134.136.31]) by mx.google.com with ESMTPS id cf13-v6si18773882plb.175.2018.07.10.22.25.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 22:25:12 -0700 (PDT) Received-SPF: pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.31 as permitted sender) client-ip=134.134.136.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dan.j.williams@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dan.j.williams@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 22:25:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,337,1526367600"; d="scan'208";a="63813289" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jul 2018 22:25:11 -0700 Subject: [PATCH v4 7/8] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL From: Dan Williams To: akpm@linux-foundation.org Cc: =?utf-8?b?SsOpcsO0bWU=?= Glisse , Logan Gunthorpe , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 10 Jul 2018 22:15:14 -0700 Message-ID: <153128611419.2928.14858876648286345508.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <153128607743.2928.4465435789810433432.stgit@dwillia2-desk3.amr.corp.intel.com> References: <153128607743.2928.4465435789810433432.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP The routines hmm_devmem_add(), and hmm_devmem_add_resource() duplicated devm_memremap_pages() and are now simple now wrappers around the core facility to inject a dev_pagemap instance into the global pgmap_radix and hook page-idle events. The devm_memremap_pages() interface is base infrastructure for HMM. HMM has more and deeper ties into the kernel memory management implementation than base ZONE_DEVICE which is itself a EXPORT_SYMBOL_GPL facility. Originally, the HMM page structure creation routines copied the devm_memremap_pages() code and reused ZONE_DEVICE. A cleanup to unify the implementations was discussed during the initial review: http://lkml.iu.edu/hypermail/linux/kernel/1701.2/00812.html Recent work to extend devm_memremap_pages() for the peer-to-peer-DMA facility enabled this cleanup to move forward. In addition to the integration with devm_memremap_pages() HMM depends on other GPL-only symbols: mmu_notifier_unregister_no_release percpu_ref region_intersects __class_create It goes further to consume / indirectly expose functionality that is not exported to any other driver: alloc_pages_vma walk_page_range HMM depends upon and extends deep core-kernel fundamentals. Mark its main entry points EXPORT_SYMBOL_GPL(). Cc: "Jérôme Glisse" Cc: Logan Gunthorpe Reviewed-by: Christoph Hellwig Signed-off-by: Dan Williams --- mm/hmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index c5a6e61ee302..0af3220ffcba 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1055,7 +1055,7 @@ struct hmm_devmem *hmm_devmem_add(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add); +EXPORT_SYMBOL_GPL(hmm_devmem_add); struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, struct device *device, @@ -1109,7 +1109,7 @@ struct hmm_devmem *hmm_devmem_add_resource(const struct hmm_devmem_ops *ops, return result; return devmem; } -EXPORT_SYMBOL(hmm_devmem_add_resource); +EXPORT_SYMBOL_GPL(hmm_devmem_add_resource); /* * A device driver that wants to handle multiple devices memory through a