From patchwork Tue Jul 17 13:49:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10529515 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E7948600F4 for ; Tue, 17 Jul 2018 13:50:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE4D029203 for ; Tue, 17 Jul 2018 13:50:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C271129221; Tue, 17 Jul 2018 13:50:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 58E8D29203 for ; Tue, 17 Jul 2018 13:50:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74B336B0270; Tue, 17 Jul 2018 09:50:29 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6D0B16B0271; Tue, 17 Jul 2018 09:50:29 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59A7D6B0272; Tue, 17 Jul 2018 09:50:29 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt0-f198.google.com (mail-qt0-f198.google.com [209.85.216.198]) by kanga.kvack.org (Postfix) with ESMTP id 2C7096B0270 for ; Tue, 17 Jul 2018 09:50:29 -0400 (EDT) Received: by mail-qt0-f198.google.com with SMTP id g7-v6so743957qtp.19 for ; Tue, 17 Jul 2018 06:50:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:sender:from:to:cc:subject:date :message-id:in-reply-to:references; bh=EcR3SDmB0WV2XGlTEZwt9KVPitnK5134qlvUDtzoqfA=; b=LvR4V/3bfd3SFtho8zqN+Y8hkd6BjglDO6bk5MCATdVIqWW6vXQdtoZ1SALN/654HP WbZwRlx+9+e76E0PsKH1yvYCKy3FqXi4mAZOfqR3jjhAMvL4AGJPYvvuqpWUB6iouUGx Xow7xk84Q5XiV+uyXlBtjZdY+jgTyxdTh3rjZRSlsDAnOcFXfPqqJk9c3+6JzPfQS1A7 LHjTqj43LbTaxYBPdyYeu9af5TMitPI2NW3gwzIZycO4cNXctSHpQXSPAO76woDmq2GX ZpCokpAjpAJ9AvuYf2OXTx1o1gwaXDEB1IfSq6CDQcyEU/PsHM3/1R4FQiTpiYaTXJbF 4Vxg== X-Gm-Message-State: AOUpUlFk63w3w0UHPSq2tJpWJ5v5I2E3S+pp6qISHmy8Pf17+rA9iafk APnNf08T8udgJnYDmI1dGODBO5RaCpmELTgSvJFTfJVrdPHj2t8C9r5RoR8HJos1Ayb2pP3Cvab wny1IRjJoDYNRKT1uC+Hi/mKZtyjnMnMbT5QQhlXoRpkEgstyyCtFKb6YBBDtURTw/sdjqt00VN QNOaTA50PatlZ4r6X2qtyPlcrinEVLZhIG92ID4UlCqetp8HjQq+toL1JR//BOcXqA68cH8Z4vl TwXORZ47lys/pJlK+WNFg7yMB0t5n9bmG83bfalRT9ZqFvs4/KorgeCdFBzPsVO35DMTFD9FoPO nYMa1Tp9fpM9vXJwuLlahei1Oc3PimyO8Iutc/eOBazER6E6GJwDivzynhtS6UyDFqtw1LOtAA= = X-Received: by 2002:aed:39a3:: with SMTP id m32-v6mr1618415qte.109.1531835428993; Tue, 17 Jul 2018 06:50:28 -0700 (PDT) X-Received: by 2002:aed:39a3:: with SMTP id m32-v6mr1618373qte.109.1531835428438; Tue, 17 Jul 2018 06:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531835428; cv=none; d=google.com; s=arc-20160816; b=B7fBJ7XKzqcKCtMKvWC67Co1/9gl/2lEa6sS6Q1zu8A3eaGTByZSdSaEXhjMIi8Sa4 zFqUVAJlJLcRfX9k1HwV1L/TKty6I+l4lsitoAWm+pXe3U7pfqQHK8dzZLiHtp2zd20x tFkHiZqPHLazs8wiH8qgvSmx060qqeKrGpD/vmxQ8PT3AfQwd2ZxQ+NL9XdBpK9D5ret BpRDNPYJ8EZVvbkaOD7SUko3DgcoNPGBzALN9pRt1A0Aol3Nyqr0iRDpfezYfRxc3kB/ rTuomERsFl/ne/NgWfreAFRmp9sIilkA9100Nm7yd1nnpjGPEpNwkfTLrOXxl/7e58fh Qt4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature:arc-authentication-results; bh=EcR3SDmB0WV2XGlTEZwt9KVPitnK5134qlvUDtzoqfA=; b=TUyNZdBfDETqCxdnkBvQAYv6+LvnpYi4pixvKc6IJFViip3vHtA7sZTZUOmJ8KKEE3 pya2j7VqmozIt5RG4u+K0HFi6Szzn9GQGd9zXrtwBwQA7xdqoz9dWEFHv3SC5UJwL2Od teMML56g8f74B3IL32EKPaPB0dytbYFtc/LUD67rZiuIW5iT5X+3bOm6AUNkMavzmlxF ggLw+TZJrlQjpSx/LdQZl/3fD6q//En3y3+YBM0NBcblDecD7diTS5U38i2jsKAqf6kJ EvA6Mo3tpce/JVRd2fQUNcwBmOUtgBexFzDLJFmTqL52t6g3aYxQroazM7B+cpzBsrA7 dSEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="g/z/ucCp"; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id w42-v6sor504540qtk.1.2018.07.17.06.50.28 for (Google Transport Security); Tue, 17 Jul 2018 06:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="g/z/ucCp"; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=EcR3SDmB0WV2XGlTEZwt9KVPitnK5134qlvUDtzoqfA=; b=g/z/ucCpwLvVJ58dVBBLdnzlKDwFycSwj6eSl2XbH3RCjOxlF1ghl+yTEngxMfIe5q 8vp2Vcy/Oi9Vpmqi9fB9BAHx9tCqMXn9iJFmyfNQyDiD3+mDu8AxznanTJiaPFTbXOKf +CMSCHLA1DMq4lDnvyNQguujKueJHLDxT8ri2hDbo35a1oinL+2zX4X705i2aps2R0NE h5Qq+14BFClJlqzjzOGLpFel1sNcN2UuUwZwKCM9E69yHGKHf+m7v185m/sRelLhraeT rKSPRRyBqrg0lQ2ZEEK2HpFHI+iWEPg0L9zmqZVRQlqp3OVaqAJ1K/YbP6owICiaqHGN 5Gog== X-Google-Smtp-Source: AAOMgpc8VCMeULevOwhRuw2S05SejeSP3kwqmAfzu6osIa0Th39JJ8Neelc3h0pGWSqRqIGH0HTVJQ== X-Received: by 2002:ac8:29f6:: with SMTP id 51-v6mr1608348qtt.200.1531835428234; Tue, 17 Jul 2018 06:50:28 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id s83-v6sm640937qki.20.2018.07.17.06.50.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jul 2018 06:50:27 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v14 12/22] selftests/vm: pkey register should match shadow pkey Date: Tue, 17 Jul 2018 06:49:15 -0700 Message-Id: <1531835365-32387-13-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> References: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP expected_pkey_fault() is comparing the contents of pkey register with 0. This may not be true all the time. There could be bits set by default by the architecture which can never be changed. Hence compare the value against shadow pkey register, which is supposed to track the bits accurately all throughout cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 2e448e0..f50cce8 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -913,10 +913,10 @@ void expected_pkey_fault(int pkey) pkey_assert(last_si_pkey == pkey); /* - * The signal handler shold have cleared out PKEY register to let the + * The signal handler should have cleared out pkey-register to let the * test program continue. We now have to restore it. */ - if (__read_pkey_reg() != 0) + if (__read_pkey_reg() != shadow_pkey_reg) pkey_assert(0); __write_pkey_reg(shadow_pkey_reg);