From patchwork Tue Jul 17 13:49:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10529491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B45D600F4 for ; Tue, 17 Jul 2018 13:50:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 63DAF28D8A for ; Tue, 17 Jul 2018 13:50:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 583442921E; Tue, 17 Jul 2018 13:50:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F353D28D8A for ; Tue, 17 Jul 2018 13:50:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2EC56B0269; Tue, 17 Jul 2018 09:50:20 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id BDBA36B026B; Tue, 17 Jul 2018 09:50:20 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0BBF6B026C; Tue, 17 Jul 2018 09:50:20 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f199.google.com (mail-qk0-f199.google.com [209.85.220.199]) by kanga.kvack.org (Postfix) with ESMTP id 73DA96B0269 for ; Tue, 17 Jul 2018 09:50:20 -0400 (EDT) Received: by mail-qk0-f199.google.com with SMTP id j189-v6so844849qkf.0 for ; Tue, 17 Jul 2018 06:50:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:sender:from:to:cc:subject:date :message-id:in-reply-to:references; bh=bkiErPspo3EK2aWCWuIgKpEXyXDS844E5uOtyP7WDm4=; b=oceIXLHlwTKrWwpFgLk/Ia2BJL+MuVrtEcZQnQujOyQJ9S7JeUqZDglhQDj5JN+PB2 J2CMiusJvbT/DD7g04RqqwzyjTvvAp7Q0gu7bPRBpGJumkmvFYXfdiV6Mi6tL8OlA8uS kcmI9fOMsEEa01astJ7yEQh9cBHYDRjFAIOqqT7BhFkHDRKRdkgIMZcLK0UsCp9xeEKR w9fXmPmrIy2mH+/b8Xh7wh2Vnt/a8Pz0RUb65WkxNLG2VBaZgtp+wIJJ1ugNw3yZCl4d KYIoe9K4sxFKmT5XCoVRBIBElnvzM1GM+ERgt8iUAuJ5dnc6E1SFpfkYfU+TacH0oeEw +kFw== X-Gm-Message-State: AOUpUlEMbbIMVU/hNhrQhcVFGQONs294PB80Ya50si6eZmjJtx+RvzCb ywipAv6F1UCCEdV5RkZMwpBbhfY1/6eHziK6PAjT6sLKJ5aVzkJUfCCyDZ1wL4nyr+XYewLFHKq kDZ8593Eg0hrGwsGVMWHZ+IDelsAKc4g9kpgnDicN0EK3y30NKT/jvu7bhrpJs/e6xVGzcn6L7E dkjGelGBX+8jBHGbguYtgOrFpMGcdwBP+IXtTq5sqGLnosiJPGxUmCj57N41rDiu/9JZPYu0LoW ufGALyQ6MpfWRjrkK1ZrmVEPPgKBNLJoj4WmZ59w+SKYaNMIo4hGLueAQRa9+zqgeejcrVkwFtT prI3GYHdXj/ViR6cEFp9Q+Q6SEaO5q/16im90GzyeRBvsNG3D+j5aFdtUvo2x+98PZMo8JzeEQ= = X-Received: by 2002:a37:c9:: with SMTP id t70-v6mr1446856qkg.235.1531835420276; Tue, 17 Jul 2018 06:50:20 -0700 (PDT) X-Received: by 2002:a37:c9:: with SMTP id t70-v6mr1446816qkg.235.1531835419689; Tue, 17 Jul 2018 06:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531835419; cv=none; d=google.com; s=arc-20160816; b=OOY/R64vfvNZ+3AajVnl2H9+5GGoIbiVrt+y6tPulJq7E8uQLyXM4GoJ2E9pcOJs04 bqIbuoSd2xVsU9d3UuTGufURXeXAtr5HB0+DXB4z92jEeAZ9Btph2dlxgSQKNBRAycwx 9zDtA6uADm9xMzxU46pE5e7u3Jt3UQullmpcLedRXgObVTqe6dwqdPihXIPMGiufXHhk x0iD+wQYJDeXEbiHp9jR3c91OVGz5b3DZ4tweGNE837xMmQNATytLLQaM73s+8tSfXxK ZhqrCbLIv2V5DKSvr5aTGhCh1zxV9yphq2z9hNr6nu8bpJckhurAlR7muShV3kYat1Fw KWqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature:arc-authentication-results; bh=bkiErPspo3EK2aWCWuIgKpEXyXDS844E5uOtyP7WDm4=; b=eMWkHH4NaISz1qOh6N3rKeG1LX+E26mGL12xFuhR3nqqbFwKK8zkLiXfFSP8ouyfbF qQ8AtloYMb8OrlPm00eXSr/HV+q3iZPChP2mpTqePKCRcQSuf1oFSjnVhAbYyhV/6ptG pKPxxJfRyTZCog9HbSifIJb+SdjgZ9UjR3yVuoQtwQ84AQ9tVTiR5HV40mD/bDl9ZpTp +y75NYMbCKS/kyOiu+4pHUI0eLTu6ySqQiVT7F9uSTx4dftt53VLcKrEeHNosDGEjEiA 5RSUJnvzxPqZdLYUtIRGdd32JvrgaqW1F/fvtRRyV4AGIQr8xR2gmJcuA2BlMhq/IPgl 2S0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HfS2XKxN; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 28-v6sor481537qvt.118.2018.07.17.06.50.19 for (Google Transport Security); Tue, 17 Jul 2018 06:50:19 -0700 (PDT) Received-SPF: pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HfS2XKxN; spf=pass (google.com: domain of ram.n.pai@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=ram.n.pai@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=bkiErPspo3EK2aWCWuIgKpEXyXDS844E5uOtyP7WDm4=; b=HfS2XKxNPxPsuMN7olnl9D7N7E1FcAtlUUQXtvdgbIGWP4B/Q5ZUqEJqQKGVZR52X7 0i8PcPHL9ujQnrIiKnyZSJAEcDI9mA/xH6afZ+YxvkEagkSScbbJLEW+gSILdV92IBWT fPuqkzbEvJQmgodSYwADc5dfbXCwGjdVum8vaTOZiMjBMUvgWn6qenGN3aId69wXocZd M1zOMNYLLzBFpyXmimi/gsGYJ511sZk/7w0sL+hWJ9ZUdEf7siLZ++oNTMUEqPFypzjN eXAN3vuEBYQyrUtkCNt1tvNFiS0pJd5OIgfkqGDhf4lTsymWtARRyDcq/DA6rO3ne+Ob m19A== X-Google-Smtp-Source: AAOMgpdCFH5vXkl8g1AUeU0wUYoJ/lWPLGWFF+ldXbI4f48fy7Pe5DeGdg3ObUODJwW9st2DlFVT5w== X-Received: by 2002:a0c:ac85:: with SMTP id m5-v6mr1769565qvc.197.1531835419515; Tue, 17 Jul 2018 06:50:19 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id s83-v6sm640937qki.20.2018.07.17.06.50.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jul 2018 06:50:19 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v14 08/22] selftests/vm: fix the wrong assert in pkey_disable_set() Date: Tue, 17 Jul 2018 06:49:11 -0700 Message-Id: <1531835365-32387-9-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> References: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP If the flag is 0, no bits will be set. Hence we cant expect the resulting bitmap to have a higher value than what it was earlier. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index fb7dd32..2dd94c3 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -415,7 +415,7 @@ void pkey_disable_set(int pkey, int flags) dprintf1("%s(%d) pkey_reg: 0x"PKEY_REG_FMT"\n", __func__, pkey, read_pkey_reg()); if (flags) - pkey_assert(read_pkey_reg() > orig_pkey_reg); + pkey_assert(read_pkey_reg() >= orig_pkey_reg); dprintf1("END<---%s(%d, 0x%x)\n", __func__, pkey, flags); }