From patchwork Wed Jul 18 23:21:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 10533439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A3F0F6020A for ; Wed, 18 Jul 2018 23:22:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 952C2295E4 for ; Wed, 18 Jul 2018 23:22:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 87B5A297AD; Wed, 18 Jul 2018 23:22:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 859FE295E4 for ; Wed, 18 Jul 2018 23:22:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 869756B026C; Wed, 18 Jul 2018 19:22:53 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 819E26B026D; Wed, 18 Jul 2018 19:22:53 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 709DD6B026E; Wed, 18 Jul 2018 19:22:53 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id 2ACD96B026C for ; Wed, 18 Jul 2018 19:22:53 -0400 (EDT) Received: by mail-pf0-f197.google.com with SMTP id t78-v6so2986350pfa.8 for ; Wed, 18 Jul 2018 16:22:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=DPSub3SJpQj4oCRb/e9cLM3sK7h0cGQYJufjp0WjAOU=; b=ej7RJ7vQQLVMXhW611c279jdRxuTamIPcLh/KdmP0bxpwmfX9Evc4nm+5vYSdpikaS g4lsdgt1PcmCwZzPaMtC6wJQ8QpCwPneQh4QXzo3a/5tVCXsaNcqSIkLAFgWmWea88Fe Bh/o6iTgKedgle1nE4WkudUdaEuPS9E1OFkDdw/rokQ3zG0LkYvm/UvacxIXiF+A7g2f 3wmuENzIOzfSv1ldgC0ko2y8pWwonkQg36DY48745IMAL6Y1ZWRjrs1TP4PrzAetezhJ wKSefNYWPbWO1LJWW/HEXAH3+KdF5bqJ0Fo8XK87w6+nByvKuEC4e8TxBB7ixS6kQsQT DAQA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of yang.shi@linux.alibaba.com designates 47.88.44.36 as permitted sender) smtp.mailfrom=yang.shi@linux.alibaba.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alibaba.com X-Gm-Message-State: AOUpUlEedQ0NQRVcSuJQ6d4Maw3+3532hhWy7lZ3RCDcJpA9KZbKXpOq PbRtt6v2o9DaJlm7fgklg9eG7RoWoWT+y5pMVGFlNdTG0w+tQsE3V/NiAKTrPvFh4Zo3qGF9K44 oudowYBW+fzlSK75QkE8iF75MB14GoWeMLY1ycEKeNiLu/WQTu0S48K/8L1aeJKO+Uw== X-Received: by 2002:a65:6455:: with SMTP id s21-v6mr7389684pgv.394.1531956172852; Wed, 18 Jul 2018 16:22:52 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcdhH1h2cwKq/kv+d9FhE/FySPIeI8qSPjBvf7fcGcbsyXfwk8GtMlNoaVA0PBu9YYGrgQU X-Received: by 2002:a65:6455:: with SMTP id s21-v6mr7389649pgv.394.1531956171971; Wed, 18 Jul 2018 16:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531956171; cv=none; d=google.com; s=arc-20160816; b=j+5cxH5LyLj6O+MjilHsRAkqFT3GPyOVCijRTnNjuDT18KrNWIIg33mPX1inmH1Syt DN24VbfU0c7HLIdyxTHZagh/ab5GpGycgvq4XdLnLnstXXpnruYC0LmeuMoCPgj5ISJt WmMLuaQcsajI0TpuMAr6cOLonUB3aJbRHoIkbrNl1JRqh+tLxzMYTpDYznZnSxeIPvU2 RKiRMzn9OwtcgNMBSiVweAomZSXRCyrX1lgllNjRC7oEeJd+jFnB3R/rO+kyzOhG33/I c7lAvDSyKEycYdyI+BFwr8edIO3IQ4lCPeU7DbISCyzBD6a8S6CwIEzI9FprQRxOC9Eq wHOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=DPSub3SJpQj4oCRb/e9cLM3sK7h0cGQYJufjp0WjAOU=; b=w1f88glDsO8f9hHmAiXNnfuFNdbuhhPc1oHYfJ9t8vr2SnEi1jQg2NIlKv03VJGJEf mi++gLfNz5kfaty/rgVwkXkUH9YaTzsMEA61oeoh4EID9JEwxXuwyVMxfzzN29tbnZaT /gnO+DyxJktXRrXe5/LUaS3s/P/mBpf68R2V6foNdONh6gBnOQ3fAq+L1Mg9yTbiEB4M qB8TSAv5w77N4fkMpxTEJaO0/U/OKqf3ks5YxiWZ6HYhFw+a1xBhL0TSdLomVJdMxQYM iLTHVnTDknKGglpxhgfP4Yw41wZPY/k4tGiJmTCSJs0VOHc81tze4vD9cbSCRFOc1UoA FNfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of yang.shi@linux.alibaba.com designates 47.88.44.36 as permitted sender) smtp.mailfrom=yang.shi@linux.alibaba.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com. [47.88.44.36]) by mx.google.com with ESMTPS id h90-v6si3471921plb.484.2018.07.18.16.22.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 16:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of yang.shi@linux.alibaba.com designates 47.88.44.36 as permitted sender) client-ip=47.88.44.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of yang.shi@linux.alibaba.com designates 47.88.44.36 as permitted sender) smtp.mailfrom=yang.shi@linux.alibaba.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alibaba.com X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e07488; MF=yang.shi@linux.alibaba.com; NM=1; PH=DS; RN=8; SR=0; TI=SMTPD_---0T4tyslE_1531956127; Received: from e19h19392.et15sqa.tbsite.net(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0T4tyslE_1531956127) by smtp.aliyun-inc.com(127.0.0.1); Thu, 19 Jul 2018 07:22:15 +0800 From: Yang Shi To: mhocko@kernel.org, willy@infradead.org, ldufour@linux.vnet.ibm.com, kirill@shutemov.name, akpm@linux-foundation.org Cc: yang.shi@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC v5 PATCH 1/2] mm: refactor do_munmap() to extract the common part Date: Thu, 19 Jul 2018 07:21:40 +0800 Message-Id: <1531956101-8526-2-git-send-email-yang.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1531956101-8526-1-git-send-email-yang.shi@linux.alibaba.com> References: <1531956101-8526-1-git-send-email-yang.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Introduces three new helper functions: * munmap_addr_sanity() * munmap_lookup_vma() * munmap_mlock_vma() They will be used by do_munmap() and the new do_munmap with zapping large mapping early in the later patch. There is no functional change, just code refactor. Signed-off-by: Yang Shi --- mm/mmap.c | 120 ++++++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 82 insertions(+), 38 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index d1eb87e..2504094 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2686,34 +2686,44 @@ int split_vma(struct mm_struct *mm, struct vm_area_struct *vma, return __split_vma(mm, vma, addr, new_below); } -/* Munmap is split into 2 main parts -- this part which finds - * what needs doing, and the areas themselves, which do the - * work. This now handles partial unmappings. - * Jeremy Fitzhardinge - */ -int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, - struct list_head *uf) +static inline bool munmap_addr_sanity(unsigned long start, size_t len) { - unsigned long end; - struct vm_area_struct *vma, *prev, *last; - if ((offset_in_page(start)) || start > TASK_SIZE || len > TASK_SIZE-start) - return -EINVAL; + return false; - len = PAGE_ALIGN(len); - if (len == 0) - return -EINVAL; + if (PAGE_ALIGN(len) == 0) + return false; + + return true; +} + +/* + * munmap_lookup_vma: find the first overlap vma and split overlap vmas. + * @mm: mm_struct + * @vma: the first overlapping vma + * @prev: vma's prev + * @start: start address + * @end: end address + * + * returns 1 if successful, 0 or errno otherwise + */ +static int munmap_lookup_vma(struct mm_struct *mm, struct vm_area_struct **vma, + struct vm_area_struct **prev, unsigned long start, + unsigned long end) +{ + struct vm_area_struct *tmp, *last; /* Find the first overlapping VMA */ - vma = find_vma(mm, start); - if (!vma) + tmp = find_vma(mm, start); + if (!tmp) return 0; - prev = vma->vm_prev; - /* we have start < vma->vm_end */ + + *prev = tmp->vm_prev; + + /* we have start < vma->vm_end */ /* if it doesn't overlap, we have nothing.. */ - end = start + len; - if (vma->vm_start >= end) + if (tmp->vm_start >= end) return 0; /* @@ -2723,7 +2733,7 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, * unmapped vm_area_struct will remain in use: so lower split_vma * places tmp vma above, and higher split_vma places tmp vma below. */ - if (start > vma->vm_start) { + if (start > tmp->vm_start) { int error; /* @@ -2731,13 +2741,14 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, * not exceed its limit; but let map_count go just above * its limit temporarily, to help free resources as expected. */ - if (end < vma->vm_end && mm->map_count >= sysctl_max_map_count) + if (end < tmp->vm_end && + mm->map_count > sysctl_max_map_count) return -ENOMEM; - error = __split_vma(mm, vma, start, 0); + error = __split_vma(mm, tmp, start, 0); if (error) return error; - prev = vma; + *prev = tmp; } /* Does it split the last one? */ @@ -2747,7 +2758,48 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, if (error) return error; } - vma = prev ? prev->vm_next : mm->mmap; + + *vma = *prev ? (*prev)->vm_next : mm->mmap; + + return 1; +} + +static inline void munmap_mlock_vma(struct vm_area_struct *vma, + unsigned long end) +{ + struct vm_area_struct *tmp = vma; + + while (tmp && tmp->vm_start < end) { + if (tmp->vm_flags & VM_LOCKED) { + vma->vm_mm->locked_vm -= vma_pages(tmp); + munlock_vma_pages_all(tmp); + } + tmp = tmp->vm_next; + } +} + +/* Munmap is split into 2 main parts -- this part which finds + * what needs doing, and the areas themselves, which do the + * work. This now handles partial unmappings. + * Jeremy Fitzhardinge + */ +int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, + struct list_head *uf) +{ + unsigned long end; + struct vm_area_struct *vma = NULL, *prev; + int ret = 0; + + if (!munmap_addr_sanity(start, len)) + return -EINVAL; + + len = PAGE_ALIGN(len); + + end = start + len; + + ret = munmap_lookup_vma(mm, &vma, &prev, start, end); + if (ret != 1) + return ret; if (unlikely(uf)) { /* @@ -2759,24 +2811,16 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, * split, despite we could. This is unlikely enough * failure that it's not worth optimizing it for. */ - int error = userfaultfd_unmap_prep(vma, start, end, uf); - if (error) - return error; + ret = userfaultfd_unmap_prep(vma, start, end, uf); + if (ret) + return ret; } /* * unlock any mlock()ed ranges before detaching vmas */ - if (mm->locked_vm) { - struct vm_area_struct *tmp = vma; - while (tmp && tmp->vm_start < end) { - if (tmp->vm_flags & VM_LOCKED) { - mm->locked_vm -= vma_pages(tmp); - munlock_vma_pages_all(tmp); - } - tmp = tmp->vm_next; - } - } + if (mm->locked_vm) + munmap_mlock_vma(vma, end); /* * Remove the vma's, and unmap the actual pages