| Message ID | 1532561657-98783-1-git-send-email-jiang.biao2@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/vmscan: fix page_freeze_refs in comment. | expand |
On Thu 26-07-18 07:34:17, Jiang Biao wrote: > page_freeze_refs has already been relplaced by page_ref_freeze, but > it is not modified in the comment. Hmm $ git grep page_refs_freeze origin/master $ The same is the case in the linux-next tree. Which tree are you looking at? > > Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn> > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 03822f8..d29e207 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -744,7 +744,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page, > refcount = 2; > if (!page_ref_freeze(page, refcount)) > goto cannot_free; > - /* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */ > + /* note: atomic_cmpxchg in page_refs_freeze provides the smp_rmb */ > if (unlikely(PageDirty(page))) { > page_ref_unfreeze(page, refcount); > goto cannot_free; > -- > 2.7.4 >
Hi, > On Thu 26-07-18 07:34:17, Jiang Biao wrote: >> page_freeze_refs has already been relplaced by page_ref_freeze, but >> it is not modified in the comment. > > Hmm > $ git grep page_refs_freeze origin/master > $ > > The same is the case in the linux-next tree. Which tree are you looking at? I'm sorry, it should be *page_ref_freeze*, I misspelled the word. And I checked again with git grep, found there are other places with the same problem. # git grep page_freeze_refs master master:mm/ksm.c: * however, it might mean that the page is under page_freeze_refs(). master:mm/memory-failure.c: * that may make page_freeze_refs()/page_unfreeze_refs() mismatch. master:mm/vmscan.c: /* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */ I'll send v2 to fix all of these. Thanks. Jiang, Regards
diff --git a/mm/vmscan.c b/mm/vmscan.c index 03822f8..d29e207 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -744,7 +744,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page, refcount = 2; if (!page_ref_freeze(page, refcount)) goto cannot_free; - /* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */ + /* note: atomic_cmpxchg in page_refs_freeze provides the smp_rmb */ if (unlikely(PageDirty(page))) { page_ref_unfreeze(page, refcount); goto cannot_free;
page_freeze_refs has already been relplaced by page_ref_freeze, but it is not modified in the comment. Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn> --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)