From patchwork Tue Aug 7 10:24:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 10558495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A33D214E2 for ; Tue, 7 Aug 2018 10:24:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91C3C2876D for ; Tue, 7 Aug 2018 10:24:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85A2D295FC; Tue, 7 Aug 2018 10:24:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0452F2876D for ; Tue, 7 Aug 2018 10:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DE766B0010; Tue, 7 Aug 2018 06:24:41 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8B8A36B0269; Tue, 7 Aug 2018 06:24:41 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72E4F6B026A; Tue, 7 Aug 2018 06:24:41 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id 10A446B0010 for ; Tue, 7 Aug 2018 06:24:41 -0400 (EDT) Received: by mail-ed1-f71.google.com with SMTP id h26-v6so5231716eds.14 for ; Tue, 07 Aug 2018 03:24:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=CgXuHB8EAyChjzpchaoLpHvByk+29my3cusk73ts4gs=; b=LRKpWAhUUygpi4xMjzJORs/IxK0uJPJJz96AunWvgaR0W+C5ddr55fieCN1d+xl8ti jNQ4t9poCDu3VOBHSM4vafc1K6i48Tk84/j91LPK1Hes6sbzb/91vv3aXkZWT3Gt/Y3q weQ3weUh/p/iV9J5rytx2IDxH7gYPUhuA0Mgc2H2kt47XnaMVxtE2hcoKzWApPHqaaIW 4r/JVnwWj5YD3IGA4gbgc3PCxWVfRCqcUHR6tBOZ7cJMWETQNZ3hhu0iTo13Hc7L/gcm x5Nws7AO3wcTYlIOYbaxMZXec367aRgkt6uZHgU+m7hExSBKaIfTtm/udldEFAnS8X+3 bVbA== X-Gm-Message-State: AOUpUlGzrEhSOiGTUFpQqlaWYV87q2OqdV6BQjFj1TNLwBbk4aO+6xfL +rfxc0UWdvvO95dbCysIiZRsa+ef1Zqug/In5WAbvnVn03ugg8gKgUgWVKKUpDVBXz08Y74DOdL Y31JXVKb1wE+2nwToddfnbAZ/jZIFUJ+MbbFqTqa/HSzV406nDG330fZsKxGOvSyO/g== X-Received: by 2002:a50:8a9b:: with SMTP id j27-v6mr22250953edj.36.1533637480577; Tue, 07 Aug 2018 03:24:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdt6SETBPjlxB4g4bd3clHrRTQs+kStWDgROJEK6Fxpt8iCLk5ydeVHvH0T/twmMI8i9xbN X-Received: by 2002:a50:8a9b:: with SMTP id j27-v6mr22250910edj.36.1533637479826; Tue, 07 Aug 2018 03:24:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533637479; cv=none; d=google.com; s=arc-20160816; b=WUJY+mntzEkDHKdouykz7Y9XB+QbQ7RVzKu0j3tUjax7Ka6hlBENrWpTS8wc851xgc pccqlF7fG4fB9mX4XI1ecQPNJgY0a9lqECyynwT89X4+NFG7EQJbPp65kEV4XbUjq/ok MI2e+tI3JZr+7FHok1991vPOeFxt1pYtxYOdwVEATFNApJOeauo4mv4U1KtYC5lgq/zT XH177L+sgwD7d8qmQazaLQLAl5EDwdTfOcFIXBuDvfKB0DMZfeX/2+Nb1cC2QzJyxuen jaIveSwjCmorsGGNc8prU+knGmvEiFWPYqq7L+Py8bQFeIUSHWIRxOxZSwA5hjhvSumM ucYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=CgXuHB8EAyChjzpchaoLpHvByk+29my3cusk73ts4gs=; b=YcICneMlbOGOOGlyDKRH92xUd6kFbRWNPSRLNr/4t5fI4HvmGtjxz1JTovAfXziLTp qQvz6funjwJ2/dHBHVfbZECjdaWnpEdbjzsQCWlHIq+v1mT+pu5jqkcdP88Q9dISXMNS AeaDyru/rtezVv8EtIbfhHSYGV90IYc4RJYamVH40TbORFhxKgmvsu77ScBYuvOWWDU4 2K7tDt1wRuQgxxXT/SBIFDPI/t7k2h8Ga91kS8GPZRt8elxuygtx1CRgGTzHZ4Cop8j/ CmfOH7rsKZiaokWw6teX204s+Ro83aca8susddO/lpDZbWv7h8S47S1qyA2pUl5aSHnn 5UcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@8bytes.org header.s=mail-1 header.b="VHlI/Dgv"; spf=pass (google.com: domain of joro@8bytes.org designates 81.169.241.247 as permitted sender) smtp.mailfrom=joro@8bytes.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: from theia.8bytes.org (8bytes.org. [81.169.241.247]) by mx.google.com with ESMTPS id e17-v6si1142776edd.409.2018.08.07.03.24.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Aug 2018 03:24:39 -0700 (PDT) Received-SPF: pass (google.com: domain of joro@8bytes.org designates 81.169.241.247 as permitted sender) client-ip=81.169.241.247; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@8bytes.org header.s=mail-1 header.b="VHlI/Dgv"; spf=pass (google.com: domain of joro@8bytes.org designates 81.169.241.247 as permitted sender) smtp.mailfrom=joro@8bytes.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: by theia.8bytes.org (Postfix, from userid 1000) id 3DE37104; Tue, 7 Aug 2018 12:24:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1533637473; bh=pP6jz/NH1jJ0hu79SobCkHNyMx40HjebERdE/5PdW6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VHlI/DgvOQCLTd7lAb7YKFYn32xIdw+7LS20gUYhndOCcDGH6D5uFn/MIEloLZMYu Ebh1dAF2UkjGRBIvefLD+7+Ewie09E4anS30Vcvrtgj6t+SZ/4AmghbSVPPOFYcBsi xXK8iq6Qi/V30ICrkxlxHk327LF6UagNIwyAHogS0Qsb9Fp0/ub1zp9I0fLErUVo3W GMXDzgxM79cj3j8MIHM8beOVlBBxMpYJA4kGNl6uR1hliGGff5i9UaYwTabdbQq4um t6kgF8AIvQ1Us58vligIqp1nn0EBaFLlfSkQ8l7vQSplhnLZ63FYuMpb5mk9qraL0L Lz4s1gOqISh/A== From: Joerg Roedel To: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , aliguori@amazon.com, daniel.gruss@iaik.tugraz.at, hughd@google.com, keescook@google.com, Andrea Arcangeli , Waiman Long , Pavel Machek , "David H . Gutteridge" , jroedel@suse.de, joro@8bytes.org Subject: [PATCH 1/3] x86/mm/pti: Fix 32 bit PCID check Date: Tue, 7 Aug 2018 12:24:29 +0200 Message-Id: <1533637471-30953-2-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533637471-30953-1-git-send-email-joro@8bytes.org> References: <1533637471-30953-1-git-send-email-joro@8bytes.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Joerg Roedel The check uses the wrong operator and causes false positive warnings in the kernel log on some systems. Fixes: 5e8105950a8b3 ('x86/mm/pti: Add Warning when booting on a PCID capable CPU') Signed-off-by: Joerg Roedel --- arch/x86/mm/pti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c index ef8db6f..113ba14 100644 --- a/arch/x86/mm/pti.c +++ b/arch/x86/mm/pti.c @@ -549,7 +549,7 @@ void __init pti_init(void) * supported on 32 bit anyway. To print the warning we need to * check with cpuid directly again. */ - if (cpuid_ecx(0x1) && BIT(17)) { + if (cpuid_ecx(0x1) & BIT(17)) { /* Use printk to work around pr_fmt() */ printk(KERN_WARNING "\n"); printk(KERN_WARNING "************************************************************\n");