From patchwork Thu Aug 16 07:50:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Wang X-Patchwork-Id: 10567145 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 14052913 for ; Thu, 16 Aug 2018 08:19:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00FAE2A903 for ; Thu, 16 Aug 2018 08:19:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E80182A9F4; Thu, 16 Aug 2018 08:19:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A61C2A903 for ; Thu, 16 Aug 2018 08:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 720A56B0008; Thu, 16 Aug 2018 04:19:19 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6D3486B000A; Thu, 16 Aug 2018 04:19:19 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 523876B000C; Thu, 16 Aug 2018 04:19:19 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id 110006B0008 for ; Thu, 16 Aug 2018 04:19:19 -0400 (EDT) Received: by mail-pf1-f200.google.com with SMTP id s1-v6so1756999pfm.22 for ; Thu, 16 Aug 2018 01:19:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=x+seWkwiIxvEy5cmffWwaiNSR7aMSGBbO+X8pExKk58=; b=oQ5/bXWf/eUXtn/tCRp7r55YoWtGoYGJwihtMos6tGaWjYz2IIc0KC3WmflCa9za2J jv0PkoZMRaeBLUKd+HRYXrygTsSGgw06l8ssh/Ry75Jj/TvlaQQ56d2cZqdRn+/VpkQG oAYuBiLz/1AHwXZgrEV+hn/c5DUeVymVcHJB/z/2W7Dr4x5LVeI4HPDxWTEJ9uygOBym xNhHkuM3zWTBuu4c6/mUSMvw/eUd88WPea05Qv61AofDOwREU6WsCDIgBk6/2WfkkAca 0mxCpB11wf7G3fePqH0zkX+3cGeD96+lR/bqid3e3nac7baBXNEn1wmozt+BYmURRnY8 wRLw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of wei.w.wang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=wei.w.wang@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: AOUpUlFqTkc37iBL9vKJlb794Odpj6xjPA0XFhY+WKzwmCJLb5Xcz8Hp +9EeyVWZvzYkNUqkskKeuJHBBkmkzKBomn7bFMj3Nk9pSBGJD1kIUHS0HX8X2i+asUjtA+ymxXp a6feIr4rk0mVf3URHev5U/8mSobj7GpALxJ5KcdTnxGIABUlaoLs5QxsttkysV13D7w== X-Received: by 2002:aa7:86d7:: with SMTP id h23-v6mr31250179pfo.132.1534407558662; Thu, 16 Aug 2018 01:19:18 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzsehyGGfwDMhfNgnI57Ybnhk5HY5G/6dRKJgE/WNxbv8TVJdLm98NXXADbv34ELJJtPkTu X-Received: by 2002:aa7:86d7:: with SMTP id h23-v6mr31250122pfo.132.1534407557532; Thu, 16 Aug 2018 01:19:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534407557; cv=none; d=google.com; s=arc-20160816; b=CsxxMJsxoRL5IKGCaqW90+r1QDOvzlBXQ7iFgDrr9AFCvUAJzeLr49v3RvVD1CfoNe ld6GKBimSXLlSNu5MJhBXlib6mJu32Mnjs1i7l9GhJQNlRWC/Hja/tn1+CrEI910jvz2 zxoUDIaT7E6y4oNIN6GVY6V6oRJwlu5ugoMl6jI03fK5VP0BGV06n90pqBsEcuwLLU9A J2RXwkbnrIteAeqGezNqc9TS4WseshKGnEll9bXZxkbFm8bZdYVB6eBu17EESH4JRoGl 9ilkFGf3lHtuZct8SHx+KU6Z6fUneeQcJ5pySl+bqW/uPrtioPbKCATkhnHESyFOhg5O CNZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=x+seWkwiIxvEy5cmffWwaiNSR7aMSGBbO+X8pExKk58=; b=xeM2OCkLUDsmWbOYltWA39H71+oPAfTbUIRgvWFrGXGFSJbCZ3ETKaKrFKaSVWT1Sx kvL6pcQsF7ifUvUT02gUR4Dg/Gebqqn4iaBxuSae7SVsKQ6+td/cq1yM+ZCtKZZQyP1E zZXheWYC9T0+wBpu/2cfnMwIZBXfcM1w6Kw+g77dbi46h5mGGd/DdSjAEP7TOJFKqLHx 8IR6se0adO866NBkCk6s6x+wZdKqSnLvQ/MTXSKOKpHzcfxEV6kY1JxGyqjVelzChNKG DhpmFZBSQxeAt5gQ111uEuQ9+O+wUPtIOwy+sABAoIUvkj9spbzcmBdszN9/qdyC5tWT 5rSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of wei.w.wang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=wei.w.wang@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga07.intel.com (mga07.intel.com. [134.134.136.100]) by mx.google.com with ESMTPS id t7-v6si21504807pgp.18.2018.08.16.01.19.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 01:19:17 -0700 (PDT) Received-SPF: pass (google.com: domain of wei.w.wang@intel.com designates 134.134.136.100 as permitted sender) client-ip=134.134.136.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of wei.w.wang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=wei.w.wang@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2018 01:19:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,246,1531810800"; d="scan'208";a="83781743" Received: from devel-ww.sh.intel.com ([10.239.48.110]) by orsmga002.jf.intel.com with ESMTP; 16 Aug 2018 01:19:15 -0700 From: Wei Wang To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, penguin-kernel@I-love.SAKURA.ne.jp Cc: wei.w.wang@intel.com Subject: [PATCH v4 2/3] virtio-balloon: kzalloc the vb struct Date: Thu, 16 Aug 2018 15:50:57 +0800 Message-Id: <1534405858-27085-3-git-send-email-wei.w.wang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1534405858-27085-1-git-send-email-wei.w.wang@intel.com> References: <1534405858-27085-1-git-send-email-wei.w.wang@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Zero all the vb fields at alloaction, so that we don't need to zero-initialize each field one by one later. Signed-off-by: Wei Wang Cc: Michael S. Tsirkin Cc: Tetsuo Handa --- drivers/virtio/virtio_balloon.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 8100e77..d97d73c 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -561,7 +561,7 @@ static int virtballoon_probe(struct virtio_device *vdev) return -EINVAL; } - vdev->priv = vb = kmalloc(sizeof(*vb), GFP_KERNEL); + vdev->priv = vb = kzalloc(sizeof(*vb), GFP_KERNEL); if (!vb) { err = -ENOMEM; goto out; @@ -570,8 +570,6 @@ static int virtballoon_probe(struct virtio_device *vdev) INIT_WORK(&vb->update_balloon_stats_work, update_balloon_stats_func); INIT_WORK(&vb->update_balloon_size_work, update_balloon_size_func); spin_lock_init(&vb->stop_update_lock); - vb->stop_update = false; - vb->num_pages = 0; mutex_init(&vb->balloon_lock); init_waitqueue_head(&vb->acked); vb->vdev = vdev; @@ -602,7 +600,6 @@ static int virtballoon_probe(struct virtio_device *vdev) err = PTR_ERR(vb->vb_dev_info.inode); kern_unmount(balloon_mnt); unregister_oom_notifier(&vb->nb); - vb->vb_dev_info.inode = NULL; goto out_del_vqs; } vb->vb_dev_info.inode->i_mapping->a_ops = &balloon_aops;