From patchwork Thu Aug 16 11:57:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 10567363 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D99FB13B4 for ; Thu, 16 Aug 2018 11:57:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C771528A71 for ; Thu, 16 Aug 2018 11:57:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BAD432ABB5; Thu, 16 Aug 2018 11:57:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3644528A71 for ; Thu, 16 Aug 2018 11:57:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 591A56B000D; Thu, 16 Aug 2018 07:57:46 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 541236B000E; Thu, 16 Aug 2018 07:57:46 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42FA26B0010; Thu, 16 Aug 2018 07:57:46 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 031E16B000D for ; Thu, 16 Aug 2018 07:57:46 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id v15-v6so2605734ply.20 for ; Thu, 16 Aug 2018 04:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :from:date:message-id:mime-version:content-transfer-encoding; bh=7ITqOnSvthzX8DBmfAf9qrUorwF+gNnCFgSHrzoqKCo=; b=ZXDwgLjgVU8USsH7kVPwCbDua6ag+F2/+L+FJfy13jABEpWWs9MU8Q5/gtVi9Apx39 PkvzMNjP1YMNLUoUGsP9HTPjfZai24iJ5cvlUEe9HBR4c/DDroYyp7ZzYwbbSpuAdBvf GWPSA2ZEsiU+pvoO6TdDxIJRHD6eFQNLitvR5TgjYigumrQOD4JFuu0XrG2gwWgPu1/1 h3agCvCEVNcX6Nr4hfLizkTNqddmyEkTumhwK85TShbGooX7tG54JWzrqocBmdtc72GE PKeNGiCB5NysoXK8uLVzIveDYeFs3YW1/nv6SdLb9EIxkTYbV7NemmVy+zGUNHrFTxlg sXXw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Gm-Message-State: AOUpUlEP9HS6lw+q92viG79FDanWqoBceQsm4gbDvL+9/8zaPPr+GGm7 IV5cHcacEbeddpKhfOpnBCamwT15i/e5PmMuIrQCrOFstmYTTrugBAIxWgDK5M+ttOKT9V1QFf7 bAQN//oJUzuyD/pjBd2aOL8qJooAxyt/DMFcjFxzVTr/1IcPJvihAOV+ksXx3zHFf3Q== X-Received: by 2002:a62:3952:: with SMTP id g79-v6mr31958852pfa.133.1534420665694; Thu, 16 Aug 2018 04:57:45 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyrXKtZH+uDBzqZzKqTSP2ASXROEFnFAAUp/9rUJSwkkLBkRswiFkXVcL52+2SZYwvXaiAI X-Received: by 2002:a62:3952:: with SMTP id g79-v6mr31958805pfa.133.1534420664818; Thu, 16 Aug 2018 04:57:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534420664; cv=none; d=google.com; s=arc-20160816; b=OFEHmYFDOuxLAzcIVMPg8yd5wWnjjn9Y+cSwgF+xFQPhsRz7K6M1x3VXTUKCK7r8e8 9WJy0DJjQQ9a+wxj+aaoI2Hckpt8TLfQWxjNsm5nDWAC3xIxIoD6B8WgzGDbEi1xXeRa JszMKSWxuOhRZmHx0e84EOaRakenqHKU8ekMkR7jvRseIQP4ik3jTdCLs5WkGrjHS2MS Uxoh06AhWTrMiselz2yVMKjvfkFiyBPPCvU9h3RayObTIejwBUVOQhN/yS4VLZj9HcR+ zr5vjGoUYVO0JAWSSlV9WbtfHo00DBPn2w1WoUoLS79pHBzp77nMdl0MzVF4Qaf8H9cx ZduA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:from:cc:to :subject:arc-authentication-results; bh=7ITqOnSvthzX8DBmfAf9qrUorwF+gNnCFgSHrzoqKCo=; b=r+uanODXDC8BJ3SWhlX5f9++6wmvGK21fgbb0cCsMQYcoNRJReirUaOeZU8pggmZAm bEaNBGi/VMM0AgW5b7R4xCmvlxeD9ci+WQUfghieboX8Gv81+z1TiOWFAYYSiUj9+EMD pCzHZIsBfry4kE1XeJQUKG582AlKBYnJmcgGW03FeesqBoWU5DSuIeCL4PU7tbH1oZQS rJD5hz20Ve5zGzmGAg2RsvPV25Zy+tX8iU8v703dyF8ChEBOmxPoldmRJ1ooYPwonfmL vc/In1+d0mgPkuDO+N9KYxnHYDLWwf19cMuAOFESnJe4v03SyFR7FI+lTBz1CjFw7tYG Bj7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id r28-v6si25858361pgk.458.2018.08.16.04.57.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 04:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 2B127A59; Thu, 16 Aug 2018 11:57:44 +0000 (UTC) Subject: Patch "x86/mm: Disable ioremap free page handling on x86-PAE" has been added to the 4.18-stable tree To: 20180627141348.21777-2-toshi.kani@hpe.com,akpm@linux-foundation.org,cpandya@codeaurora.org,gregkh@linuxfoundation.org,hpa@zytor.com,joro@8bytes.org,linux-arm-kernel@lists.infradead.org,linux-mm@kvack.org,mhocko@suse.com,tglx@linutronix.de,toshi.kani@hpe.com Cc: From: Date: Thu, 16 Aug 2018 13:57:33 +0200 Message-ID: <1534420653141123@kroah.com> MIME-Version: 1.0 X-stable: commit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This is a note to let you know that I've just added the patch titled x86/mm: Disable ioremap free page handling on x86-PAE to the 4.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-mm-disable-ioremap-free-page-handling-on-x86-pae.patch and it can be found in the queue-4.18 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. From f967db0b9ed44ec3057a28f3b28efc51df51b835 Mon Sep 17 00:00:00 2001 From: Toshi Kani Date: Wed, 27 Jun 2018 08:13:46 -0600 Subject: x86/mm: Disable ioremap free page handling on x86-PAE From: Toshi Kani commit f967db0b9ed44ec3057a28f3b28efc51df51b835 upstream. ioremap() supports pmd mappings on x86-PAE. However, kernel's pmd tables are not shared among processes on x86-PAE. Therefore, any update to sync'd pmd entries need re-syncing. Freeing a pte page also leads to a vmalloc fault and hits the BUG_ON in vmalloc_sync_one(). Disable free page handling on x86-PAE. pud_free_pmd_page() and pmd_free_pte_page() simply return 0 if a given pud/pmd entry is present. This assures that ioremap() does not update sync'd pmd entries at the cost of falling back to pte mappings. Fixes: 28ee90fe6048 ("x86/mm: implement free pmd/pte page interfaces") Reported-by: Joerg Roedel Signed-off-by: Toshi Kani Signed-off-by: Thomas Gleixner Cc: mhocko@suse.com Cc: akpm@linux-foundation.org Cc: hpa@zytor.com Cc: cpandya@codeaurora.org Cc: linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org Cc: stable@vger.kernel.org Cc: Andrew Morton Cc: Michal Hocko Cc: "H. Peter Anvin" Cc: Link: https://lkml.kernel.org/r/20180627141348.21777-2-toshi.kani@hpe.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/mm/pgtable.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) Patches currently in stable-queue which might be from toshi.kani@hpe.com are queue-4.18/x86-mm-disable-ioremap-free-page-handling-on-x86-pae.patch --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -719,6 +719,7 @@ int pmd_clear_huge(pmd_t *pmd) return 0; } +#ifdef CONFIG_X86_64 /** * pud_free_pmd_page - Clear pud entry and free pmd page. * @pud: Pointer to a PUD. @@ -766,4 +767,22 @@ int pmd_free_pte_page(pmd_t *pmd) return 1; } + +#else /* !CONFIG_X86_64 */ + +int pud_free_pmd_page(pud_t *pud) +{ + return pud_none(*pud); +} + +/* + * Disable free page handling on x86-PAE. This assures that ioremap() + * does not update sync'd pmd entries. See vmalloc_sync_one(). + */ +int pmd_free_pte_page(pmd_t *pmd) +{ + return pmd_none(*pmd); +} + +#endif /* CONFIG_X86_64 */ #endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */