| Message ID | 1535103134-20239-1-git-send-email-n-horiguchi@ah.jp.nec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] tools/vm/slabinfo.c: fix sign-compare warning | expand |
On Fri, Aug 24, 2018 at 06:32:14PM +0900, Naoya Horiguchi wrote: > - int hwcache_align, object_size, objs_per_slab; > - int sanity_checks, slab_size, store_user, trace; > + int hwcache_align, objs_per_slab; > + int sanity_checks, store_user, trace; > int order, poison, reclaim_account, red_zone; > + unsigned int object_size, slab_size; Surely hwcache_align and objs_per_slab can't be negative either? Nor the other three. So maybe convert all seven of these variables to unsigned int?
diff --git v4.18-mmotm-2018-08-17-15-48/tools/vm/slabinfo.c v4.18-mmotm-2018-08-17-15-48_patched/tools/vm/slabinfo.c index f82c2ea..eebeeb1 100644 --- v4.18-mmotm-2018-08-17-15-48/tools/vm/slabinfo.c +++ v4.18-mmotm-2018-08-17-15-48_patched/tools/vm/slabinfo.c @@ -30,9 +30,10 @@ struct slabinfo { int alias; int refs; int aliases, align, cache_dma, cpu_slabs, destroy_by_rcu; - int hwcache_align, object_size, objs_per_slab; - int sanity_checks, slab_size, store_user, trace; + int hwcache_align, objs_per_slab; + int sanity_checks, store_user, trace; int order, poison, reclaim_account, red_zone; + unsigned int object_size, slab_size; unsigned long partial, objects, slabs, objects_partial, objects_total; unsigned long alloc_fastpath, alloc_slowpath; unsigned long free_fastpath, free_slowpath;
Currently we get the following compiler warning: slabinfo.c:854:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (s->object_size < min_objsize) ^ due to the mismatch of signed/unsigned comparison. ->object_size and ->slab_size are never expected to be negative, so let's define them as unsigned int. Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> --- tools/vm/slabinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)