Message ID | 1535666107-25699-3-git-send-email-longman@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 904F113AC for <patchwork-linux-mm@patchwork.kernel.org>; Thu, 30 Aug 2018 21:55:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8102E2BE90 for <patchwork-linux-mm@patchwork.kernel.org>; Thu, 30 Aug 2018 21:55:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 74F812C24B; Thu, 30 Aug 2018 21:55:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 164932BE90 for <patchwork-linux-mm@patchwork.kernel.org>; Thu, 30 Aug 2018 21:55:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 188876B5394; Thu, 30 Aug 2018 17:55:30 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 10D896B5395; Thu, 30 Aug 2018 17:55:30 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC9FC6B5396; Thu, 30 Aug 2018 17:55:29 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt0-f200.google.com (mail-qt0-f200.google.com [209.85.216.200]) by kanga.kvack.org (Postfix) with ESMTP id 98F7B6B5394 for <linux-mm@kvack.org>; Thu, 30 Aug 2018 17:55:29 -0400 (EDT) Received: by mail-qt0-f200.google.com with SMTP id y54-v6so10408340qta.8 for <linux-mm@kvack.org>; Thu, 30 Aug 2018 14:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=4B/Wm4vURCyVHVLH/q3jpiYPWlPN176DKvy63T1eH4Y=; b=uCDtDg1LGWxFg5kELTZwcTKS0XuhSRSBAoIwNWxe0PiQCqwkuIIAaotpZ0fg49fhd1 il5fYutn2gWd6xFNk2fGEqj1Tl7d+Kensm1UEkDU06pXrkws25tHtfaEbbZnW2dSF+lA LREeZLh1qsfopx+qH8lekduNo2shmf3brf/Pqesqrf+51VAAsgJiehYl6/2kssMyv/qV Se+qcwy8nHmCKl8fwb0D2b3/2j4DuBf/3h4RjxHvXrk1F5osw/zYM/urdfNkFKJ4/YSo R2Eo3lZK+HJtzF/d9aB6yudcFqYeBnf055JCb+xUgq5MdzyCYenzEAucv1/QX01d85+v JhtQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of longman@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APzg51CKyMLD/mLPeTCHnrD6G2knmfY92gEWTJaZOZ/4IU7uhR64ejKE KcNtaKnA4Cd8Mt6NMWEB2wk1nCjj2gIKUJ+JL7AUoFozd9+7bEi8st3rt/DMFMCia/BdLo5amVg q7+TTfmQFp3g6C4fjvpbZgVxxGvwzR+DNKD+DJEHnTnXf5ecyhWW57mmsfP8pm0G6QA== X-Received: by 2002:a37:a0c2:: with SMTP id j185-v6mr13345464qke.67.1535666129389; Thu, 30 Aug 2018 14:55:29 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ3bsP5hpL9uDmGuaIeheGePhUmZASixU/sJ5+3nkG5TJNfsKJwA+okf7thmOdJf7ZJpKDw X-Received: by 2002:a37:a0c2:: with SMTP id j185-v6mr13345443qke.67.1535666128888; Thu, 30 Aug 2018 14:55:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535666128; cv=none; d=google.com; s=arc-20160816; b=kp/HkURYR/cxeUBFGWs5AR7Q5L03e+T+MviIH5mGoC97Rj54e5D/3fgv8LS91wgTZT vsS37uZx6abmpulEsVXrLOQ15xFNyLgvgCuW0NVBCDRAGf128Au7+T+F8ndYIhhzin8T DIIy8v2jUgSLPoD4C2O2bIHOlVaqu9D3hQTZ4Xuq4YrPKbwITzGwH9KEQatKRlmUUxDl SLPR0MP6AZ9LXH40PVjf7v6gsaOWNE2Xq+fkXMj55NddLcnhNVb8vQTHfwab99TwGqIe 1qvNI5hSn4eygK1WFqCo+zmLpC7uKFJ0igcTTRJDXP6cq9R1wWz27X0f1UIcPODKclWI luNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=4B/Wm4vURCyVHVLH/q3jpiYPWlPN176DKvy63T1eH4Y=; b=D+ygVxa0HnlYP/Y+hMU3kO4/f9QVF+/puyGZYrRdUl94DrwfBF6Zu1pUuPLW2mOnDp SMbmaL94Am6zSK3rVSXurcHqlR1rTjPno7coi2vptYXUftnd9OmqlXEZCxg3FQB6rwKt A8d1j0QR8SjUc8Xk9MsqtbDD4RcfDPWx+0YJiAVfzAaPFwFH0QLGxCbNScBKZmjsUazj o37tpuTBvAGxvByeM2SkEnUt0XKulW63pUZMxRSZej8i6gWII8U1h1DiMXRnoSbiVIa8 rXTlqWsdnVC6LEXbHcB30H26yw3QYUertyN5iPrcS937TumkNFGiBJxxiM0jpG1aDpVS 2Cvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of longman@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id 14-v6si7913924qvj.188.2018.08.30.14.55.28 for <linux-mm@kvack.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 14:55:28 -0700 (PDT) Received-SPF: pass (google.com: domain of longman@redhat.com designates 66.187.233.73 as permitted sender) client-ip=66.187.233.73; Authentication-Results: mx.google.com; spf=pass (google.com: domain of longman@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A91640216E7; Thu, 30 Aug 2018 21:55:28 +0000 (UTC) Received: from llong.com (dhcp-17-8.bos.redhat.com [10.18.17.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE6BD2157F4A; Thu, 30 Aug 2018 21:55:27 +0000 (UTC) From: Waiman Long <longman@redhat.com> To: Alexander Viro <viro@zeniv.linux.org.uk>, Jonathan Corbet <corbet@lwn.net> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, "Luis R. Rodriguez" <mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>, Linus Torvalds <torvalds@linux-foundation.org>, Jan Kara <jack@suse.cz>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, Miklos Szeredi <mszeredi@redhat.com>, Matthew Wilcox <willy@infradead.org>, Larry Woodman <lwoodman@redhat.com>, James Bottomley <James.Bottomley@HansenPartnership.com>, "Wangkai (Kevin C)" <wangkai86@huawei.com>, Michal Hocko <mhocko@kernel.org>, Waiman Long <longman@redhat.com> Subject: [PATCH v2 2/4] fs: Don't need to put list_lru into its own cacheline Date: Thu, 30 Aug 2018 17:55:05 -0400 Message-Id: <1535666107-25699-3-git-send-email-longman@redhat.com> In-Reply-To: <1535666107-25699-1-git-send-email-longman@redhat.com> References: <1535666107-25699-1-git-send-email-longman@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 30 Aug 2018 21:55:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 30 Aug 2018 21:55:28 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'longman@redhat.com' RCPT:'' X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
fs/dcache: Track # of negative dentries
|
expand
|
diff --git a/include/linux/fs.h b/include/linux/fs.h index 3332270..fd4cd8a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1443,11 +1443,12 @@ struct super_block { struct user_namespace *s_user_ns; /* - * Keep the lru lists last in the structure so they always sit on their - * own individual cachelines. + * The list_lru structure is essentially just a pointer to a table + * of per-node lru lists, each of which has its own spinlock. + * There is no need to put them into separate cachelines. */ - struct list_lru s_dentry_lru ____cacheline_aligned_in_smp; - struct list_lru s_inode_lru ____cacheline_aligned_in_smp; + struct list_lru s_dentry_lru; + struct list_lru s_inode_lru; struct rcu_head rcu; struct work_struct destroy_work;
The list_lru structure is essentially just a pointer to a table of per-node LRU lists. Even if CONFIG_MEMCG_KMEM is defined, the list field is just used for LRU list registration and shrinker_id is set at initialization. Those fields won't need to be touched that often. So there is no point to make the list_lru structures to sit in their own cachelines. Signed-off-by: Waiman Long <longman@redhat.com> --- include/linux/fs.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)