From patchwork Tue Oct 2 11:06:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 10623363 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 541D613BB for ; Tue, 2 Oct 2018 11:06:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A5A228806 for ; Tue, 2 Oct 2018 11:06:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2E09128825; Tue, 2 Oct 2018 11:06:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B0F5B28806 for ; Tue, 2 Oct 2018 11:05:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CDCE6B026B; Tue, 2 Oct 2018 07:05:42 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 72CC66B0271; Tue, 2 Oct 2018 07:05:42 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41F196B026C; Tue, 2 Oct 2018 07:05:42 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by kanga.kvack.org (Postfix) with ESMTP id 10EB26B026A for ; Tue, 2 Oct 2018 07:05:42 -0400 (EDT) Received: by mail-oi1-f197.google.com with SMTP id q11-v6so989908oih.15 for ; Tue, 02 Oct 2018 04:05:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=5Z6J2RQTqMWhpJ0pzFttI0SwIzpZ6lRPEY1BeHTRt8o=; b=eBkzSOXpSPTqw3R1pJi8njygsDb7NZ6xRzeTfPZ0sWq51g5iAXA0PwEjeNJna1Ceys hdliKjdALMpx6FOjIp6uup9vKaEW37pSBUvaq+r36cWQy7lWz4ouTdaED8/96qk2dklB c7FvqL3x/OaGoux1Hdaqgm/S3ZOO5d0ZmeDONKuEIJQf+f0vg3ls7keusXuCur0klpnF K91bnadHNYq3O6FXOcJT0A3N0LIa/06DXKQ21Yr/sRoY2sYWYyV00itU9G/yZ6phmPIh Stb22xSSiCrC2SMLXiM9O0/Di9Ere+q2W3mZHvUiLLwr7BIkLumvSE2rNholMFCxcz7f MmXw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com X-Gm-Message-State: ABuFfoj2GzjyPNN0slmPwh64Zpk+4UuuzQu8bFvArmMXwDRRARA3V/R4 c4C9wa6MwYIPVrfUCyURsYGRkqqv6iliEdRCERyoMiANovkLy9VtDC9WM5LaITSXZEOCeaDGguU LqAh5/JsVkBKil6UPcOw1uWHR5JTdKrIAD5HpWhvP2M1kSOj6JTReI8ouY1FDv3Kiog== X-Received: by 2002:aca:cc92:: with SMTP id c140-v6mr6318560oig.28.1538478341860; Tue, 02 Oct 2018 04:05:41 -0700 (PDT) X-Google-Smtp-Source: ACcGV62SBZ3VvNFT5uehW8hR72cpUPP1xNme1sv/ONdpGz9zwzN9uO820j2yKFAIoPHN870ClKqO X-Received: by 2002:aca:cc92:: with SMTP id c140-v6mr6318526oig.28.1538478341018; Tue, 02 Oct 2018 04:05:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538478340; cv=none; d=google.com; s=arc-20160816; b=ufaOp618G3NafzEqncTNIViQQe7tOuIry04Ru0BnFJVVczga0z1cjZJz509IG73qm8 sMXMXHJBlxIpRkakqYWWAkTUkmo3BwW/pl3k1jld72lhAsJTop8gumSpAeXVfZhMBrGW /1cUG4P4BftTEE+hgezNDEhI/yCxAkbZln6EpbC0tpV4bDzSxbc/9Xwcm3EVrZeWNyJV j1n3orgbvgLuplzkjqHPeQtO6oGaSZ4KhsTeVVkUtmJjTk3FsEMPSu9TJbWPLIBLkVw5 Vj/ji33ps0tNbbOPsNXFmMlzu2Px7SkUwm7n5+bRwyniv4d4XN0fDicEtID3DhQqft/o dAog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=5Z6J2RQTqMWhpJ0pzFttI0SwIzpZ6lRPEY1BeHTRt8o=; b=ys955jqQKbkIENB8uVhootQqbmeoeTW/nvHbt2vYscKcvUm19PRHR+WpoE/VdHqNC4 8R7XzYYdqOUHKvpMokHG2/M/OvFt5tcEJbeyRtKHf4mIi2nL3/aacyLHwyOpi92FisET 9A5omzLUpuEkIZ0ZEFpf1BXSjWPrY2d/bWQGXFnRi93iJoWm82gyDweAj1R/GynsT8yI RcV1majwd7ZgVk21+tYYOW3JL51ege1gBeSpj+QNEWbnR8JCm8jyslV89pSNTAJHk/05 j0dHg1zW3FZq4yRYrvucLTxOJONvQj5eXtvdxVNxp9rzaJ5tS+Mu8v9fR666HA7s7vd9 Yhxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id e9-v6si4529574oif.44.2018.10.02.04.05.40 for ; Tue, 02 Oct 2018 04:05:40 -0700 (PDT) Received-SPF: pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of will.deacon@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=will.deacon@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9ABFF15BF; Tue, 2 Oct 2018 04:05:40 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6BBD53F7F4; Tue, 2 Oct 2018 04:05:40 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 5D9771AE3E55; Tue, 2 Oct 2018 12:06:04 +0100 (BST) From: Will Deacon To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: cpandya@codeaurora.org, toshi.kani@hpe.com, tglx@linutronix.de, mhocko@suse.com, akpm@linux-foundation.org, sean.j.christopherson@intel.com, Will Deacon Subject: [PATCH v2 2/5] arm64: mmu: Drop pXd_present() checks from pXd_free_pYd_table() Date: Tue, 2 Oct 2018 12:06:00 +0100 Message-Id: <1538478363-16255-3-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1538478363-16255-1-git-send-email-will.deacon@arm.com> References: <1538478363-16255-1-git-send-email-will.deacon@arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Now that the core code checks this for us, we don't need to do it in the backend. Cc: Chintan Pandya Cc: Toshi Kani Cc: Thomas Gleixner Cc: Michal Hocko Cc: Andrew Morton Signed-off-by: Will Deacon --- arch/arm64/mm/mmu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 8080c9f489c3..0dcb3354d6dd 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -985,10 +985,8 @@ int pmd_free_pte_page(pmd_t *pmdp, unsigned long addr) pmd = READ_ONCE(*pmdp); - if (!pmd_present(pmd)) - return 1; if (!pmd_table(pmd)) { - VM_WARN_ON(!pmd_table(pmd)); + VM_WARN_ON(1); return 1; } @@ -1008,10 +1006,8 @@ int pud_free_pmd_page(pud_t *pudp, unsigned long addr) pud = READ_ONCE(*pudp); - if (!pud_present(pud)) - return 1; if (!pud_table(pud)) { - VM_WARN_ON(!pud_table(pud)); + VM_WARN_ON(1); return 1; }