[23/29] xfs: add a per-xfs trace_printk macro

Message ID	153981641972.5568.6155004838582569988.stgit@magnolia (mailing list archive)
State	New, archived
Headers	show Return-Path: <owner-linux-mm@kvack.org> Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) client-ip=156.151.31.85; Subject: [PATCH 23/29] xfs: add a per-xfs trace_printk macro From: "Darrick J. Wong" <darrick.wong@oracle.com> To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Date: Wed, 17 Oct 2018 15:46:59 -0700 Message-ID: <153981641972.5568.6155004838582569988.stgit@magnolia> In-Reply-To: <153981625504.5568.2708520119290577378.stgit@magnolia> References: <153981625504.5568.2708520119290577378.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	fs: fixes for serious clone/dedupe problems \| expand [v6,00/29] fs: fixes for serious clone/dedupe problems [01/29] vfs: vfs_clone_file_prep_inodes should return EINVAL for a clone from beyond EOF [02/29] vfs: check file ranges before cloning files [03/29] vfs: exit early from zero length remap operations [04/29] vfs: strengthen checking of file range inputs to generic_remap_checks [05/29] vfs: avoid problematic remapping requests into partial EOF block [06/29] vfs: skip zero-length dedupe requests [07/29] vfs: rename vfs_clone_file_prep to be more descriptive [08/29] vfs: rename clone_verify_area to remap_verify_area [09/29] vfs: combine the clone and dedupe into a single remap_file_range [10/29] vfs: pass remap flags to generic_remap_file_range_prep [11/29] vfs: pass remap flags to generic_remap_checks [12/29] vfs: remap helper should update destination inode metadata [13/29] vfs: make remap_file_range functions take and return bytes completed [14/29] vfs: plumb remap flags through the vfs clone functions [15/29] vfs: plumb remap flags through the vfs dedupe functions [16/29] vfs: enable remap callers that can handle short operations [17/29] vfs: hide file range comparison function [18/29] vfs: clean up generic_remap_file_range_prep return value [19/29] ocfs2: truncate page cache for clone destination file before remapping [20/29] ocfs2: fix pagecache truncation prior to reflink [21/29] ocfs2: support partial clone range and dedupe range [22/29] ocfs2: remove ocfs2_reflink_remap_range [23/29] xfs: add a per-xfs trace_printk macro [24/29] xfs: fix pagecache truncation prior to reflink [25/29] xfs: clean up xfs_reflink_remap_blocks call site [26/29] xfs: support returning partial reflink results [27/29] xfs: remove redundant remap partial EOF block checks [28/29] xfs: remove xfs_reflink_remap_range [29/29] xfs: remove [cm]time update from reflink calls

Message ID

153981641972.5568.6155004838582569988.stgit@magnolia (mailing list archive)

State

New, archived

Headers

Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates
 156.151.31.85 as permitted sender) client-ip=156.151.31.85;
Subject: [PATCH 23/29] xfs: add a per-xfs trace_printk macro
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: david@fromorbit.com, darrick.wong@oracle.com
Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
        linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org,
        linux-mm@kvack.org, linux-btrfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Date: Wed, 17 Oct 2018 15:46:59 -0700
Message-ID: <153981641972.5568.6155004838582569988.stgit@magnolia>
In-Reply-To: <153981625504.5568.2708520119290577378.stgit@magnolia>
References: <153981625504.5568.2708520119290577378.stgit@magnolia>
User-Agent: StGit/0.17.1-dirty
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

fs: fixes for serious clone/dedupe problems | expand

Commit Message

Darrick J. Wong Oct. 17, 2018, 10:46 p.m. UTC

From: Darrick J. Wong <darrick.wong@oracle.com>

Add a "xfs_tprintk" macro so that developers can use trace_printk to
print out arbitrary debugging information with the XFS device name
attached to the trace output.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_error.h |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h
index 246d3e989c6c..5caa8bdf6c38 100644
--- a/fs/xfs/xfs_error.h
+++ b/fs/xfs/xfs_error.h
@@ -76,6 +76,11 @@  extern int xfs_errortag_set(struct xfs_mount *mp, unsigned int error_tag,
 		unsigned int tag_value);
 extern int xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag);
 extern int xfs_errortag_clearall(struct xfs_mount *mp);
+
+/* trace printk version of xfs_err and friends */
+#define xfs_tprintk(mp, fmt, args...) \
+	trace_printk("dev %d:%d " fmt, MAJOR((mp)->m_super->s_dev), \
+			MINOR((mp)->m_super->s_dev), ##args)
 #else
 #define xfs_errortag_init(mp)			(0)
 #define xfs_errortag_del(mp)
@@ -83,6 +88,7 @@  extern int xfs_errortag_clearall(struct xfs_mount *mp);
 #define xfs_errortag_set(mp, tag, val)		(ENOSYS)
 #define xfs_errortag_add(mp, tag)		(ENOSYS)
 #define xfs_errortag_clearall(mp)		(ENOSYS)
+#define xfs_tprintk(mp, fmt, args...)		do { } while (0)
 #endif /* DEBUG */
 
 /*

[23/29] xfs: add a per-xfs trace_printk macro

Commit Message

Patch