From patchwork Wed Oct 17 22:47:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10646531 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C5D9F15E2 for ; Wed, 17 Oct 2018 22:47:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B769E288C7 for ; Wed, 17 Oct 2018 22:47:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ABA56288E4; Wed, 17 Oct 2018 22:47:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49E4B288C7 for ; Wed, 17 Oct 2018 22:47:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 305EB6B029B; Wed, 17 Oct 2018 18:47:45 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2DAFD6B029D; Wed, 17 Oct 2018 18:47:45 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CAC26B029E; Wed, 17 Oct 2018 18:47:45 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by kanga.kvack.org (Postfix) with ESMTP id D28576B029D for ; Wed, 17 Oct 2018 18:47:44 -0400 (EDT) Received: by mail-pg1-f197.google.com with SMTP id m4-v6so21184147pgv.15 for ; Wed, 17 Oct 2018 15:47:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:from:to:cc:date :message-id:in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=jIAzzc18fmqpZ/u/wL5JmiNfFJR+FqDbUB467dFODYU=; b=cztuBnXghIpjn31KtOEW2P3kksUTUTvMFB9hh7YPIYryzpT9iaoRnI43bi6YN23+yX 2DBCVz547KUOV/z9mIP1Ew7ANXPno12NHgpqLjurwhqGrLwQ67dxR0lmCfbAyRMpgCEW odWqmk3/3DwBzrTiHT4FMj7LjZ0K8lk003GVWz6SUamZpBJ6Rr5qm3iFxToBuQPajttL G0Q7UofbOKIlYXlY1253/vUVJhkb3ewFi8SDjoJ0WSWhXLsWSgK3XTqQPMRCLWcaWurK nZvm3EdrBjTA5NFNoxUPEARsOvD/xTDUqD1j3dUGrxF2kn9ZIyjXu21Q+UWMh+X4LXhp tbjA== X-Gm-Message-State: ABuFfoj9DvIzHPIs70pFEvcoNvc8r+baJ3X/pMpf3bsgvPF9+wdxiW+j nH1zYifjBlNHf3PN8gkPc5B7NGsyLjUdlPfq5jvPoHYfSfO9CNtcSvsCfaJxAUzlieD5YTaEh8q 0qHOD5k9QnxucNK1oDZq7EPOztn0IeNhRbHTydfuCTODRw1NeSRxAHpVp+yzypyti2g== X-Received: by 2002:a63:7506:: with SMTP id q6-v6mr25881091pgc.137.1539816464535; Wed, 17 Oct 2018 15:47:44 -0700 (PDT) X-Google-Smtp-Source: ACcGV60WHmL2QyIfkrRkcCYq7Ztg9eXD3LV++zB24o8Y/mUJzVAanfFCTVusq5jbjMV+KTPMK0B8 X-Received: by 2002:a63:7506:: with SMTP id q6-v6mr25881069pgc.137.1539816464014; Wed, 17 Oct 2018 15:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539816463; cv=none; d=google.com; s=arc-20160816; b=MPbOv71V2ml3uBa6mK3Se4rHyI2PxA0l9aneGgTPvlIFy2A4H+GT6tYVSmB/f7wTIF H7Lf++sN2PFTFJgFgjKEIFRXkZgKx4/yJmEe8bkSUqSWJ5Yz9ALOQmkFzgCIINAGPSz8 7he6H81xK3dQduE1BylSt+KQoBiQtiI+9xOnPJ0LJBZ54Zan+Aj7hrjk2dMA12ILMVV8 9hy4pGR96PdZ7HQgxHEVo8awBTv6+7LbsBYPGHEDFxR/8gAck/95xsGjzukC5lLBzq7a YU7VL8tMqNTCGQlZPHcnLZ3wAy3Q07h0B+CzZR03FShanPcdqvA7udhTa582NXqTQZvW 8RCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject:dkim-signature; bh=jIAzzc18fmqpZ/u/wL5JmiNfFJR+FqDbUB467dFODYU=; b=Q1w3iw+zsLpsTrkz8TyNTcZ6Hi+7W8hq+vxYjLuklqAR9RBKj9VkfdziCWr4bvftMp 3pNoPGfzOr868B+Dumw34rs+Ymcg/qr79xB5M9sLmHSJ0wL4a/u38yuL1PpWyCukk37w kfgVoUmQseYcSvsgzczQbBZL8mwsCCoghffkTunW9P2q0uTybBJKoR3rOXtRzfMLa9LJ 8qi90BtSEqswazbCyDA4ujJ5RuyKa5xXDrtIS313pOszjnTzcnu21uzTlwYgy7XOhUUN tiN8710k3lTRbhPuWoldSIEi+Ccgl9a04BH5UWPqqZzeehzcyMTi9En/XdnYlJneCzjJ 3QCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=sOaVtFlF; spf=pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) smtp.mailfrom=darrick.wong@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from userp2120.oracle.com (userp2120.oracle.com. [156.151.31.85]) by mx.google.com with ESMTPS id d185-v6si14331803pfd.260.2018.10.17.15.47.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Oct 2018 15:47:43 -0700 (PDT) Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) client-ip=156.151.31.85; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=sOaVtFlF; spf=pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.85 as permitted sender) smtp.mailfrom=darrick.wong@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9HMiGkT189473; Wed, 17 Oct 2018 22:47:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=jIAzzc18fmqpZ/u/wL5JmiNfFJR+FqDbUB467dFODYU=; b=sOaVtFlFmuGfSGGEryyxYpPVZSMUeGhKV3nKWZU+P1e252Rk2IiyNjV12YEx/9QM8HXf 3vjy/ehgTK1KERrMDye+MGTZeMvjn+vFwAXQdymuBAdiQXd8lJ2/UGiJS1fKx+ubP5no XVVlIO7qQRbNyFnRuJka2lGmODDWrPf27/UIGYu3aleL2Jt8MllcnQstEcLxsfcOcoqe H/ZqdZ4PcaWtcYEnLmkuYUZ0z3xzoSE2PfWydWQTmJA7wtD7UxYOCHpDQnATvuTWkqYa 6pshZ6dUnpxyfAqJQmlkDMRALAs/0awyLFymHeYvEAVI5fuflOrisUMW4IbKZ4Up8pjI qA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2n39brhpd8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Oct 2018 22:47:43 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9HMlgdj013644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Oct 2018 22:47:42 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9HMlgXE032742; Wed, 17 Oct 2018 22:47:42 GMT Received: from localhost (/10.159.132.177) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 17 Oct 2018 15:47:41 -0700 Subject: [PATCH 29/29] xfs: remove [cm]time update from reflink calls From: "Darrick J. Wong" To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Date: Wed, 17 Oct 2018 15:47:40 -0700 Message-ID: <153981646034.5568.15367504587850383353.stgit@magnolia> In-Reply-To: <153981625504.5568.2708520119290577378.stgit@magnolia> References: <153981625504.5568.2708520119290577378.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9049 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=865 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810170188 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Now that the vfs remap helper dirties the inode [cm]time for us, xfs no longer needs to do that on its own. Signed-off-by: Darrick J. Wong --- fs/xfs/xfs_reflink.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 84f372f7ea04..e72218477bf2 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -927,8 +927,7 @@ xfs_reflink_update_dest( struct xfs_trans *tp; int error; - if ((remap_flags & REMAP_FILE_DEDUP) && - newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0) + if (newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0) return 0; error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp); @@ -949,10 +948,6 @@ xfs_reflink_update_dest( dest->i_d.di_flags2 |= XFS_DIFLAG2_COWEXTSIZE; } - if (!(remap_flags & REMAP_FILE_DEDUP)) { - xfs_trans_ichgtime(tp, dest, - XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); - } xfs_trans_log_inode(tp, dest, XFS_ILOG_CORE); error = xfs_trans_commit(tp);