From patchwork Sun Oct 21 16:18:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10651283 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5326D13A9 for ; Sun, 21 Oct 2018 16:18:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41317281D2 for ; Sun, 21 Oct 2018 16:18:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 351792832D; Sun, 21 Oct 2018 16:18:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C381A281D2 for ; Sun, 21 Oct 2018 16:18:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2076B028F; Sun, 21 Oct 2018 12:18:27 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B3C5F6B0291; Sun, 21 Oct 2018 12:18:27 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A03B56B0292; Sun, 21 Oct 2018 12:18:27 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f71.google.com (mail-yw1-f71.google.com [209.85.161.71]) by kanga.kvack.org (Postfix) with ESMTP id 6D1946B028F for ; Sun, 21 Oct 2018 12:18:27 -0400 (EDT) Received: by mail-yw1-f71.google.com with SMTP id n143-v6so25632140ywd.6 for ; Sun, 21 Oct 2018 09:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:from:to:cc:date :message-id:in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=jIAzzc18fmqpZ/u/wL5JmiNfFJR+FqDbUB467dFODYU=; b=nwPwnqgPqoJL9dS9r4fIKQasq+mrcUpb75T2+tbX1HzZI8iwH8pyY5Y5x8sbKr4xIq LpZ+k+ZwzZXIy27UlwVl1B5P+VZFKcMxJ8o6NEmduRXxA6tSQ/R+XPImPgX27a/kcXZK Iyqct0PVBmYYMq4w6vFngOtI81jTFD2hsxWcwWH4yPPzVLtWfntIzWjdveD22/Uk4eB/ Q5gE7LLSTR96EpDSFSWU064AQBXsy2+X8TfQABnGYn6r+OSTvgjK+NShGndf/4FEBc6a xTUtRAysw2RVzHBE/25UFDcYereW+0BvOEbczGf9EXf9CHJeIsUSJXz7pygLlSdJdv2a OKoA== X-Gm-Message-State: ABuFfoiPQL3PIHHbN2VbTZWg+HWKEFzXrS57FF0bUzE7jAX99SGxxbjc y3sXtSax/ockNsQzqbPQ8BbhiXp+d7a9gtx6UIu/C9XEqyVrV0kc/u4Tsnx/X94cDRZygwxE8Ou IS8l9QTbpaV9QLZ6FrkUa+TOjKQOPkGkWwxkuavpP50sMCeWz/IoINWED7TneInrb6A== X-Received: by 2002:a25:ef07:: with SMTP id g7-v6mr29573965ybd.417.1540138707207; Sun, 21 Oct 2018 09:18:27 -0700 (PDT) X-Google-Smtp-Source: ACcGV62B98E/YQcwqV2k6v1npcLixttBptraLlM31sOrW0pbQ62kx+M+m4nOtoO9BJ/rOyufSiZI X-Received: by 2002:a25:ef07:: with SMTP id g7-v6mr29573930ybd.417.1540138706587; Sun, 21 Oct 2018 09:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540138706; cv=none; d=google.com; s=arc-20160816; b=gK3FQgLuW4BtXvyyCnU9bhhTpmUu1cS8fZrllhqIt2DdOlK7/f4J+8WWuD7BBqvlqb fjpgXrratjnxruFhcwYW9Wn5XmfaMGUdj+Tu1tMo3sLwgshzY2FBrLz5y3N6z27oCxHI Cv1BDDo5ysBl402OCzdOiQ4Ey4N7cD6amX8sUBd1hm23UNMDc4fKQel68PxEENhE+gUZ N9blkQrYmC1iskogrQhgUic5dwPdI3gq4nN4bK787F0v8ihKRNyjaqJj3WGsOXQ9qUp2 Df4t2PRs7Qxbj9dcfpmKjyS/jhv0XmZDzBYBj3k28/FcCHrbSJGeq+LS2PQJvsUKmUaH yk0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject:dkim-signature; bh=jIAzzc18fmqpZ/u/wL5JmiNfFJR+FqDbUB467dFODYU=; b=tf7vMgWb1+zMwGW+tLJcjHWN35N3VUBczMwpqmJBYCVS0kYIzThJ/u+RUD4y9NJ1lm M3xY1xLRYEgZhAd2DcRPChjmKaJqLsULW0sqYI5HsRMoN6q3kmpSNsLZeDNVCAYC2aki 3HZEVgO47iceivhkb1oSULCVGFa6tsuVVVkx2T6GKIo9EomKrBwYpJR9M0tb/LVKVzgz AWZe25bG2Cn+tPIKvSrjyYO0TH6kt8ze99AWOjfTvrdwcRy9CmXwoGkBaqgvf8KpyWlX PNViuIDX3u9Ze3QS5D5lESE9cIRUXz4OWBndzX59f7pt+o2vakC5lrYSj9u0ZnBKUZtS JrfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=4REOEMUD; spf=pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.86 as permitted sender) smtp.mailfrom=darrick.wong@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from userp2130.oracle.com (userp2130.oracle.com. [156.151.31.86]) by mx.google.com with ESMTPS id r15-v6si4109218ybm.475.2018.10.21.09.18.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Oct 2018 09:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.86 as permitted sender) client-ip=156.151.31.86; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=4REOEMUD; spf=pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.86 as permitted sender) smtp.mailfrom=darrick.wong@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9LGIPFo156709; Sun, 21 Oct 2018 16:18:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=jIAzzc18fmqpZ/u/wL5JmiNfFJR+FqDbUB467dFODYU=; b=4REOEMUDeeSpvzDWeIXkcCH2Uv4rSr9wNZqHRv+7to1W8Dyk1u3Znxq2m/Be4hDpZqIu B2wUk+QxWiScMJcKQBNoOeypUBFU/oxfiHYJp5S2eglmoPLQdN7+EdlpcB6jU+jbI3F+ /axs7CTxnxWBNMCm5eP8JfhSOWedODmFfXTsEAmft2yFh6ZTCEOV7t9Jpk+413m2vSZJ zj/15Z03uX1oigBQLgkYnpdsDrX6TClci0mWfMMTmQrVHIfa15R4cIS9p9F3XCVnaF13 A1tohZrvVYghD3n2z+7jhj49BfPnH/4DIPPDpGEc0p3/yr6W+5sQokXEG3K4kPFgkVL1 Cw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2n7ustu1w3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 21 Oct 2018 16:18:25 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9LGIOpQ007643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 21 Oct 2018 16:18:24 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9LGIOUu021851; Sun, 21 Oct 2018 16:18:24 GMT Received: from localhost (/10.159.225.70) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 21 Oct 2018 09:18:24 -0700 Subject: [PATCH 28/28] xfs: remove [cm]time update from reflink calls From: "Darrick J. Wong" To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Date: Sun, 21 Oct 2018 09:18:17 -0700 Message-ID: <154013869780.29026.674362788764806472.stgit@magnolia> In-Reply-To: <154013850285.29026.16168387526580596209.stgit@magnolia> References: <154013850285.29026.16168387526580596209.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9053 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=862 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810210151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Now that the vfs remap helper dirties the inode [cm]time for us, xfs no longer needs to do that on its own. Signed-off-by: Darrick J. Wong Reviewed-by: Dave Chinner --- fs/xfs/xfs_reflink.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 84f372f7ea04..e72218477bf2 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -927,8 +927,7 @@ xfs_reflink_update_dest( struct xfs_trans *tp; int error; - if ((remap_flags & REMAP_FILE_DEDUP) && - newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0) + if (newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0) return 0; error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp); @@ -949,10 +948,6 @@ xfs_reflink_update_dest( dest->i_d.di_flags2 |= XFS_DIFLAG2_COWEXTSIZE; } - if (!(remap_flags & REMAP_FILE_DEDUP)) { - xfs_trans_ichgtime(tp, dest, - XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); - } xfs_trans_log_inode(tp, dest, XFS_ILOG_CORE); error = xfs_trans_commit(tp);