From patchwork Tue Nov 6 06:03:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10669677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 47B3C15A6 for ; Tue, 6 Nov 2018 06:03:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 376A028DB7 for ; Tue, 6 Nov 2018 06:03:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B80B29196; Tue, 6 Nov 2018 06:03:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9AE928DB7 for ; Tue, 6 Nov 2018 06:03:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 844786B02BC; Tue, 6 Nov 2018 01:03:36 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7CCAC6B02BE; Tue, 6 Nov 2018 01:03:36 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BAA16B02BF; Tue, 6 Nov 2018 01:03:36 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id 3AF9D6B02BC for ; Tue, 6 Nov 2018 01:03:36 -0500 (EST) Received: by mail-pf1-f198.google.com with SMTP id b15-v6so7070269pfo.3 for ; Mon, 05 Nov 2018 22:03:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=8hPsWF+zmvUgHpFK9J9WYDSCd8eYHRfYFfs0ZjrGO0Y=; b=b8fuewP+VVI9RC8E3wRyS5Jbw8VjCdYTSF/XfWzTMzLzE/VE4J3bEptOltTtST6TUV NX6krDBTR9IjxhWZov9GOeAuF0ExMc0IV2CoGqnYamN3/f43LU0OC58Xu6AHQ+WRzpgB WLF13bilBOGnhP9mhpARKcAd+qnAgDWIO51Laqw+vOqtp0ohGmPLUkF945EYcbAlmVms j8Gr6UgGPhdNPAyBoU53e+NDy3nzdB3KIdrFyQ+VDuv9lgQzV59KYzCOk+Z/UJZFGpFl hNB8DFMoAMT8RbcZx/5/Wnekkm/93c7sXsi0UHIMoTF++4f6ZEgCWnZz6mbWw8kR5qTz Mbjg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: AGRZ1gLUjx2MfS6FWbAVWIGhq2KmvNu3aqCqlFTndGLYDmVtvNhShgzP wtl8leJ8h43ifLI7K2t+T1KQjtwfvIWpcfOPiGE5zL8AvMEorc/A6hb6slUtiYqEh2Af02ihaSN 8d+2wNksLz70dfT79xfzoRGDhJ4KsFspQkW/D0q6xg7i5ZauVVgLgW7LK6TbmPYc= X-Received: by 2002:a17:902:c01:: with SMTP id 1-v6mr25094084pls.15.1541484215941; Mon, 05 Nov 2018 22:03:35 -0800 (PST) X-Google-Smtp-Source: AJdET5furwqRtzACrYjPAeDr2MDfj+C6bltrlGmwM9lszxX6UqJoxubxeeDeembSpP2IALrS/9pe X-Received: by 2002:a17:902:c01:: with SMTP id 1-v6mr25094066pls.15.1541484215339; Mon, 05 Nov 2018 22:03:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541484215; cv=none; d=google.com; s=arc-20160816; b=oToqAZxwTYJIZ9XTOGTdEDQWqt763rFlNurR9fbgjupgfDrmIZfBZ9tc10rWtkel1p ER7aqw4wXOPoD8euxx0PyStoOF28s0q2ovW1H3i9Wmje9U18NAAffz2tpaUN9dYpHRTA iP+bDUiWpzqXneU3wHRe2VTCrki3+2MJ0hV5SIFASHEPsqYwSZUsC6UjDGFx84veiIQj FkEin4oIsqqbibelaL4KGCDOe2JhGj1eHIednczeQbOi1JLn1TxRUW/K34e5cN3Lo9bK xheZ18hh1d/EUEiL7BIE26YLpAq0APKKwnIERH8CaUR5PX9lSahX5rvxJok1Zm/RO1Cf r2kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=8hPsWF+zmvUgHpFK9J9WYDSCd8eYHRfYFfs0ZjrGO0Y=; b=r+pDfwvx++fNcIEjLNQuEY/iNI34GZEuB5nR5MHt0G95ZMp9KgnqLzf5HSnZw9QbPD Ih8riTtFaP69LcvSfRNw4QzFLYuLv3iycDIIttsWNR86WSsv88veI44TMUxHeXiG+JXt vP7JCDxRrjhZdCuXzdqt8gYIAoSfsIhFTbVJrzeAGEmWZ+tNEp+tb7iOK8dMBetF7WG2 qm/0Ut8/QZGc0Asm41EnvkCsUXLaqDBFyHyc3Aa8v2MVyDQkWczEGHtH5TNscT7xtg+s /ggmO/+E5C9G+fbqZzz4ddVBNciHpd3M4l3bGKd+ZGltlQr3KeC6jYI4/LCR+zYCG1JY vtuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr-01.qualcomm.com (alexa-out-blr-01.qualcomm.com. [103.229.18.197]) by mx.google.com with ESMTPS id y27si11829553pga.459.2018.11.05.22.03.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 22:03:35 -0800 (PST) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) client-ip=103.229.18.197; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,470,1534789800"; d="scan'208";a="276569" Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Nov 2018 11:33:34 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9068"; a="5671283" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg01-blr.qualcomm.com with ESMTP; 06 Nov 2018 11:33:33 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id 67FC831C6; Tue, 6 Nov 2018 11:33:33 +0530 (IST) From: Arun KS To: arunks.linux@gmail.com, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: getarunks@gmail.com, Arun KS Subject: [PATCH v6 2/2] mm/page_alloc: remove software prefetching in __free_pages_core Date: Tue, 6 Nov 2018 11:33:14 +0530 Message-Id: <1541484194-1493-2-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1541484194-1493-1-git-send-email-arunks@codeaurora.org> References: <1541484194-1493-1-git-send-email-arunks@codeaurora.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP They not only increase the code footprint, they actually make things slower rather than faster. Remove them as contemporary hardware doesn't need any hint. Suggested-by: Dan Williams Signed-off-by: Arun KS --- mm/page_alloc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7cf503f..a1b9a6a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1270,14 +1270,10 @@ void __free_pages_core(struct page *page, unsigned int order) struct page *p = page; unsigned int loop; - prefetchw(p); - for (loop = 0; loop < (nr_pages - 1); loop++, p++) { - prefetchw(p + 1); + for (loop = 0; loop < nr_pages ; loop++, p++) { __ClearPageReserved(p); set_page_count(p, 0); } - __ClearPageReserved(p); - set_page_count(p, 0); page_zone(page)->managed_pages += nr_pages; set_page_refcounted(page);