From patchwork Tue Nov 13 06:33:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10679787 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 059A314BA for ; Tue, 13 Nov 2018 06:33:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E92D4286A7 for ; Tue, 13 Nov 2018 06:33:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD4B028857; Tue, 13 Nov 2018 06:33:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 751C0286A7 for ; Tue, 13 Nov 2018 06:33:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 424396B0280; Tue, 13 Nov 2018 01:33:33 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3B53C6B0281; Tue, 13 Nov 2018 01:33:33 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 165C46B0282; Tue, 13 Nov 2018 01:33:33 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id C69B86B0280 for ; Tue, 13 Nov 2018 01:33:32 -0500 (EST) Received: by mail-pf1-f199.google.com with SMTP id b15-v6so9652755pfo.3 for ; Mon, 12 Nov 2018 22:33:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=jMLb2BKzmXBCJuzHEvroGcLpPS2Cq9AGTSdXYh98axA=; b=nkBCIZXFsJK7tO/8ArJ39mDrXFPgpZCdjG2rulnBPgZ53BdtrFkLqNlOf9hF5G4WHL d/ZVJ8EPa6ex3SpCwdKjlaXx02pqxs4bvwxzjON5EB1iLFTNGxbEYKeEOyHTxp59su6V CKoAN9CgoJ1W/8QYOIjwuxeUu8dxTmx3+W5T2JzyXCFOGPRy5JgnDzbA/zCCxxxyRyvG 7FJHLMdXyTLDld1PLcJGo2aWUBLGr7jSucUe+vWWoA3EfYVhtchkm2cNRvtcgW1wyhit K2SXipCxf5pqOsWLKpqiqyfpeH0dZDXItgIRte9tyzAZOde6eAEM0gEf9G+vtEpeQubM ouAQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: AGRZ1gKzRm+fta2kyfqhIBzcBwH1bzCVchCo3FSBa0F24zrmlToPyF1o 2BvdSJMuWLPqoEAde9jMamcmg8xY/lYDDl6rEgTpyMaiy1l4OvZF0kgXYiR2CMKSJmyqLNOx1nA ilZ6rpphV8SHj5vlcoyjKLY+INRXtyXWIcrJKV0VE0IbR/5G8OzSq15Z6lAWnbZw= X-Received: by 2002:a63:981:: with SMTP id 123mr3652378pgj.444.1542090812491; Mon, 12 Nov 2018 22:33:32 -0800 (PST) X-Google-Smtp-Source: AJdET5fkbhrmPCXdRGgwDqU57Xz9VSkseOdH9GYUmbCWteZNC/P71uTEyofJz+vwEXrbGB5/sHUk X-Received: by 2002:a63:981:: with SMTP id 123mr3652322pgj.444.1542090811218; Mon, 12 Nov 2018 22:33:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542090811; cv=none; d=google.com; s=arc-20160816; b=u4HanEuo+6cfr3tueadxkLx2eG9dRUGTDDRft/Wb1RO/wMPIfIg5U+LOUAIpvtdjmO b9tfXMTnDvG7xz+s+JKTQ5u8GKCvRNAIjSK46mgWyoTKPtL/EMbUnKxFUrQNOsYDqr2p oadu1DadJui5qlyGFLWzOOQMqkL8Ua8Ds4PWSWgWeroGzx706xG5qnT/sTB9goJM0rYN 0FaWsdEjAkJHFSfHKxB3vBs0GwrOq0YMdxfhExG6f2omuTPCUC76OAdyYGeXV+7MdxkJ WqzZW3d6qB74ddEx2DGazx8bo3EXcZqsN4Fd6zACbuLISW+EfJuq5RIeWgvCCV5uOjb/ AySA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=jMLb2BKzmXBCJuzHEvroGcLpPS2Cq9AGTSdXYh98axA=; b=Y6vSmNmRQwb9YR546ylHKY7/O318EJDDemihpozrzqh28i4uS/94HcPcLW3a1/xU6p nlUaIH2LhGa/ggfSEerC9r1vA6QjNppQgKoWqOlhKS/+utuA4Lbt6TqplQykYIDg1nHr ShoZQAB8Tenm1e7fLAST12v+w+u7b6Co8YTKAIMwPVxNmX98FejueDODq7VD1nG/RMh8 CcYDrfEIg3ckR4o6YplCtbEoKk0P5lFEgwzCKAj+XlJLO4eE7iwNQ/gWsrkZmxNYNcVx 8Sg7nzASFLfoB4Q4z+yv7qjzc/pxlgADHwmTLUN++je9X6Z61ovMBUmPfRd2QD0oatnW y27A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr-01.qualcomm.com (alexa-out-blr-01.qualcomm.com. [103.229.18.197]) by mx.google.com with ESMTPS id f3-v6si20203009pld.186.2018.11.12.22.33.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 22:33:31 -0800 (PST) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) client-ip=103.229.18.197; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,498,1534789800"; d="scan'208";a="284464" Received: from ironmsg03-blr.qualcomm.com ([10.86.208.132]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 13 Nov 2018 12:03:29 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9075"; a="2020981" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg03-blr.qualcomm.com with ESMTP; 13 Nov 2018 12:03:29 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id 30C18269C; Tue, 13 Nov 2018 12:03:28 +0530 (IST) From: Arun KS To: Cc: keescook@chromium.org, khlebnikov@yandex-team.ru, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vatsa@codeaurora.org, willy@infradead.org, Arun KS Subject: [PATCH v5 4/4] mm: Remove managed_page_count spinlock Date: Tue, 13 Nov 2018 12:03:10 +0530 Message-Id: <1542090790-21750-5-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1542090790-21750-1-git-send-email-arunks@codeaurora.org> References: <1542090790-21750-1-git-send-email-arunks@codeaurora.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Now that totalram_pages and managed_pages are atomic varibles, no need of managed_page_count spinlock. The lock had really a weak consistency guarantee. It hasn't been used for anything but the update but no reader actually cares about all the values being updated to be in sync. Signed-off-by: Arun KS Reviewed-by: Konstantin Khlebnikov Acked-by: Michal Hocko Acked-by: Vlastimil Babka Reviewed-by: Pavel Tatashin --- include/linux/mmzone.h | 6 ------ mm/page_alloc.c | 5 ----- 2 files changed, 11 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index e73dc31..c71b4d9 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -428,12 +428,6 @@ struct zone { * Write access to present_pages at runtime should be protected by * mem_hotplug_begin/end(). Any reader who can't tolerant drift of * present_pages should get_online_mems() to get a stable value. - * - * Read access to managed_pages should be safe because it's unsigned - * long. Write access to zone->managed_pages and totalram_pages are - * protected by managed_page_count_lock at runtime. Idealy only - * adjust_managed_page_count() should be used instead of directly - * touching zone->managed_pages and totalram_pages. */ atomic_long_t managed_pages; unsigned long spanned_pages; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index f8b64cc..26c5e14 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -122,9 +122,6 @@ }; EXPORT_SYMBOL(node_states); -/* Protect totalram_pages and zone->managed_pages */ -static DEFINE_SPINLOCK(managed_page_count_lock); - atomic_long_t _totalram_pages __read_mostly; EXPORT_SYMBOL(_totalram_pages); unsigned long totalreserve_pages __read_mostly; @@ -7065,14 +7062,12 @@ static int __init cmdline_parse_movablecore(char *p) void adjust_managed_page_count(struct page *page, long count) { - spin_lock(&managed_page_count_lock); atomic_long_add(count, &page_zone(page)->managed_pages); totalram_pages_add(count); #ifdef CONFIG_HIGHMEM if (PageHighMem(page)) totalhigh_pages_add(count); #endif - spin_unlock(&managed_page_count_lock); } EXPORT_SYMBOL(adjust_managed_page_count);