From patchwork Thu Dec 20 09:50:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pingfan Liu X-Patchwork-Id: 10738735 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1320413BF for ; Thu, 20 Dec 2018 09:51:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2C0A28415 for ; Thu, 20 Dec 2018 09:51:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E387D28712; Thu, 20 Dec 2018 09:51:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72B7A28415 for ; Thu, 20 Dec 2018 09:51:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 401998E0007; Thu, 20 Dec 2018 04:51:28 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 389B98E0003; Thu, 20 Dec 2018 04:51:28 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C7C8E0007; Thu, 20 Dec 2018 04:51:28 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by kanga.kvack.org (Postfix) with ESMTP id CDC878E0003 for ; Thu, 20 Dec 2018 04:51:27 -0500 (EST) Received: by mail-pf1-f197.google.com with SMTP id n17so1143448pfk.23 for ; Thu, 20 Dec 2018 01:51:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=TzK/offuMiftcp8zdhetLLgTPbF5oMiPcKmIl7aXSqs=; b=AigiHoWjsp7893xY4iUp2NDuOiS0JNh5rjo+AKgTfUXv4xLPyPP6LYj4iMWlrzHTBd c0RA2JzHQa6f15oW3RTdxX9V8oG5JY/RqXgv0HzHD2+ty29rIQ53xrIYOku8YFEKwu7w qiqdnJt3ivoR/IVLjHOWr+uAh1zIeVb5+iFQ2p/xUPjJAN0f+jK7SQzeXBtcKlzqPlnj 5hrmTvkkhgaLO4IwSd1da+SfXLWYHbf3p2b5Q3DyBUCl/qdZXLZ60wY5ekMMXBxkkeLY 3V483OAm/IWnQ2VQAeEytLz3ADQ1wwNy951K+iyVwGYQUfUSUn11PN3/UrTb0beDQIDs KALQ== X-Gm-Message-State: AA+aEWYyQ9zAatTdVXCdjergl9elKdaDQ7cKfHwLpT1h2uR3DD5tYVY6 i6ywjpUfoep7rPxCDgyaTCfFSICnZcM9kZFI5TyilybP6ht96cHJNEMFduId4Oc6SxLyMUSEyZe oOUIWh+GGLlbIIxw7aeB4nXPuRv2TcL+lDSsATxxuIAt0NiGgJdnWeEiWsrUJsQibdsvTMcO1KP D4vskyunmauM63thhiN1pZXSUcl5tmoUtdzUF6+ScXDPEAHwUuXxC/cjQZaPG84dmu+0cleZtIT NJbywS5IHjJzc0rWx3HYQdoufClmn+tJLjK6CZ+gplCw1mYayQ87L0M/NBGK3RhxM6wLAUwpMLI gXsoHIKIliM2W0qNUAojv592+bxC1KNE59R1RYiEoaEyLss78IXdhUrSAnCA6FqTSsGjc+DY3Vg q X-Received: by 2002:a63:a35c:: with SMTP id v28mr22253178pgn.205.1545299487440; Thu, 20 Dec 2018 01:51:27 -0800 (PST) X-Received: by 2002:a63:a35c:: with SMTP id v28mr22253121pgn.205.1545299485704; Thu, 20 Dec 2018 01:51:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545299485; cv=none; d=google.com; s=arc-20160816; b=DrU4y0WeOVU4rTDgPMaZsuUYSHvNQBmL7n/Wet/JTy+r7T94Dd6my5lXFJRZ4RZc6S 9631o50l49EwkPe4BMveAUvqwGevR7ztPwPwNghJ9MPYmCO9buJjGzWNgJdIhtD7iV19 L0Ku3nUT/7tOqDusfMGTdPySW5iuNiUB5/1Bk/cA/RbO/FWbW5SUdavvyCY9wEhSuALC Ox+bkdoWQAdFFGMptLiNP/tZdkbx+XX3yPn7HxIwMuUCSf6xrH3KgehRBrYNPnzeK46Y Oerrbs8cg9oPvTGbrYoXWL0SbFRefWiZnAqelLjZjgFskiAM44La9M0U4F0E2FSKOtmj I+0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TzK/offuMiftcp8zdhetLLgTPbF5oMiPcKmIl7aXSqs=; b=lZCm3v16q3ZcSoqsiSrTvgwoy9W6N8lSIoMLZJxRbprVWyuJ1lGvZBS/hBGiKAGQIG +zJv8OiF1ikCSox3FffIwMtnrN/8/LOZDbCssWCDDvLlqmzbAIzc4yugaUCdlyz/AMRU 6i553XmJR9qjobmGJT9NKc4bCTZBxpLhnXi8hPVNIAHmIGTQxb2eyWcN+yzUQNJ1fJ22 k02bmRs6D57IjOiNIrhkWY/mq8tGoye+kAbRrbXlfAKeylMY78Qi2urxCdXMsWyHW/FX WufNzl4Z3puBV97Wyo86M4YOiT64O6MipYriKrYltQzxOPbOiMOGPqeLu5vohu7Tf0wc 1Uow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ZZ5Sby/E"; spf=pass (google.com: domain of kernelfans@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=kernelfans@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id o19sor31213473pll.44.2018.12.20.01.51.25 for (Google Transport Security); Thu, 20 Dec 2018 01:51:25 -0800 (PST) Received-SPF: pass (google.com: domain of kernelfans@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ZZ5Sby/E"; spf=pass (google.com: domain of kernelfans@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=kernelfans@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TzK/offuMiftcp8zdhetLLgTPbF5oMiPcKmIl7aXSqs=; b=ZZ5Sby/EbDZxJq5f8tEKiQXeJ3J+mgYGawoOSTjOqgDokHbe87vYBeNjo26rvurFaH u3zyMw8brzZW1JMc9FjAOrm4Aj/eCAyMVOZ+o/HrnUx6CdhsglE5aND0oCD2+FCKLRHg AMRuF+da/oCmYx8zey98h3O8QieoawwVMlJx8f9LNVqnOOy6Iu4fvIFg/4gmx75BhE61 fgAlr6TBOTxYrqpZxnaIER6Z+ERYvDmAQ7v6Ar/6dPfQSwRPJepnwqBw/bOO4t8teuvH qKy7ibtg29/9AnICPYBinuXDq223N45klFHNLiK7+CQYyaGDGMmJlCB6UlUmOoqT7BX9 SLuQ== X-Google-Smtp-Source: AFSGD/W+peKcgU2gsTb6UnoUotPkHL3GAnOzUnutuIhsRU+AXYQggUTAl5j7u1dOBpTeYLPbe+s5fw== X-Received: by 2002:a17:902:622:: with SMTP id 31mr23030237plg.171.1545299485120; Thu, 20 Dec 2018 01:51:25 -0800 (PST) Received: from mylaptop.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id 125sm33355206pfx.159.2018.12.20.01.51.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 01:51:24 -0800 (PST) From: Pingfan Liu To: linux-mm@kvack.org Cc: Pingfan Liu , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Michal Hocko , Vlastimil Babka , Mike Rapoport , Bjorn Helgaas , Jonathan Cameron , David Rientjes , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: [PATCHv2 3/3] powerpc/numa: make all possible node be instanced against NULL reference in node_zonelist() Date: Thu, 20 Dec 2018 17:50:39 +0800 Message-Id: <1545299439-31370-4-git-send-email-kernelfans@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1545299439-31370-1-git-send-email-kernelfans@gmail.com> References: <1545299439-31370-1-git-send-email-kernelfans@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This patch tries to resolve a bug rooted at mm when using nr_cpus. It was reported at [1]. The root cause is: device->numa_node info is used as preferred_nid param for __alloc_pages_nodemask(), which causes NULL reference when ac->zonelist = node_zonelist(preferred_nid, gfp_mask), due to the preferred_nid is not online and not instanced. Hence the bug affects all archs if a machine having a memory less numa-node, but a device on the node is used and provide numa_node info to __alloc_pages_nodemask(). This patch makes all possible node online for ppc. [1]: https://lore.kernel.org/patchwork/patch/1020838/ Signed-off-by: Pingfan Liu Cc: linuxppc-dev@lists.ozlabs.org Cc: x86@kernel.org Cc: linux-kernel@vger.kernel.org Cc: Andrew Morton Cc: Michal Hocko Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Bjorn Helgaas Cc: Jonathan Cameron Cc: David Rientjes Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman --- Note: [1-2/3] implements one way to fix the bug, while this patch tries another way. Hence using this patch when [1-2/3] is not acceptable. arch/powerpc/mm/numa.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index ce28ae5..31d81a4 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -864,10 +864,19 @@ void __init initmem_init(void) memblock_dump_all(); - for_each_online_node(nid) { + /* Instance all possible nodes to overcome potential NULL reference + * issue on node_zonelist() when using nr_cpus + */ + for_each_node(nid) { unsigned long start_pfn, end_pfn; - get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); + if (node_online(nid)) + get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); + else { + start_pfn = end_pfn = 0; + /* online it, so later zonelists[] will be built */ + node_set_online(nid); + } setup_node_data(nid, start_pfn, end_pfn); sparse_memory_present_with_active_regions(nid); }