diff mbox series

mm/z3fold: fix variable set but not used warnings

Message ID 1559220952-21081-1-git-send-email-cai@lca.pw (mailing list archive)
State New, archived
Headers show
Series mm/z3fold: fix variable set but not used warnings | expand

Commit Message

Qian Cai May 30, 2019, 12:55 p.m. UTC
The linux-next commit f41a586ddc2d ("z3fold: add inter-page compaction")
introduced a few new compilation warnings.

mm/z3fold.c: In function 'compact_single_buddy':
mm/z3fold.c:781:16: warning: variable 'newpage' set but not used
[-Wunused-but-set-variable]
mm/z3fold.c:752:13: warning: variable 'bud' set but not used
[-Wunused-but-set-variable]

It does not seem those variables are actually used, so just remove them.

Signed-off-by: Qian Cai <cai@lca.pw>
---
 mm/z3fold.c | 6 ------
 1 file changed, 6 deletions(-)
diff mbox series

Patch

diff --git a/mm/z3fold.c b/mm/z3fold.c
index 2bc3dbde6255..67c29101ffc5 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -749,7 +749,6 @@  static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr)
 	struct z3fold_pool *pool = zhdr_to_pool(zhdr);
 	void *p = zhdr;
 	unsigned long old_handle = 0;
-	enum buddy bud;
 	size_t sz = 0;
 	struct z3fold_header *new_zhdr = NULL;
 	int first_idx = __idx(zhdr, FIRST);
@@ -761,24 +760,20 @@  static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr)
 	 * the page lock is already taken
 	 */
 	if (zhdr->first_chunks && zhdr->slots->slot[first_idx]) {
-		bud = FIRST;
 		p += ZHDR_SIZE_ALIGNED;
 		sz = zhdr->first_chunks << CHUNK_SHIFT;
 		old_handle = (unsigned long)&zhdr->slots->slot[first_idx];
 	} else if (zhdr->middle_chunks && zhdr->slots->slot[middle_idx]) {
-		bud = MIDDLE;
 		p += zhdr->start_middle << CHUNK_SHIFT;
 		sz = zhdr->middle_chunks << CHUNK_SHIFT;
 		old_handle = (unsigned long)&zhdr->slots->slot[middle_idx];
 	} else if (zhdr->last_chunks && zhdr->slots->slot[last_idx]) {
-		bud = LAST;
 		p += PAGE_SIZE - (zhdr->last_chunks << CHUNK_SHIFT);
 		sz = zhdr->last_chunks << CHUNK_SHIFT;
 		old_handle = (unsigned long)&zhdr->slots->slot[last_idx];
 	}
 
 	if (sz > 0) {
-		struct page *newpage;
 		enum buddy new_bud = HEADLESS;
 		short chunks = size_to_chunks(sz);
 		void *q;
@@ -787,7 +782,6 @@  static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr)
 		if (!new_zhdr)
 			return NULL;
 
-		newpage = virt_to_page(new_zhdr);
 		if (WARN_ON(new_zhdr == zhdr))
 			goto out_fail;