From patchwork Sat Oct 19 21:45:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Khlebnikov X-Patchwork-Id: 11200425 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4918514ED for ; Sat, 19 Oct 2019 21:45:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F0EC3222C5 for ; Sat, 19 Oct 2019 21:45:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="WhkbdhaL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0EC3222C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yandex-team.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 02AB48E0005; Sat, 19 Oct 2019 17:45:25 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id F1D0E8E0003; Sat, 19 Oct 2019 17:45:24 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E325A8E0005; Sat, 19 Oct 2019 17:45:24 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id BB5518E0003 for ; Sat, 19 Oct 2019 17:45:24 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 4DDF3181AEF32 for ; Sat, 19 Oct 2019 21:45:24 +0000 (UTC) X-FDA: 76061865768.19.mine44_4c24d09e73226 X-Spam-Summary: 2,0,0,33fe3775984482da,d41d8cd98f00b204,khlebnikov@yandex-team.ru,::akpm@linux-foundation.org:linux-kernel@vger.kernel.org:rdunlap@infradead.org,RULES_HIT:41:69:152:355:379:560:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2559:2563:2682:2685:2693:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3876:3877:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:5007:6114:6261:6642:6653:9025:9207:9592:10004:10400:11026:11232:11332:11473:11537:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12760:13255:14096:14097:14181:14394:14687:14721:14922:21080:21433:21451:21627:21749:21939:30030:30054,0,RBL:5.45.199.163:@yandex-team.ru:.lbl8.mailshell.net-62.14.3.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:166,LUA_SUMMARY:none X-HE-Tag: mine44_4c24d09e73226 X-Filterd-Recvd-Size: 4115 Received: from forwardcorp1j.mail.yandex.net (forwardcorp1j.mail.yandex.net [5.45.199.163]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Oct 2019 21:45:23 +0000 (UTC) Received: from mxbackcorp2j.mail.yandex.net (mxbackcorp2j.mail.yandex.net [IPv6:2a02:6b8:0:1619::119]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id A17602E1553; Sun, 20 Oct 2019 00:45:18 +0300 (MSK) Received: from myt4-4db2488e778a.qloud-c.yandex.net (myt4-4db2488e778a.qloud-c.yandex.net [2a02:6b8:c00:884:0:640:4db2:488e]) by mxbackcorp2j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 0cxZ4mrudZ-jIeWRQNh; Sun, 20 Oct 2019 00:45:18 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1571521518; bh=mpv/3rNpDDzOLRHg2UtS9q80dpzHH4Vx3ZzURITMRC4=; h=Message-ID:Date:To:From:Subject:Cc; b=WhkbdhaLAe1prhIQH03uzIVboooPUeJhs710pRq6E7DaZvQmhsnT6kDdr10KRlJ3Q VBhzx/7Qlq0/C0xQn2W8HO+GRpHuhouljep9e9K52c9EItYjt+iiD7TmIUYKXgLgXw NC77uKCPOS0Nh3Pg6h+EIPY8B+0gV4RPilOhhdzA= Authentication-Results: mxbackcorp2j.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from unknown (unknown [2a02:6b8:b080:7010::1:5]) by myt4-4db2488e778a.qloud-c.yandex.net (nwsmtp/Yandex) with ESMTPSA id gDwauKkseK-jIICb97J; Sun, 20 Oct 2019 00:45:18 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Subject: [PATCH] mm/vmstat: do not use size of vmstat_text as count of /proc/vmstat items From: Konstantin Khlebnikov To: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Cc: Randy Dunlap Date: Sun, 20 Oct 2019 00:45:17 +0300 Message-ID: <157152151769.4139.15423465513138349343.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Strings from vmstat_text[] will be used for printing memory cgroup statistics which exists even if CONFIG_VM_EVENT_COUNTERS=n. This should be applied before patch "mm/memcontrol: use vmstat names for printing statistics". Signed-off-by: Konstantin Khlebnikov Link: https://lore.kernel.org/linux-mm/cd1c42ae-281f-c8a8-70ac-1d01d417b2e1@infradead.org/T/#u Reported-by: Randy Dunlap Acked-by: Randy Dunlap # build-tested --- mm/vmstat.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 590aeca27cab..13e36da70f3c 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1638,25 +1638,23 @@ static const struct seq_operations zoneinfo_op = { .show = zoneinfo_show, }; +#define NR_VMSTAT_ITEMS (NR_VM_ZONE_STAT_ITEMS + \ + NR_VM_NUMA_STAT_ITEMS + \ + NR_VM_NODE_STAT_ITEMS + \ + NR_VM_WRITEBACK_STAT_ITEMS + \ + (IS_ENABLED(CONFIG_VM_EVENT_COUNTERS) ? \ + NR_VM_EVENT_ITEMS : 0)) + static void *vmstat_start(struct seq_file *m, loff_t *pos) { unsigned long *v; - int i, stat_items_size; + int i; - if (*pos >= ARRAY_SIZE(vmstat_text)) + if (*pos >= NR_VMSTAT_ITEMS) return NULL; - stat_items_size = NR_VM_ZONE_STAT_ITEMS * sizeof(unsigned long) + - NR_VM_NUMA_STAT_ITEMS * sizeof(unsigned long) + - NR_VM_NODE_STAT_ITEMS * sizeof(unsigned long) + - NR_VM_WRITEBACK_STAT_ITEMS * sizeof(unsigned long); - -#ifdef CONFIG_VM_EVENT_COUNTERS - stat_items_size += sizeof(struct vm_event_state); -#endif - BUILD_BUG_ON(stat_items_size != - ARRAY_SIZE(vmstat_text) * sizeof(unsigned long)); - v = kmalloc(stat_items_size, GFP_KERNEL); + BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) < NR_VMSTAT_ITEMS); + v = kmalloc_array(NR_VMSTAT_ITEMS, sizeof(unsigned long), GFP_KERNEL); m->private = v; if (!v) return ERR_PTR(-ENOMEM); @@ -1689,7 +1687,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) static void *vmstat_next(struct seq_file *m, void *arg, loff_t *pos) { (*pos)++; - if (*pos >= ARRAY_SIZE(vmstat_text)) + if (*pos >= NR_VMSTAT_ITEMS) return NULL; return (unsigned long *)m->private + *pos; }