| Message ID | 1574166203-151975-3-git-send-email-alex.shi@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | per lruvec lru_lock for memcg | expand |
On Tue, Nov 19, 2019 at 08:23:16PM +0800, Alex Shi wrote: > ../mm/huge_memory.c: In function ‘split_huge_page_to_list’: > ../mm/huge_memory.c:2766:9: warning: ‘flags’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > lruvec = lock_page_lruvec_irqsave(head, pgdata, flags); > ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Like with the previous patch, there is no lock_page_lruvec_irqsave() at this point in the series.
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 13cc93785006..4cdfdbeb6b2b 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2699,7 +2699,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) struct address_space *mapping = NULL; int count, mapcount, extra_pins, ret; bool mlocked; - unsigned long flags; + unsigned long flags = 0; pgoff_t end; VM_BUG_ON_PAGE(is_huge_zero_page(page), page);
../mm/huge_memory.c: In function ‘split_huge_page_to_list’: ../mm/huge_memory.c:2766:9: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] lruvec = lock_page_lruvec_irqsave(head, pgdata, flags); ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)