diff mbox series

mm/kasan: Fix an compile error

Message ID 1575363013-43761-1-git-send-email-zhongjiang@huawei.com (mailing list archive)
State New, archived
Headers show
Series mm/kasan: Fix an compile error | expand

Commit Message

zhong jiang Dec. 3, 2019, 8:50 a.m. UTC
I hit the following compile error in arch/x86/

mm/kasan/common.c: In function kasan_populate_vmalloc:
mm/kasan/common.c:797:2: error: implicit declaration of function flush_cache_vmap; did you mean flush_rcu_work? [-Werror=implicit-function-declaration]
  flush_cache_vmap(shadow_start, shadow_end);
  ^~~~~~~~~~~~~~~~
  flush_rcu_work
cc1: some warnings being treated as errors
make[2]: *** [mm/kasan/common.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [mm/kasan] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [mm] Error 2
make: *** Waiting for unfinished jobs....

Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 mm/kasan/common.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Axtens Dec. 3, 2019, 11:06 p.m. UTC | #1
Hi,

Thanks, I see that Andrew has already picked this up, but for what it's
worth:

Reviewed-by: Daniel Axtens <dja@axtens.net>

Regards,
Daniel

> I hit the following compile error in arch/x86/
>
> mm/kasan/common.c: In function kasan_populate_vmalloc:
> mm/kasan/common.c:797:2: error: implicit declaration of function flush_cache_vmap; did you mean flush_rcu_work? [-Werror=implicit-function-declaration]
>   flush_cache_vmap(shadow_start, shadow_end);
>   ^~~~~~~~~~~~~~~~
>   flush_rcu_work
> cc1: some warnings being treated as errors
> make[2]: *** [mm/kasan/common.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [mm/kasan] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [mm] Error 2
> make: *** Waiting for unfinished jobs....
>
> Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  mm/kasan/common.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> index df3371d..2fa710b 100644
> --- a/mm/kasan/common.c
> +++ b/mm/kasan/common.c
> @@ -36,6 +36,7 @@
>  #include <linux/bug.h>
>  #include <linux/uaccess.h>
>  
> +#include <asm/cacheflush.h>
>  #include <asm/tlbflush.h>
>  
>  #include "kasan.h"
> -- 
> 1.7.12.4
diff mbox series

Patch

diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index df3371d..2fa710b 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -36,6 +36,7 @@ 
 #include <linux/bug.h>
 #include <linux/uaccess.h>
 
+#include <asm/cacheflush.h>
 #include <asm/tlbflush.h>
 
 #include "kasan.h"