| Message ID | 1576728650-13867-1-git-send-email-anshuman.khandual@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm: Drop elements 'hw' and 'phys_callback' from struct memory_block | expand |
On Wed, Dec 18, 2019 at 8:10 PM Anshuman Khandual <anshuman.khandual@arm.com> wrote: > > memory_block structure elements 'hw' and 'phys_callback' are not getting > used. This was originally added with commit 3947be1969a9 ("[PATCH] memory > hotplug: sysfs and add/remove functions") but never seem to have been used. > Just drop them now. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: David Hildenbrand <david@redhat.com> > Cc: Michal Hocko <mhocko@suse.com> > Cc: Pavel Tatashin <pasha.tatashin@soleen.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > include/linux/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/memory.h b/include/linux/memory.h > index 0ebb105eb261..4e95a9eb8061 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -29,8 +29,6 @@ struct memory_block { > int section_count; /* serialized by mem_sysfs_mutex */ > int online_type; /* for passing data to online routine */ > int phys_device; /* to which fru does this belong? */ > - void *hw; /* optional pointer to fw/hw data */ > - int (*phys_callback)(struct memory_block *); > struct device dev; > int nid; /* NID for this memory block */ > }; > -- > 2.20.1 Looks good. Reviewed-by: Dan Williams <dan.j.williams@intel.com>
On 19.12.19 05:10, Anshuman Khandual wrote: > memory_block structure elements 'hw' and 'phys_callback' are not getting > used. This was originally added with commit 3947be1969a9 ("[PATCH] memory > hotplug: sysfs and add/remove functions") but never seem to have been used. > Just drop them now. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: David Hildenbrand <david@redhat.com> > Cc: Michal Hocko <mhocko@suse.com> > Cc: Pavel Tatashin <pasha.tatashin@soleen.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > include/linux/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/memory.h b/include/linux/memory.h > index 0ebb105eb261..4e95a9eb8061 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -29,8 +29,6 @@ struct memory_block { > int section_count; /* serialized by mem_sysfs_mutex */ > int online_type; /* for passing data to online routine */ > int phys_device; /* to which fru does this belong? */ > - void *hw; /* optional pointer to fw/hw data */ > - int (*phys_callback)(struct memory_block *); > struct device dev; > int nid; /* NID for this memory block */ > }; > Legacy cruft :) Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/include/linux/memory.h b/include/linux/memory.h index 0ebb105eb261..4e95a9eb8061 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -29,8 +29,6 @@ struct memory_block { int section_count; /* serialized by mem_sysfs_mutex */ int online_type; /* for passing data to online routine */ int phys_device; /* to which fru does this belong? */ - void *hw; /* optional pointer to fw/hw data */ - int (*phys_callback)(struct memory_block *); struct device dev; int nid; /* NID for this memory block */ };
memory_block structure elements 'hw' and 'phys_callback' are not getting used. This was originally added with commit 3947be1969a9 ("[PATCH] memory hotplug: sysfs and add/remove functions") but never seem to have been used. Just drop them now. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: David Hildenbrand <david@redhat.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Pavel Tatashin <pasha.tatashin@soleen.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> --- include/linux/memory.h | 2 -- 1 file changed, 2 deletions(-)