From patchwork Mon Feb 3 19:18:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 11363327 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0255113B4 for ; Mon, 3 Feb 2020 19:18:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 859C620CC7 for ; Mon, 3 Feb 2020 19:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 859C620CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A50F76B0003; Mon, 3 Feb 2020 14:18:43 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9DB4D6B0005; Mon, 3 Feb 2020 14:18:43 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CB336B0006; Mon, 3 Feb 2020 14:18:43 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 71ABF6B0003 for ; Mon, 3 Feb 2020 14:18:43 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1C447181AEF15 for ; Mon, 3 Feb 2020 19:18:43 +0000 (UTC) X-FDA: 76449777726.24.milk02_4bafd16860c14 X-Spam-Summary: 10,1,0,d5502da207563210,d41d8cd98f00b204,yang.shi@linux.alibaba.com,:mhocko@suse.com:mtk.manpages@gmail.com:david@redhat.com:akpm@linux-foundation.org:yang.shi@linux.alibaba.com:linux-man@vger.kernel.org:linux-api@vger.kernel.org::linux-kernel@vger.kernel.org,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1261:1345:1437:1534:1542:1711:1730:1747:1777:1792:2393:2559:2562:2895:2898:3138:3139:3140:3141:3142:3355:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6119:6261:7514:10007:11026:11658:11914:12048:12296:12297:12555:12895:13161:13200:13229:14181:14721:21060:21067:21080:21094:21323:21451:21627:21740:21990:30034:30046:30054:30070,0,RBL:115.124.30.131:@linux.alibaba.com:.lbl8.mailshell.net-62.20.2.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:none,Custom_rules:0:1:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: milk02_4bafd16860c14 X-Filterd-Recvd-Size: 3833 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 19:18:39 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R671e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0Tp5Lrnz_1580757507; Received: from localhost(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0Tp5Lrnz_1580757507) by smtp.aliyun-inc.com(127.0.0.1); Tue, 04 Feb 2020 03:18:34 +0800 From: Yang Shi To: mhocko@suse.com, mtk.manpages@gmail.com, david@redhat.com, akpm@linux-foundation.org Cc: yang.shi@linux.alibaba.com, linux-man@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [v3 PATCH] move_pages.2: Returning positive value is a new error case Date: Tue, 4 Feb 2020 03:18:27 +0800 Message-Id: <1580757507-120233-1-git-send-email-yang.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit a49bd4d71637 ("mm, numa: rework do_pages_move"), the semantic of move_pages() has changed to return the number of non-migrated pages if they were result of a non-fatal reasons (usually a busy page). This was an unintentional change that hasn't been noticed except for LTP tests which checked for the documented behavior. There are two ways to go around this change. We can even get back to the original behavior and return -EAGAIN whenever migrate_pages is not able to migrate pages due to non-fatal reasons. Another option would be to simply continue with the changed semantic and extend move_pages documentation to clarify that -errno is returned on an invalid input or when migration simply cannot succeed (e.g. -ENOMEM, -EBUSY) or the number of pages that couldn't have been migrated due to ephemeral reasons (e.g. page is pinned or locked for other reasons). We decided to keep the second option in kernel because this behavior is in place for some time without anybody complaining and possibly new users depending on it. Also it allows to have a slightly easier error handling as the caller knows that it is worth to retry when err > 0. Update man pages to reflect the new semantic. Cc: Michal Hocko Cc: Michael Kerrisk Signed-off-by: Yang Shi Acked-by: Michal Hocko --- v3: * Fixed the comments from David Hildenbrand. * Fixed the inaccuracy about pre-initialized status array values. v2: * Added notes about status array per Michal. * Added Michal's Acked-by. man2/move_pages.2 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/man2/move_pages.2 b/man2/move_pages.2 index 1bf1053..50c83a4 100644 --- a/man2/move_pages.2 +++ b/man2/move_pages.2 @@ -104,7 +104,9 @@ pages that need to be moved. is an array of integers that return the status of each page. The array contains valid values only if .BR move_pages () -did not return an error. +did not return an error. Pre-initialization of the array to the value +which cannot represent a real numa node or valid error of status array +could help to identify pages that have been migrated .PP .I flags specify what types of pages to move. @@ -164,9 +166,13 @@ returns zero. .\" do the right thing? On error, it returns \-1, and sets .I errno -to indicate the error. +to indicate the error. If positive value is returned, it is the number of +non-migrated pages. .SH ERRORS .TP +.B Positive value +The number of non-migrated pages if they were the result of non-fatal +reasons (since version 4.17). .B E2BIG Too many pages to move. Since Linux 2.6.29,