| Message ID | 1590561903-13186-2-git-send-email-iamjoonsoo.kim@lge.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clean-up the migration target allocation functions | expand |
On 5/27/20 8:44 AM, js1304@gmail.com wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > For locality, it's better to migrate the page to the same node > rather than the node of the current caller's cpu. Should be, yeah. > Acked-by: Roman Gushchin <guro@fb.com> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/page_isolation.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 2c11a38..7df89bd 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > > struct page *alloc_migrate_target(struct page *page, unsigned long private) > { > - return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]); > + int nid = page_to_nid(page); > + > + return new_page_nodemask(page, nid, &node_states[N_MEMORY]); I wonder why this and others uses node_states[N_MEMORY] and not just NULL. But maybe that's addressed later. > } >
On Wed 27-05-20 15:44:52, Joonsoo Kim wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > For locality, it's better to migrate the page to the same node > rather than the node of the current caller's cpu. > > Acked-by: Roman Gushchin <guro@fb.com> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/page_isolation.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 2c11a38..7df89bd 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > > struct page *alloc_migrate_target(struct page *page, unsigned long private) > { > - return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]); > + int nid = page_to_nid(page); > + > + return new_page_nodemask(page, nid, &node_states[N_MEMORY]); > } > -- > 2.7.4
diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 2c11a38..7df89bd 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, struct page *alloc_migrate_target(struct page *page, unsigned long private) { - return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]); + int nid = page_to_nid(page); + + return new_page_nodemask(page, nid, &node_states[N_MEMORY]); }