| Message ID | 1592371583-30672-7-git-send-email-iamjoonsoo.kim@lge.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | workingset protection/detection on the anonymous LRU list | expand |
On 6/17/20 7:26 AM, js1304@gmail.com wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > Now, workingset detection is implemented for anonymous LRU. > We don't have to worry about the misfound for workingset due to > the ratio of active/inactive. Let's restore the ratio. How about: Now that workingset detection is implemented for anonymous LRU, we don't need large inactive list to allow detecting frequently accessed pages before they are reclaimed, anymore. This effectively reverts the temporary measure put in by commit "mm/vmscan: make active/inactive ratio as 1:1 for anon lru". > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> Thanks! I still hope Matthew can review updated patch 4/6 (I'm not really familiar with proper xarray handling), and Johannes patch 5/6. And then we just need a nice Documentation file describing how reclaim really works after all the recent changes :) Vlastimil > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index eb02d18..ec77691 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2211,7 +2211,7 @@ static bool inactive_is_low(struct lruvec *lruvec, enum lru_list inactive_lru) > active = lruvec_page_state(lruvec, NR_LRU_BASE + active_lru); > > gb = (inactive + active) >> (30 - PAGE_SHIFT); > - if (gb && is_file_lru(inactive_lru)) > + if (gb) > inactive_ratio = int_sqrt(10 * gb); > else > inactive_ratio = 1; >
2020년 7월 2일 (목) 오후 10:45, Vlastimil Babka <vbabka@suse.cz>님이 작성: > > On 6/17/20 7:26 AM, js1304@gmail.com wrote: > > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > > > Now, workingset detection is implemented for anonymous LRU. > > We don't have to worry about the misfound for workingset due to > > the ratio of active/inactive. Let's restore the ratio. > > How about: > > Now that workingset detection is implemented for anonymous LRU, we don't need > large inactive list to allow detecting frequently accessed pages before they are > reclaimed, anymore. This effectively reverts the temporary measure put in by > commit "mm/vmscan: make active/inactive ratio as 1:1 for anon lru". Much better!. I will use the comment you suggested. Thanks. > > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > Acked-by: Vlastimil Babka <vbabka@suse.cz> > > Thanks! > I still hope Matthew can review updated patch 4/6 (I'm not really familiar with > proper xarray handling), and Johannes patch 5/6. Okay, I hope so, too. :) > And then we just need a nice Documentation file describing how reclaim really > works after all the recent changes :) Agreed. Thanks.
diff --git a/mm/vmscan.c b/mm/vmscan.c index eb02d18..ec77691 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2211,7 +2211,7 @@ static bool inactive_is_low(struct lruvec *lruvec, enum lru_list inactive_lru) active = lruvec_page_state(lruvec, NR_LRU_BASE + active_lru); gb = (inactive + active) >> (30 - PAGE_SHIFT); - if (gb && is_file_lru(inactive_lru)) + if (gb) inactive_ratio = int_sqrt(10 * gb); else inactive_ratio = 1;