From patchwork Wed Jul 1 22:14:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 11637423 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A211713B4 for ; Wed, 1 Jul 2020 22:14:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6241420853 for ; Wed, 1 Jul 2020 22:14:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BH6+HlR9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6241420853 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35CD48D002B; Wed, 1 Jul 2020 18:14:50 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 25CA88D0059; Wed, 1 Jul 2020 18:14:50 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0851A8D0056; Wed, 1 Jul 2020 18:14:50 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id DA5798D002E for ; Wed, 1 Jul 2020 18:14:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 64A12181AC9CC for ; Wed, 1 Jul 2020 22:14:49 +0000 (UTC) X-FDA: 76990912698.13.rifle29_050779926e84 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 38E4918140B67 for ; Wed, 1 Jul 2020 22:14:49 +0000 (UTC) X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,bhsharma@redhat.com,,RULES_HIT:30003:30012:30051:30054:30075:30090,0,RBL:207.211.31.81:@redhat.com:.lbl8.mailshell.net-62.18.0.100 66.10.201.10;04yfnc4qkndt6ccuqoruer67i3jf8ocrgiaww95qjknoqbfq3ignen8rqj858hc.bpyc4j5oeptns7wyw59okbetezi7ix4tib53xpg4ku9i4pge6s8er4sftufrpdc.g-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: rifle29_050779926e84 X-Filterd-Recvd-Size: 8719 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 22:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593641687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=bQb32/SaJZufmc/q7s+tyKjNogq0Gy4EIBWlQy//p8M=; b=BH6+HlR9W5p4djUg7CedDmfVdRTFwShfOM+jdWKSS+9Pnxoh12G2Qhid5ElGtjS0A9d2+d i4gXtYfYXJsySu+i7yceryaK2fca4gqGLK/+ZbR0yxPmYSbwkn/DfkQg287a1HIkhvE5Am HH/taZzC70L28WGYF9dA+3OOdyHu5L8= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-oyf_wncUN9CH1vtZdt8nOQ-1; Wed, 01 Jul 2020 18:14:46 -0400 X-MC-Unique: oyf_wncUN9CH1vtZdt8nOQ-1 Received: by mail-pg1-f200.google.com with SMTP id i1so19015255pgn.13 for ; Wed, 01 Jul 2020 15:14:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bQb32/SaJZufmc/q7s+tyKjNogq0Gy4EIBWlQy//p8M=; b=WuZfJhPP9vDCUGllX/KIUx0SUeElRFufXoSBnjRRxSQo6/FnXSXS/UpQhmuD1UEMT+ i3kB+ehueW/CTt5LuKyuycYVUk1jRNGSwpif6DI8eZA2GPiEiQqSRGEYgFoDSvLoXZ2b ELBM64JzX1A2ONWRDwJmQeO+m2Mp+ekgioNf44GpTypsRKNDqVlK7XfeWn/XQJDiJWyj 5JZKzKZI8kZGgNlCkCYJvZtrwY4CoLlJBBZvXl6Vf6RQ45sThPg7mZkkCSV23q3j2gkG 2mGBzlFYX819peFZxMcnVZAFTYvUOkRkvsJhhTWZWS2mnZ3YWFVM69vpNXbfFnIG8Vp4 WguA== X-Gm-Message-State: AOAM531KlzIQD13edqTPhjaEtDvbgFtaBG+S/TlbW1P9UQ4KdfTH5vwN +PkmaNbE8kDkvL2iEleuwiwrk2wBi9o5AtrF5aeBrKCbXtSuTLz28XSkDhiYHSrjPOwT5NpeQj0 ukCI5ydey20I= X-Received: by 2002:a17:902:fe11:: with SMTP id g17mr24013372plj.145.1593641684948; Wed, 01 Jul 2020 15:14:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFdvc/WtQ+mMt1LPHoxqyDf9VjA9s5BpTGQK1trOcKSTKxk2LHBrXcJPTmY4MjY2gBSv/yxw== X-Received: by 2002:a17:902:fe11:: with SMTP id g17mr24013361plj.145.1593641684671; Wed, 01 Jul 2020 15:14:44 -0700 (PDT) Received: from localhost ([110.227.183.4]) by smtp.gmail.com with ESMTPSA id m12sm6091920pjf.17.2020.07.01.15.14.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jul 2020 15:14:44 -0700 (PDT) From: Bhupesh Sharma To: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Cc: bhsharma@redhat.com, bhupesh.linux@gmail.com, Johannes Weiner , Michal Hocko , Vladimir Davydov , James Morse , Mark Rutland , Will Deacon , Catalin Marinas , linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: [PATCH 1/2] mm/memcontrol: Fix OOPS inside mem_cgroup_get_nr_swap_pages() Date: Thu, 2 Jul 2020 03:44:19 +0530 Message-Id: <1593641660-13254-2-git-send-email-bhsharma@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1593641660-13254-1-git-send-email-bhsharma@redhat.com> References: <1593641660-13254-1-git-send-email-bhsharma@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bhsharma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Rspamd-Queue-Id: 38E4918140B67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Prabhakar reported an OOPS inside mem_cgroup_get_nr_swap_pages() function in a corner case seen on some arm64 boards when kdump kernel runs with "cgroup_disable=memory" passed to the kdump kernel via bootargs. The root-cause behind the same is that currently mem_cgroup_swap_init() function is implemented as a subsys_initcall() call instead of a core_initcall(), this means 'cgroup_memory_noswap' still remains set to the default value (false) even when memcg is disabled via "cgroup_disable=memory" boot parameter. This may result in premature OOPS inside mem_cgroup_get_nr_swap_pages() function in corner cases: [ 0.265617] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000188 [ 0.274495] Mem abort info: [ 0.277311] ESR = 0x96000006 [ 0.280389] EC = 0x25: DABT (current EL), IL = 32 bits [ 0.285751] SET = 0, FnV = 0 [ 0.288830] EA = 0, S1PTW = 0 [ 0.291995] Data abort info: [ 0.294897] ISV = 0, ISS = 0x00000006 [ 0.298765] CM = 0, WnR = 0 [ 0.301757] [0000000000000188] user address but active_mm is swapper [ 0.308174] Internal error: Oops: 96000006 [#1] SMP [ 0.313097] Modules linked in: <..snip..> [ 0.331384] pstate: 00400009 (nzcv daif +PAN -UAO BTYPE=--) [ 0.337014] pc : mem_cgroup_get_nr_swap_pages+0x9c/0xf4 [ 0.342289] lr : mem_cgroup_get_nr_swap_pages+0x68/0xf4 [ 0.347564] sp : fffffe0012b6f800 [ 0.350905] x29: fffffe0012b6f800 x28: fffffe00116b3000 [ 0.356268] x27: fffffe0012b6fb00 x26: 0000000000000020 [ 0.361631] x25: 0000000000000000 x24: fffffc00723ffe28 [ 0.366994] x23: fffffe0010d5b468 x22: fffffe00116bfa00 [ 0.372357] x21: fffffe0010aabda8 x20: 0000000000000000 [ 0.377720] x19: 0000000000000000 x18: 0000000000000010 [ 0.383082] x17: 0000000043e612f2 x16: 00000000a9863ed7 [ 0.388445] x15: ffffffffffffffff x14: 202c303d70617773 [ 0.393808] x13: 6f6e5f79726f6d65 x12: 6d5f70756f726763 [ 0.399170] x11: 2073656761705f70 x10: 6177735f726e5f74 [ 0.404533] x9 : fffffe00100e9580 x8 : fffffe0010628160 [ 0.409895] x7 : 00000000000000a8 x6 : fffffe00118f5e5e [ 0.415258] x5 : 0000000000000001 x4 : 0000000000000000 [ 0.420621] x3 : 0000000000000000 x2 : 0000000000000000 [ 0.425983] x1 : 0000000000000000 x0 : fffffc0060079000 [ 0.431346] Call trace: [ 0.433809] mem_cgroup_get_nr_swap_pages+0x9c/0xf4 [ 0.438735] shrink_lruvec+0x404/0x4f8 [ 0.442516] shrink_node+0x1a8/0x688 [ 0.446121] do_try_to_free_pages+0xe8/0x448 [ 0.450429] try_to_free_pages+0x110/0x230 [ 0.454563] __alloc_pages_slowpath.constprop.106+0x2b8/0xb48 [ 0.460366] __alloc_pages_nodemask+0x2ac/0x2f8 [ 0.464938] alloc_page_interleave+0x20/0x90 [ 0.469246] alloc_pages_current+0xdc/0xf8 [ 0.473379] atomic_pool_expand+0x60/0x210 [ 0.477514] __dma_atomic_pool_init+0x50/0xa4 [ 0.481910] dma_atomic_pool_init+0xac/0x158 [ 0.486220] do_one_initcall+0x50/0x218 [ 0.490091] kernel_init_freeable+0x22c/0x2d0 [ 0.494489] kernel_init+0x18/0x110 [ 0.498007] ret_from_fork+0x10/0x18 [ 0.501614] Code: aa1403e3 91106000 97f82a27 14000011 (f940c663) [ 0.507770] ---[ end trace 9795948475817de4 ]--- [ 0.512429] Kernel panic - not syncing: Fatal exception [ 0.517705] Rebooting in 10 seconds.. Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: James Morse Cc: Mark Rutland Cc: Will Deacon Cc: Catalin Marinas Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org Reported-by: Prabhakar Kushwaha Signed-off-by: Bhupesh Sharma Acked-by: Michal Hocko --- mm/memcontrol.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 19622328e4b5..8323e4b7b390 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -7186,6 +7186,13 @@ static struct cftype memsw_files[] = { { }, /* terminate */ }; +/* + * If mem_cgroup_swap_init() is implemented as a subsys_initcall() + * instead of a core_initcall(), this could mean cgroup_memory_noswap still + * remains set to false even when memcg is disabled via "cgroup_disable=memory" + * boot parameter. This may result in premature OOPS inside + * mem_cgroup_get_nr_swap_pages() function in corner cases. + */ static int __init mem_cgroup_swap_init(void) { /* No memory control -> no swap control */ @@ -7200,6 +7207,6 @@ static int __init mem_cgroup_swap_init(void) return 0; } -subsys_initcall(mem_cgroup_swap_init); +core_initcall(mem_cgroup_swap_init); #endif /* CONFIG_MEMCG_SWAP */