From patchwork Wed Dec 30 06:59:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abaci Team X-Patchwork-Id: 11993017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7DDC433DB for ; Wed, 30 Dec 2020 06:59:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9316420791 for ; Wed, 30 Dec 2020 06:59:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9316420791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9FCDA8D009D; Wed, 30 Dec 2020 01:59:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ADA38D007F; Wed, 30 Dec 2020 01:59:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C4878D009D; Wed, 30 Dec 2020 01:59:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 76E778D007F for ; Wed, 30 Dec 2020 01:59:45 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 39A7A1EE6 for ; Wed, 30 Dec 2020 06:59:45 +0000 (UTC) X-FDA: 77649048330.17.force16_5f0ae81274a3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 14781180D0180 for ; Wed, 30 Dec 2020 06:59:45 +0000 (UTC) X-HE-Tag: force16_5f0ae81274a3 X-Filterd-Recvd-Size: 1807 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Dec 2020 06:59:42 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UKChRao_1609311552; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UKChRao_1609311552) by smtp.aliyun-inc.com(127.0.0.1); Wed, 30 Dec 2020 14:59:34 +0800 From: YANG LI To: hannes@cmpxchg.org Cc: mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, YANG LI Subject: [PATCH] mm: fix: Uninitialized variable ret. Date: Wed, 30 Dec 2020 14:59:11 +0800 Message-Id: <1609311551-97108-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The ret is being used but it isn't being initialized, need to assign a value to it, like 0. Signed-off-by: YANG LI Reported-by: Abaci --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 605f671..15ba17d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3366,7 +3366,7 @@ static int mem_cgroup_resize_max(struct mem_cgroup *memcg, { bool enlarge = false; bool drained = false; - int ret; + int ret = 0; bool limits_invariant; struct page_counter *counter = memsw ? &memcg->memsw : &memcg->memory;