diff mbox series

mm/swap_slots.c: remove redundant NULL check

Message ID 1611214229-11225-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive)
State New
Headers show
Series mm/swap_slots.c: remove redundant NULL check | expand

Commit Message

Abaci Team Jan. 21, 2021, 7:30 a.m. UTC
Fix below warnings reported by coccicheck:
./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing
functions is not needed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
 mm/swap_slots.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Hildenbrand Feb. 2, 2021, 10:12 a.m. UTC | #1
On 21.01.21 08:30, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing
> functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
>   mm/swap_slots.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/swap_slots.c b/mm/swap_slots.c
> index 0357fbe..be9de6d 100644
> --- a/mm/swap_slots.c
> +++ b/mm/swap_slots.c
> @@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
>   			cache->slots_ret = NULL;
>   		}
>   		spin_unlock_irq(&cache->free_lock);
> -		if (slots)
> -			kvfree(slots);
> +		kvfree(slots);
>   	}
>   }
>   
> 

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/mm/swap_slots.c b/mm/swap_slots.c
index 0357fbe..be9de6d 100644
--- a/mm/swap_slots.c
+++ b/mm/swap_slots.c
@@ -193,8 +193,7 @@  static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
 			cache->slots_ret = NULL;
 		}
 		spin_unlock_irq(&cache->free_lock);
-		if (slots)
-			kvfree(slots);
+		kvfree(slots);
 	}
 }