diff mbox series

mm/memcontrol: remove redundant NULL check

Message ID 1611216029-34397-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive)
State New
Headers show
Series mm/memcontrol: remove redundant NULL check | expand

Commit Message

Abaci Team Jan. 21, 2021, 8 a.m. UTC
Fix below warnings reported by coccicheck:
./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing
functions is not needed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
 mm/memcontrol.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Hildenbrand Feb. 2, 2021, 10:12 a.m. UTC | #1
On 21.01.21 09:00, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing
> functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
>   mm/memcontrol.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 605f671..f6a561b 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
>   	for_each_node(nid) {
>   		pn = mem_cgroup_nodeinfo(memcg, nid);
>   		map = rcu_dereference_protected(pn->shrinker_map, true);
> -		if (map)
> -			kvfree(map);
> +		kvfree(map);
>   		rcu_assign_pointer(pn->shrinker_map, NULL);
>   	}
>   }
> 

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 605f671..f6a561b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -447,8 +447,7 @@  static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
 	for_each_node(nid) {
 		pn = mem_cgroup_nodeinfo(memcg, nid);
 		map = rcu_dereference_protected(pn->shrinker_map, true);
-		if (map)
-			kvfree(map);
+		kvfree(map);
 		rcu_assign_pointer(pn->shrinker_map, NULL);
 	}
 }