| Message ID | 1611643468-52233-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/hugetlb: Simplify the calculation of variables | expand |
Hi: On 2021/1/26 14:44, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to > !A || B. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > --- > mm/hugetlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index cbf32d2..5e6a6e7 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) > mpol_allowed = policy_nodemask_current(gfp_mask); > > for_each_node_mask(node, cpuset_current_mems_allowed) { > - if (!mpol_allowed || > - (mpol_allowed && node_isset(node, *mpol_allowed))) > + if (!mpol_allowed || node_isset(node, *mpol_allowed)) > nr += array[node]; > } > > I'm gonna do this too. :) Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
On 1/25/21 10:44 PM, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to > !A || B. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > --- > mm/hugetlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index cbf32d2..5e6a6e7 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) mpol_allowed = policy_nodemask_current(gfp_mask); for_each_node_mask(node, cpuset_current_mems_allowed) { - if (!mpol_allowed || - (mpol_allowed && node_isset(node, *mpol_allowed))) + if (!mpol_allowed || node_isset(node, *mpol_allowed)) nr += array[node]; }
Fix the following coccicheck warnings: ./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> --- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)