diff mbox series

slab: Use %s instead of function name

Message ID 1624013943-13935-1-git-send-email-gumingtao@xiaomi.com (mailing list archive)
State New
Headers show
Series slab: Use %s instead of function name | expand

Commit Message

gumingtao June 18, 2021, 10:59 a.m. UTC
It is better to replace the function name with %s.

Signed-off-by: gumingtao <gumingtao@xiaomi.com>
---
 mm/slab_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lukas Bulwahn June 18, 2021, 12:03 p.m. UTC | #1
On Fri, Jun 18, 2021 at 12:59 PM gumingtao <gumingtao1225@gmail.com> wrote:
>
> It is better to replace the function name with %s.
>
> Signed-off-by: gumingtao <gumingtao@xiaomi.com>
> ---
>  mm/slab_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index a4a5714..36127dc 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name,
>                         panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",

I am just wondering:

Can you also make that refactoring change for the panic() call as well?

How about checking the whole file for such patterns and doing that
change for all occurrences?


>                                 name, err);
>                 else {
> -                       pr_warn("kmem_cache_create(%s) failed with error %d\n",
> -                               name, err);
> +                       pr_warn("%s(%s) failed with error %d\n",
> +                               __func__, name, err);
>                         dump_stack();
>                 }
>                 return NULL;
> --
> 2.7.4
>
David Rientjes June 18, 2021, 7:32 p.m. UTC | #2
On Fri, 18 Jun 2021, Lukas Bulwahn wrote:

> > It is better to replace the function name with %s.
> >
> > Signed-off-by: gumingtao <gumingtao@xiaomi.com>
> > ---
> >  mm/slab_common.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > index a4a5714..36127dc 100644
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name,
> >                         panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
> 
> I am just wondering:
> 
> Can you also make that refactoring change for the panic() call as well?
> 
> How about checking the whole file for such patterns and doing that
> change for all occurrences?
> 

Yeah, that would be ideal if gumingtao is willing to do it.  These are 
some instances where the function name actually mismatches.  gumingtao, 
would you be willing to do this?
diff mbox series

Patch

diff --git a/mm/slab_common.c b/mm/slab_common.c
index a4a5714..36127dc 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -381,8 +381,8 @@  kmem_cache_create_usercopy(const char *name,
 			panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
 				name, err);
 		else {
-			pr_warn("kmem_cache_create(%s) failed with error %d\n",
-				name, err);
+			pr_warn("%s(%s) failed with error %d\n",
+				__func__, name, err);
 			dump_stack();
 		}
 		return NULL;