[v2] mm: skip current when memcg reclaim

Commit Message

Zhaoyang Huang Oct. 19, 2021, 7:29 a.m. UTC

From: Zhaoyang Huang <[e-mail]>

Reclaiming pages from current LRU will introduce page thrashing during direct
reclaiming. Have all memory contraint groups steal pages from the processes
under root(Non-memory sensitive) or other groups with lower thresholds(high
memory tolerance) or the one totally sleeping(not busy for the time being,
borrow some pages).With regard to all groups trapping into direct reclaim,
retry if first round failed and all groups still compete fairly.

Signed-off-by: Zhaoyang Huang <[e-mail]>
---
patch v2: grant current second chance if previous reclaiming failed
---
---
 mm/vmscan.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Michal Hocko Oct. 19, 2021, 8:55 a.m. UTC | #1

On Tue 19-10-21 15:29:36, Huangzhaoyang wrote:
> From: Zhaoyang Huang <[e-mail]>
> 
> Reclaiming pages from current LRU will introduce page thrashing during direct
> reclaiming. Have all memory contraint groups steal pages from the processes
> under root(Non-memory sensitive) or other groups with lower thresholds(high
> memory tolerance) or the one totally sleeping(not busy for the time being,
> borrow some pages).With regard to all groups trapping into direct reclaim,
> retry if first round failed and all groups still compete fairly.
> 
> Signed-off-by: Zhaoyang Huang <[e-mail]>
> ---
> patch v2: grant current second chance if previous reclaiming failed

It would be really better to wait until a discussion around the previous
version is concluded before posting another one.
Btw. this changelog has some serious gaps in both the problem and
solution description. Please spend some time looking at other changelogs
for MM patches to get some idea about the level of details that we
usually require.

Thanks!

Patch

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5199b96..c17ef60 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2841,6 +2841,13 @@  static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
 				sc->memcg_low_skipped = 1;
 				continue;
 			}
+			/*
+			 * Don't bother current when its memcg is below low
+			 */
+			if (get_mem_cgroup_from_mm(current->mm) == memcg) {
+				sc->memcg_low_skipped = 1;
+				continue;
+			}
 			memcg_memory_event(memcg, MEMCG_LOW);
 		}