| Message ID | 1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | memblock tests: compiling error | expand |
On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote: > > memblock.o: In function `memblock_find_in_range.constprop.9': > memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' > memblock.o: In function `memblock_mark_mirror': > memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' > what is the steps to hit this compile error ? > Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not > specified") > Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") > > Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> > --- > tools/testing/memblock/internal.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h > index c2a492c..cf67e6e 100644 > --- a/tools/testing/memblock/internal.h > +++ b/tools/testing/memblock/internal.h > @@ -9,6 +9,9 @@ > static int memblock_debug = 1; > #endif > > +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); > + > +bool mirrored_kernelcore = false; > struct page {}; > > void memblock_free_pages(struct page *page, unsigned long pfn, > -- > 1.8.3.1 > >
On 7/26/22 18:01, Souptick Joarder wrote: > On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote: >> >> memblock.o: In function `memblock_find_in_range.constprop.9': >> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >> memblock.o: In function `memblock_mark_mirror': >> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >> > > what is the steps to hit this compile error ? or what kernel .config file? > >> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >> specified") >> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") >> >> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> >> --- >> tools/testing/memblock/internal.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h >> index c2a492c..cf67e6e 100644 >> --- a/tools/testing/memblock/internal.h >> +++ b/tools/testing/memblock/internal.h >> @@ -9,6 +9,9 @@ >> static int memblock_debug = 1; >> #endif >> >> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); >> + >> +bool mirrored_kernelcore = false; >> struct page {}; >> >> void memblock_free_pages(struct page *page, unsigned long pfn, >> -- >> 1.8.3.1 >> >>
On 2022/7/27 9:01, Souptick Joarder wrote: > On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote: >> >> memblock.o: In function `memblock_find_in_range.constprop.9': >> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >> memblock.o: In function `memblock_mark_mirror': >> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >> > > what is the steps to hit this compile error ? Do make -C tools/testing/memblock can hit this compile error. > >> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >> specified") >> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") >> >> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> >> --- >> tools/testing/memblock/internal.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h >> index c2a492c..cf67e6e 100644 >> --- a/tools/testing/memblock/internal.h >> +++ b/tools/testing/memblock/internal.h >> @@ -9,6 +9,9 @@ >> static int memblock_debug = 1; >> #endif >> >> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); >> + >> +bool mirrored_kernelcore = false; >> struct page {}; >> >> void memblock_free_pages(struct page *page, unsigned long pfn, >> -- >> 1.8.3.1 >> >>
On 2022/7/26 11:05, Liu Xinpeng wrote: > memblock.o: In function `memblock_find_in_range.constprop.9': > memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' > memblock.o: In function `memblock_mark_mirror': > memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' > > Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not > specified") Fixs should not have word warp. Tested-by: Ma Wupeng <mawupeng1@huawei.com> > Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") > > Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> > --- > tools/testing/memblock/internal.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h > index c2a492c..cf67e6e 100644 > --- a/tools/testing/memblock/internal.h > +++ b/tools/testing/memblock/internal.h > @@ -9,6 +9,9 @@ > static int memblock_debug = 1; > #endif > > +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); > + > +bool mirrored_kernelcore = false; > struct page {}; > > void memblock_free_pages(struct page *page, unsigned long pfn,
>On 2022/7/26 11:05, Liu Xinpeng wrote: >> memblock.o: In function `memblock_find_in_range.constprop.9': >> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >> memblock.o: In function `memblock_mark_mirror': >> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >> specified") >Fixs should not have word warp. >Tested-by: Ma Wupeng <mawupeng1@huawei.com> I will send patch v2, such as, Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") > +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); And removed the comma. thanks your test, Liu Xinpeng
On 2022/7/27 10:06, liuxp11@chinatelecom.cn wrote: >> On 2022/7/26 11:05, Liu Xinpeng wrote: >>> memblock.o: In function `memblock_find_in_range.constprop.9': >>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >>> memblock.o: In function `memblock_mark_mirror': >>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >>> specified") >> Fixs should not have word warp. > >> Tested-by: Ma Wupeng<mawupeng1@huawei.com> > I will send patch v2, such as, > > Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not > specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") no, see https://kernel.org/doc/html/latest/process/submitting-patches.html please check fixes part. >> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); > And removed the comma. > > > thanks your test, > Liu Xinpeng >
diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h index c2a492c..cf67e6e 100644 --- a/tools/testing/memblock/internal.h +++ b/tools/testing/memblock/internal.h @@ -9,6 +9,9 @@ static int memblock_debug = 1; #endif +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); + +bool mirrored_kernelcore = false; struct page {}; void memblock_free_pages(struct page *page, unsigned long pfn,
memblock.o: In function `memblock_find_in_range.constprop.9': memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' memblock.o: In function `memblock_mark_mirror': memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not specified") Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> --- tools/testing/memblock/internal.h | 3 +++ 1 file changed, 3 insertions(+)