From patchwork Mon Aug 29 09:46:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaixu Xia X-Patchwork-Id: 12957613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E433AECAAD4 for ; Mon, 29 Aug 2022 09:47:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C809940008; Mon, 29 Aug 2022 05:47:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2508F940007; Mon, 29 Aug 2022 05:47:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F22F940008; Mon, 29 Aug 2022 05:47:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EF7A9940007 for ; Mon, 29 Aug 2022 05:47:09 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BDC871C5B5D for ; Mon, 29 Aug 2022 09:47:09 +0000 (UTC) X-FDA: 79852151778.05.05E6A3C Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf12.hostedemail.com (Postfix) with ESMTP id 6AB224001F for ; Mon, 29 Aug 2022 09:47:09 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso14068630pjh.5 for ; Mon, 29 Aug 2022 02:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc; bh=WCWvh4lo94fZ8ZBFtAu0Nlm75Eg+DNVgcN8RUJinllU=; b=J+GEvp1aNPQ/lMGxZ0Ih9OYwR550sY4wPsU1jBeRdYWP/H+pKXR/pLdWbS8IR8qw0o VCr18L8cQyRIk2fNPQIfw+rthUV7UGn6+hmid/1BKMJvt4Dc77I3BFdZOD0rEM6fFUJH mSpVhr+pdZbJoz7tibho8YlpMgWcZvWGRK+SGjJeiImU6oDEBmlFpXjpvw3OLJAG5XLj 79pgQLdLl1+yXALQKgMjdFoGrooq8BLs+WfNC5B7zUr/ZNrQhXFLwybTjyEZxxckcLqw 1PtHM2JIgoGjqXomZ1JLEFd+Bp4VPrC3hWPFXGJ7lGAWiuQKyFLuUq6x4Y5MSR4FG5pU LY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=WCWvh4lo94fZ8ZBFtAu0Nlm75Eg+DNVgcN8RUJinllU=; b=yXGUOsRSpQ4uDUvbWtwWUuRNRXj9/pcy8tUSllOvjxr+xjqzvKYBqW1JSgsHZkGLsQ 0SoC35hb8kD4LZKzQ9bL7JKRkfS+dVVJrNDCCP33jRk5OoEmkOMA7qY0gNumdhULP23j Svc0fEFZH1O3cKOaoKYWwNuZcMDu+1dIm9cYjzytXK4AECAwXLE0gnKS6Mv93XesGSJ3 bdMAuyMcdRgyuEJt43qcBu89Es72OScEvcbi2ndwfFR8IBqHRG6R516IckRez2rBi+C7 CT8aCe6KElLbvUU9TVz1aTufxdeYMtk+b7PGU2R1ulpxBjA/nekERT+lz0js8zR97Hqv 0GZg== X-Gm-Message-State: ACgBeo0WpfDQgyZyyFTgEoL7DEfHhAvEVvR/pyoDBkfhdo3cRWaf48Xr mw1m+yTcF8OtW7il2Bu4/A== X-Google-Smtp-Source: AA6agR4UHapZ8kLe3GaRmB8rX3Cc88S3xMaDmHkYryxb9UGyCfBRhCVfinlNXxAKKiBApXkhoNieUg== X-Received: by 2002:a17:903:18a:b0:16f:e43:efdf with SMTP id z10-20020a170903018a00b0016f0e43efdfmr15514244plg.157.1661766428407; Mon, 29 Aug 2022 02:47:08 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.4]) by smtp.gmail.com with ESMTPSA id p3-20020a1709028a8300b00162529828aesm6967306plo.109.2022.08.29.02.47.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Aug 2022 02:47:07 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH] mm/damon: get the hotness from damon_hot_score() in damon_pageout_score() Date: Mon, 29 Aug 2022 17:46:06 +0800 Message-Id: <1661766366-20998-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661766429; a=rsa-sha256; cv=none; b=E00x+VYNSBhwkEPqvj214bAnOZJP0SZoc8PUfB1pZ9aZedKxEUfnUp1wrTYKa0QWOkLVIl P1GUOeItH23CM9rta/kga2i5JMMEVXDlvN/3xgGNCI+ZgAr/3NN5OVF+ozmRs4I8NUQ4d+ +MTScejcdI3fDB9Kae7NY9m2zWW8k7c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J+GEvp1a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661766429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=WCWvh4lo94fZ8ZBFtAu0Nlm75Eg+DNVgcN8RUJinllU=; b=ZaTm3nvhR1McC2Sa7aNUAPB7c2425z2VQKEFQw8Oc4QNoXVDVD1Ikz00eQgWpjsb+RwSrg mNW4aRnC4zRIsztuCyWMjvpJX8W36T17aKBL4f0o19XHhlQrwDllh+DIh6eL1GUjm4coET t4zNygfxhS/Xlxu8P/q3PnMlEF+WTPw= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J+GEvp1a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6AB224001F X-Stat-Signature: t3rpagp1zm5xdg57dbiu4qzri5rkzxun X-HE-Tag: 1661766429-294502 X-Bogosity: Ham, tests=bogofilter, spamicity=0.004365, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia We can get the hotness value from damon_hot_score() directly in damon_pageout_score() function and improve the code readability. Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park --- mm/damon/ops-common.c | 46 ++++++------------------------------------- 1 file changed, 6 insertions(+), 40 deletions(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index b1335de200e7..f599838b5f64 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -88,7 +88,7 @@ void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr) #define DAMON_MAX_SUBSCORE (100) #define DAMON_MAX_AGE_IN_LOG (32) -int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, +int damon_hot_score(struct damon_ctx *c, struct damon_region *r, struct damos *s) { unsigned int max_nr_accesses; @@ -127,48 +127,14 @@ int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, */ hotness = hotness * DAMOS_MAX_SCORE / DAMON_MAX_SUBSCORE; - /* Return coldness of the region */ - return DAMOS_MAX_SCORE - hotness; + return hotness; } -int damon_hot_score(struct damon_ctx *c, struct damon_region *r, +int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, struct damos *s) { - unsigned int max_nr_accesses; - int freq_subscore; - unsigned int age_in_sec; - int age_in_log, age_subscore; - unsigned int freq_weight = s->quota.weight_nr_accesses; - unsigned int age_weight = s->quota.weight_age; - int hotness; - - max_nr_accesses = c->aggr_interval / c->sample_interval; - freq_subscore = r->nr_accesses * DAMON_MAX_SUBSCORE / max_nr_accesses; + int hotness = damon_hot_score(c, r, s); - age_in_sec = (unsigned long)r->age * c->aggr_interval / 1000000; - for (age_in_log = 0; age_in_log < DAMON_MAX_AGE_IN_LOG && age_in_sec; - age_in_log++, age_in_sec >>= 1) - ; - - /* If frequency is 0, higher age means it's colder */ - if (freq_subscore == 0) - age_in_log *= -1; - - /* - * Now age_in_log is in [-DAMON_MAX_AGE_IN_LOG, DAMON_MAX_AGE_IN_LOG]. - * Scale it to be in [0, 100] and set it as age subscore. - */ - age_in_log += DAMON_MAX_AGE_IN_LOG; - age_subscore = age_in_log * DAMON_MAX_SUBSCORE / - DAMON_MAX_AGE_IN_LOG / 2; - - hotness = (freq_weight * freq_subscore + age_weight * age_subscore); - if (freq_weight + age_weight) - hotness /= freq_weight + age_weight; - /* - * Transform it to fit in [0, DAMOS_MAX_SCORE] - */ - hotness = hotness * DAMOS_MAX_SCORE / DAMON_MAX_SUBSCORE; - - return hotness; + /* Return coldness of the region */ + return DAMOS_MAX_SCORE - hotness; }