From patchwork Fri Jan 27 01:19:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungchul Park X-Patchwork-Id: 13118040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DDCEC05027 for ; Fri, 27 Jan 2023 01:20:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EAD48E0005; Thu, 26 Jan 2023 20:19:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 774BC900002; Thu, 26 Jan 2023 20:19:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A1EF900003; Thu, 26 Jan 2023 20:19:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0A75F900002 for ; Thu, 26 Jan 2023 20:19:47 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D3B2BA0EF8 for ; Fri, 27 Jan 2023 01:19:46 +0000 (UTC) X-FDA: 80398821972.29.5A38D8D Received: from lgeamrelo11.lge.com (lgeamrelo13.lge.com [156.147.23.53]) by imf22.hostedemail.com (Postfix) with ESMTP id AD424C0004 for ; Fri, 27 Jan 2023 01:19:44 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf22.hostedemail.com: 156.147.23.53 is neither permitted nor denied by domain of max.byungchul.park@gmail.com) smtp.mailfrom=max.byungchul.park@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674782385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=705GyNEIJXEWyOVKsCQN1qIBphC8YCGkT9Dvo0ANs9k=; b=ubE/qQQjwmCxVuYmldYKecP2+mQ/EUsJY6OsW8fqLr4pjJBvzo5f+ioTxrpX5/y4aIceSD 4gAJinHtB8iDJDgzLzbGypMHv1i8NkgcL74vIP6dFFeb9Gx5ly2nTv4QM4TOqu12NcHmUQ nfyspcs5jRrNJfob2TvYlsqoWsrFf/Q= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf22.hostedemail.com: 156.147.23.53 is neither permitted nor denied by domain of max.byungchul.park@gmail.com) smtp.mailfrom=max.byungchul.park@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674782385; a=rsa-sha256; cv=none; b=ZBvRG98VVoVqluEyxe6EfTOc64YwL3Q3/KMyQxAMCrCA5g7BuNWZjWkIb2HtdJN4QtTELQ 22f2x4GUSLlDkOEMuh06VSLKv3scotdjoIsaYeU5CpwPG+F7NwPmNfdBY7SKG5jqJv2saL kjGND0WqMY3o/KZatHGIMxyyFZlVlP8= Received: from unknown (HELO lgemrelse7q.lge.com) (156.147.1.151) by 156.147.23.53 with ESMTP; 27 Jan 2023 10:19:42 +0900 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: max.byungchul.park@gmail.com Received: from unknown (HELO localhost.localdomain) (10.177.244.38) by 156.147.1.151 with ESMTP; 27 Jan 2023 10:19:42 +0900 X-Original-SENDERIP: 10.177.244.38 X-Original-MAILFROM: max.byungchul.park@gmail.com From: Byungchul Park To: linux-kernel@vger.kernel.org Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com Subject: [PATCH v8 15/25] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread Date: Fri, 27 Jan 2023 10:19:08 +0900 Message-Id: <1674782358-25542-16-git-send-email-max.byungchul.park@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1674782358-25542-1-git-send-email-max.byungchul.park@gmail.com> References: <1674782358-25542-1-git-send-email-max.byungchul.park@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AD424C0004 X-Stat-Signature: c8c9fynidbqkoo5q7nhdaq45k7y88qzj X-HE-Tag: 1674782384-308587 X-HE-Meta: U2FsdGVkX1/9BU7hCmhVhRnb14YMgPK6c895NW3csl07l1HtoHg2NYFVAoX0LSukmtSs30jGDoqrjgMQ3UxwiwtdGMA1jay31BS580G1r6vfILZ0cgyiVaNIKu2LxZf87Ksf4ncyyeVL277fM2Cv4M9oQeMEHju5cqF5DZKShGDt/qXFOtiXwWWtvqBBv3HszksL+G6jEH87sI6Q0duP29tUkxmGto915HThLQtwKRiS2JK1UIwOyMD7n6UAJocIbXFo1Zw0WkRY0olk1+JtXH+zwrxwKoz17IwFmREhY5sP5xdCepJycj/ddK1wTWXbEiD7+aDH4bqyI2Fta2hL5geuqsI9MhOv622GfueGalCm3rzxks6GdlTbNZsD53YLQQVSZ8bc4jwaF2VwXXdNAv7F/ZcUj9d2vxoUoEm2eoWSQE5eVj8+7HoUJpnBudB0HIDeixK3K36tfuLzwZD7/vjQocO8+wPO9JVQhGt8FHkLkljB/pQ/460k8WoXgv1tGpVrlDnH4smkP99yxxaWRWhiQAn6FRRGv0Q80fkk0eMHeVff/w8dUv6OEYC9JF9GC0emrkez7oM/mxzlTwdgjwYMpfXKJiRoMhgzs9NSVqEndcq3LVhsqFKyROLVWdieRBGlhY53Rv+SbWKj4XasC+UD2BdJsUpQvhgckt9VztfhjXDKGmPnzjMmfED+vf0wLId36AOEjCkPIkrV073ZsyIRpuORrS8eOP4DQI5A0vBpSLUkhlkXENydbBRw17Ej7hkfI1aBmv2KNA8C4diQx9/fpeXTQFTsa4I3p5vo3AZRdGn1AcTbiw8tP4bkeL3rYb8+TJwalW1XneWvzv7n5p4Dq9lAUsnTPbeOaFU3fCDlOvpT3L2EtWUNlIlrT3SWgiDjRO7/TyshnxmKc/dcAIyLk2kOG3KZ9m+w3qtbCNXBNqVezoDwcS+rCNruRSWxWgqtq8QAhAQ3a1CXsvd a+ibigHN Ez5/bHw0tcNKDvAVkafPHAnKvb8fWCdSCLr6a4BGho6MUnIkTOvxg6qG12REYyxYb4P5MLMiLFfRC6/wZuR+I9c9YBVJDbB2PWAHKZIMitQF6oBUYyDbBrikVIOcI6T4jUZL346qlmt7Kk6HcLNqlEQLGrIKUn/nGXrrLP/0nYv0iMBUNsodk2FxWypDh9fbP2LLp9fipijem63FUh+gt9pDsgM4Tr2yl8JOiItmI6tjS/AH5XIhL40RQ8YXN5GDGZkssG0TWAiQF72QgHVy8HXEkEGcZ4OWf2ETCrXFZ/JBHFgZGTqoXqeFNgUa7xNtatfXi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, false positive alarms was reported by that. Replaced it with try lock annotation. Signed-off-by: Byungchul Park --- kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index 6c0a92c..6a9b9c3 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -356,7 +356,7 @@ int lockdep_is_cpus_held(void) static void lockdep_acquire_cpus_lock(void) { - rwsem_acquire(&cpu_hotplug_lock.dep_map, 0, 0, _THIS_IP_); + rwsem_acquire(&cpu_hotplug_lock.dep_map, 0, 1, _THIS_IP_); } static void lockdep_release_cpus_lock(void)