Message ID | 1675154394-25598-16-git-send-email-max.byungchul.park@gmail.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD516C636D3 for <linux-mm@archiver.kernel.org>; Tue, 31 Jan 2023 08:40:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D20A06B0092; Tue, 31 Jan 2023 03:40:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C537B6B0096; Tue, 31 Jan 2023 03:40:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACC6D6B0095; Tue, 31 Jan 2023 03:40:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 994D16B0092 for <linux-mm@kvack.org>; Tue, 31 Jan 2023 03:40:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 950A1C0A6D for <linux-mm@kvack.org>; Tue, 31 Jan 2023 08:40:03 +0000 (UTC) X-FDA: 80414446686.14.0369FE7 Received: from lgeamrelo11.lge.com (lgeamrelo13.lge.com [156.147.23.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 6D7ED180013 for <linux-mm@kvack.org>; Tue, 31 Jan 2023 08:40:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=softfail (imf24.hostedemail.com: 156.147.23.53 is neither permitted nor denied by domain of max.byungchul.park@gmail.com) smtp.mailfrom=max.byungchul.park@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675154402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=705GyNEIJXEWyOVKsCQN1qIBphC8YCGkT9Dvo0ANs9k=; b=sDyLpNkGn8lnLlUTX2NcxoAjgBQ6gmhRnRxwfRfgPyDfynT+l3kcP2Z2yg55NvHi276mnp OSG2wxGBtYA8LM2d4xy9Q1Pf6PuPoHfPsM1ikfN854Wd8Je5hKursrahggcSDpOAptMJLy tCiS+nRaNa3dtYwBo7BngQ8Zw3ROoxM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=softfail (imf24.hostedemail.com: 156.147.23.53 is neither permitted nor denied by domain of max.byungchul.park@gmail.com) smtp.mailfrom=max.byungchul.park@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675154402; a=rsa-sha256; cv=none; b=EN6fDlbqUFEDAPJyao7d5QK76/rAe9QAjd2ib3d7MgRFI0a3KdNeST+8rQkLd7LOgXZbDS GkKBYplxQblyTXCIlaE1ZYZOvEWlHhvH3c03JR0EeGlXUyzZN26e6YjyQp194jlKcW6RWk VdpIJGZJxQzOn2J7xIsbryP1TDj1gWM= Received: from unknown (HELO lgeamrelo04.lge.com) (156.147.1.127) by 156.147.23.53 with ESMTP; 31 Jan 2023 17:40:00 +0900 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: max.byungchul.park@gmail.com Received: from unknown (HELO localhost.localdomain) (10.177.244.38) by 156.147.1.127 with ESMTP; 31 Jan 2023 17:40:00 +0900 X-Original-SENDERIP: 10.177.244.38 X-Original-MAILFROM: max.byungchul.park@gmail.com From: Byungchul Park <max.byungchul.park@gmail.com> To: linux-kernel@vger.kernel.org Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com Subject: [PATCH v9 15/25] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread Date: Tue, 31 Jan 2023 17:39:44 +0900 Message-Id: <1675154394-25598-16-git-send-email-max.byungchul.park@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1675154394-25598-1-git-send-email-max.byungchul.park@gmail.com> References: <1675154394-25598-1-git-send-email-max.byungchul.park@gmail.com> X-Stat-Signature: di81to5mgqytyw568cxdc14oc6xb6e5p X-Rspam-User: X-Rspamd-Queue-Id: 6D7ED180013 X-Rspamd-Server: rspam06 X-HE-Tag: 1675154401-597121 X-HE-Meta: U2FsdGVkX19EaXNoSAziywrCkOXlVZR3nADQu09HVuqGdEOAKqB9ULJuMxOnVob5GATKkEOHz4D69zrGPDj1DGbFixQUaXceTXd+j/KAcXXNF7Qo5WrLkiiLHmRHn/NS8d2gpPPNFaPs9G6ZRCSeH3Jphk0JXOnpyTEkUwKvVnuww1cuUieEq4raM/6DA3enF/QPUcns085ItDkPynE3/UndTPbtxEjAh4GkAMpPQ2iRFt4AQ0s9LBV9H5b6QOfCZr0IWvUqtbB5KqnV9jNIVhS8puC3ReUUfClRHyTVXkSJyoqDjJ34AktldgkxlqYsrF8WhhyIcRLH4IkpoNBZhbtCOuc+wL0f1Y1Y7lbM3IIZnll2hoYMF0wRzUwWYAkcMevjgKZCvSvYRvVO38eqX6ms2GGZmOWQhuJ4KM6vJGYJzHILMM37rqRF6WNU8F6xnjySTSxegvoJWcgB1CfbR6+KKZep5v02cAEN25pLL1OGJW3cs9xTWDYTk9jWFP7T4iT/aC5WUVsjJsRiHOnltkbBoadZ6zbtd7N1I9FDn4Y6c2U8Nc5Yu94FxM2WfenB7XFA+dOlF+eIPTe2Rs5T3b607bDBCa2GU5gXkFwc6g0nzBEIX/mWtrEO1R6WH00qalJLgKT3ks55zJ/vrTXnnBC3W91FVX6yp+TuoyWYEPesRls+AJWx6Nz57LxkU8QBOttQ8lv0CoyU2UBf5JtQtyw/iqBkf936wCs5Fd9Yx4+xO51CLjrJX+a+kecR1/CStT0ABe5GG+AYiHEX0DPdUJoj1YJC7YPpsHqnrmmKnh4RPqqV2/tMEwIeIO8TGMm1f+ShMsq01+aSFBG7w+uBPLdeO3d8KnByP74Y2UkmSGw+rqOc448coOXU2cW1Lw4clvWT7OSNTyTlmZDsjErbL4cGsUWmw0WLwg0h/nJGUoTXKKf2fWVKBOvrj6+bAfPviKjzDokxingv4j8AkTw bT/g7fwS O8QM7r6rK39xk05hZrue0tRwv1xFtLz99QenlUOQYzsI0Rozc55mOCJdud0bxAbwmrO+GySpX1PQIzfGG72SGz9y9rjGbavCJwuO1CJZCAHGKxfaHeRyYWp+om6NlRykv/Ogl3INz/MLRxzb9ji5KgichA5DStUSSrBUcRjsrRZCFoNF0B1XaMW2wnrV2UjwLK0z0QTygYzZGyi68i3399L0HDffwdQVTEXByNVr0o4wXbkojGJW3t3KyX/PXlxyfpZEgmloI1ZbKiGmn94VOAMcyLE+lzeyP2s90XcAQQESv2zpf6LfIWd0snkaKIkCrqLwAmqA64NBNv4TFIVRce7zLbvF62dRnqUGhNvue3fe4y9lCOcrGSIwQounMHwOKr57jwqKkU4wYgk35dEN2Kyk6MJPCVRv9qMLQBOLOITfKt8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
DEPT(Dependency Tracker)
|
expand
|
diff --git a/kernel/cpu.c b/kernel/cpu.c index 6c0a92c..6a9b9c3 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -356,7 +356,7 @@ int lockdep_is_cpus_held(void) static void lockdep_acquire_cpus_lock(void) { - rwsem_acquire(&cpu_hotplug_lock.dep_map, 0, 0, _THIS_IP_); + rwsem_acquire(&cpu_hotplug_lock.dep_map, 0, 1, _THIS_IP_); } static void lockdep_release_cpus_lock(void)
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, false positive alarms was reported by that. Replaced it with try lock annotation. Signed-off-by: Byungchul Park <max.byungchul.park@gmail.com> --- kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)