| Message ID | 167602001664.1924368.9102029637928071240.stgit@dwillia2-xfh.jf.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | CXL RAM and the 'Soft Reserved' => 'System RAM' default | expand |
On 2/10/23 2:06 AM, Dan Williams wrote: > Empty driver remove callbacks can just be elided. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reviewed-by: Gregory Price <gregory.price@memverge.com> > Tested-by: Fan Ni <fan.ni@samsung.com> > Link: https://lore.kernel.org/r/167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dax/hmem/hmem.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c > index 1bf040dbc834..c7351e0dc8ff 100644 > --- a/drivers/dax/hmem/hmem.c > +++ b/drivers/dax/hmem/hmem.c > @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) > return 0; > } > > -static int dax_hmem_remove(struct platform_device *pdev) > -{ > - /* devm handles teardown */ > - return 0; > -} > - > static struct platform_driver dax_hmem_driver = { > .probe = dax_hmem_probe, > - .remove = dax_hmem_remove, > .driver = { > .name = "hmem", > }, >
On Fri, 2023-02-10 at 01:06 -0800, Dan Williams wrote: > Empty driver remove callbacks can just be elided. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reviewed-by: Gregory Price <gregory.price@memverge.com> > Tested-by: Fan Ni <fan.ni@samsung.com> > Link: https://lore.kernel.org/r/167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > drivers/dax/hmem/hmem.c | 7 ------- > 1 file changed, 7 deletions(-) Looks good, Reviewed-by: Vishal Verma <vishal.l.verma@intel.com> > > diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c > index 1bf040dbc834..c7351e0dc8ff 100644 > --- a/drivers/dax/hmem/hmem.c > +++ b/drivers/dax/hmem/hmem.c > @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) > return 0; > } > > -static int dax_hmem_remove(struct platform_device *pdev) > -{ > - /* devm handles teardown */ > - return 0; > -} > - > static struct platform_driver dax_hmem_driver = { > .probe = dax_hmem_probe, > - .remove = dax_hmem_remove, > .driver = { > .name = "hmem", > }, >
diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c index 1bf040dbc834..c7351e0dc8ff 100644 --- a/drivers/dax/hmem/hmem.c +++ b/drivers/dax/hmem/hmem.c @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) return 0; } -static int dax_hmem_remove(struct platform_device *pdev) -{ - /* devm handles teardown */ - return 0; -} - static struct platform_driver dax_hmem_driver = { .probe = dax_hmem_probe, - .remove = dax_hmem_remove, .driver = { .name = "hmem", },